Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031585Retail ModulesDiscounts and Promotionspublic2015-11-25 18:312016-02-05 16:08
Reportermalsasua 
Assigned Tojorge-garcia 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in VersionRR16Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket39511
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031585: when more than 10 discount combos are added to the receipt, chrome crash
Descriptionwith the combos module, if you create a receipt with more than 10 discount combos the chrome crash
Steps To Reproduce. install combo discounts module (org.openbravo.retail.discounts.combo)
. install best deal module (org.openbravo.retail.discounts.bestdeal)
in backoffice:
 . create thtree new discounts type combo:
  discount: combo1
   . Family: F1
             qty 2
             prods:
                    p1
                    p2

  discount: combo2
   . Family: F2
             qty 2
             prods:
                    p3
                    p4
...
  discount: combo 10
   . Family: F10
             qty 2
             prods: p5
                    p6
. enable best deal case (see http://wiki.openbravo.com/wiki/Retail:Promotions_Best_Deal_Case [^] [^])
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0031073 closed Retail when several combos are added to the receipt, chrome crash 
related to defect 0027960 closed marvintm The generated js file containint static resouces has been built with the js of the erp instead of the js for WebPOs 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-11-25 18:31malsasuaNew Issue
2015-11-25 18:31malsasuaAssigned To => Retail
2015-11-25 18:31malsasuaOBNetwork customer => Yes
2015-11-25 18:31malsasuaSupport ticket => 39511
2015-11-25 18:31malsasuaResolution time => 1451775600
2015-11-25 18:31malsasuaTriggers an Emergency Pack => No
2015-11-25 18:31malsasuaRelationship addedrelated to 0031073
2015-11-25 18:32malsasuaRelationship addedrelated to 0027960
2015-11-25 18:40malsasuaNote Added: 0082350
2015-11-26 10:02OrekariaStatusnew => acknowledged
2015-12-02 19:50malsasuaResolution time1451775600 => 1449442800
2015-12-30 16:28OrekariaNote Deleted: 0082350
2016-01-29 09:20jorge-garciaAssigned ToRetail => jorge-garcia
2016-01-29 09:20jorge-garciaStatusacknowledged => scheduled
2016-02-04 15:59hgbotCheckin
2016-02-04 15:59hgbotNote Added: 0083928
2016-02-04 15:59hgbotStatusscheduled => resolved
2016-02-04 15:59hgbotResolutionopen => fixed
2016-02-04 15:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/35b5fee77c43ea94dd949db47b141023fc4a8f0a [^]
2016-02-05 16:08marvintmReview Assigned To => marvintm
2016-02-05 16:08marvintmStatusresolved => closed
2016-02-05 16:08marvintmFixed in Version => RR16Q2

Notes
(0083928)
hgbot   
2016-02-04 15:59   
Repository: erp/pmods/org.openbravo.retail.discounts.bestdeal
Changeset: 35b5fee77c43ea94dd949db47b141023fc4a8f0a
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Feb 04 15:50:18 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/35b5fee77c43ea94dd949db47b141023fc4a8f0a [^]

Fixed issue 31585: when more than 10 discount combos are added to the
receipt, chrome crash

The problem were in two parts. The first part is the quantity of products in the
receipt, and the second part is the quantity of possible promotions that can be
applied to the products. This two parts causes that Chrome crash ( Chrome crash
beetween 3 and 4 million of possible combinations for 42 products).

The solution is to reduce that number, so now, a new constant is defined. The
constant is a calculation of number of possible combinations multiply by the
number of products in the receipt. Rigth now, to be able to use this
functionality in a tablet, the maximun number is 100.000 combinations for 100
products defined in the receipt.

---
M web/org.openbravo.retail.discounts.bestdeal/source/discounts-best-deal-case.js
---