Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031579Openbravo ERPC. Securitypublic2015-11-25 13:262015-12-02 11:28
Reporteralostale 
Assigned Tocaristu 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q3.4Fixed in Version3.0PR15Q3.4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031579: alert fetches with where parameter
DescriptionAlert window shouldn't fetch data using where parameter.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0031577 closed caristu alert fetches with where parameter 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-11-25 13:27alostaleTypedefect => backport
2015-11-25 13:27alostaleTarget Version => 3.0PR15Q3.4
2015-12-01 18:35hgbotCheckin
2015-12-01 18:35hgbotNote Added: 0082496
2015-12-01 18:35hgbotStatusscheduled => resolved
2015-12-01 18:35hgbotResolutionopen => fixed
2015-12-01 18:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q3.4/rev/953d9e609f2161776d040f3f0c9443cb32a3570f [^]
2015-12-01 18:37caristuAssigned Toplatform => caristu
2015-12-01 18:38caristuReview Assigned To => alostale
2015-12-01 18:38caristuIssue Monitored: alostale
2015-12-02 10:40hgbotCheckin
2015-12-02 10:40hgbotNote Added: 0082522
2015-12-02 11:28alostaleNote Added: 0082527
2015-12-02 11:28alostaleStatusresolved => closed
2015-12-02 11:28alostaleFixed in Version => 3.0PR15Q3.4

Notes
(0082496)
hgbot   
2015-12-01 18:35   
Repository: erp/backports/3.0PR15Q3.4
Changeset: 953d9e609f2161776d040f3f0c9443cb32a3570f
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Dec 01 18:32:25 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q3.4/rev/953d9e609f2161776d040f3f0c9443cb32a3570f [^]

fixes issue 31579: alert fetches with where parameter

In order to avoid the fetching of the where parameter we generate the where clause inside the datasource. A new datasource has been created, ADAlertDatasourceService, to support the requests from the Alert Management window.

In addition, it has been fixed a problem in the Alert Rule drop-down filter of the grids in the Alert Management window which was displaying alert rules from all the grids in the window instead of those displayed just on a particular grid.

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/OBSERDS_DATASOURCE.xml
M modules/org.openbravo.client.application/src/org/openbravo/client/application/AlertManagementActionHandler.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/alert-management/ob-alert-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/alert-management/ob-alert-management-view.js
A modules/org.openbravo.client.application/src/org/openbravo/client/application/ADAlertDatasourceService.java
---
(0082522)
hgbot   
2015-12-02 10:40   
Repository: erp/backports/3.0PR15Q3.4
Changeset: 9818e69a1a146fad384ab359d08749b691f0a483
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Dec 02 10:39:19 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q3.4/rev/9818e69a1a146fad384ab359d08749b691f0a483 [^]

related to issue 31579: code review improvements

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/ADAlertDatasourceService.java
---
(0082527)
alostale   
2015-12-02 11:28   
code reviewed

tested:
* _where is not sent to DS
* limited role without any other access than alert management can:
  - see alerts
  - move to different status