Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031577Openbravo ERPC. Securitypublic2015-11-25 13:262015-12-02 20:07
Reporteralostale 
Assigned Tocaristu 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031577: alert fetches with where parameter
DescriptionAlert window shouldn't fetch data using where parameter.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00315783.0PR15Q4.1 closed caristu alert fetches with where parameter 
depends on backport 00315793.0PR15Q3.4 closed caristu alert fetches with where parameter 
related to defect 0031634 closed caristu Is not possible to use the refresh button in the Alert Management window more than once 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-11-25 13:26alostaleNew Issue
2015-11-25 13:26alostaleAssigned To => platform
2015-11-25 13:26alostaleModules => Core
2015-11-25 13:26alostaleTriggers an Emergency Pack => No
2015-11-25 13:27alostaleStatusnew => scheduled
2015-11-25 13:27alostaleAssigned Toplatform => caristu
2015-12-01 18:29hgbotCheckin
2015-12-01 18:29hgbotNote Added: 0082495
2015-12-01 18:29hgbotStatusscheduled => resolved
2015-12-01 18:29hgbotResolutionopen => fixed
2015-12-01 18:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/83f6116ba55b506649fecc0d2f42e775f6728472 [^]
2015-12-01 18:31caristuReview Assigned To => alostale
2015-12-01 18:31caristuIssue Monitored: alostale
2015-12-01 18:52caristuRelationship addedrelated to 0031634
2015-12-02 00:10hudsonbotCheckin
2015-12-02 00:10hudsonbotNote Added: 0082512
2015-12-02 10:36hgbotCheckin
2015-12-02 10:36hgbotNote Added: 0082520
2015-12-02 11:27alostaleNote Added: 0082525
2015-12-02 11:27alostaleStatusresolved => closed
2015-12-02 11:27alostaleFixed in Version => 3.0PR16Q1
2015-12-02 20:07hudsonbotCheckin
2015-12-02 20:07hudsonbotNote Added: 0082554

Notes
(0082495)
hgbot   
2015-12-01 18:29   
Repository: erp/devel/pi
Changeset: 83f6116ba55b506649fecc0d2f42e775f6728472
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Dec 01 18:27:51 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/83f6116ba55b506649fecc0d2f42e775f6728472 [^]

fixes issue 31577: alert fetches with where parameter

In order to avoid the fetching of the where parameter we generate the where clause inside the datasource. A new datasource has been created, ADAlertDatasourceService, to support the requests from the Alert Management window.

In addition, it has been fixed a problem in the Alert Rule drop-down filter of the grids in the Alert Management window which was displaying alert rules from all the grids in the window instead of those displayed just on a particular grid.

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/OBSERDS_DATASOURCE.xml
M modules/org.openbravo.client.application/src/org/openbravo/client/application/AlertManagementActionHandler.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/alert-management/ob-alert-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/alert-management/ob-alert-management-view.js
A modules/org.openbravo.client.application/src/org/openbravo/client/application/ADAlertDatasourceService.java
---
(0082512)
hudsonbot   
2015-12-02 00:10   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a52bb700bbaf [^]
Maturity status: Test
(0082520)
hgbot   
2015-12-02 10:36   
Repository: erp/devel/pi
Changeset: 9b3efdffbb5f9667b8fde442df7893561ddc635f
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Dec 02 10:33:15 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9b3efdffbb5f9667b8fde442df7893561ddc635f [^]

related to issue 31577: code review improvements

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/ADAlertDatasourceService.java
---
(0082525)
alostale   
2015-12-02 11:27   
code reviewed

tested:
* _where is not sent to DS
* limited role without any other access than alert management can:
  - see alerts
  - move to different status
(0082554)
hudsonbot   
2015-12-02 20:07   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ae274ef69cf6 [^]
Maturity status: Test