Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031570Retail ModulesWeb POSpublic2015-11-25 09:592015-12-23 13:20
Reporteramayavicente 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q1 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031570: [SERQA 436] A user who has NOT access to any payment methods belong to a category, see the category in the webpos
DescriptionFor a payment method category, a user who has NOT access to any payment methods belong to that category, see the category in the webpos and when open it, it is empty.
Steps To Reproduce1. Create new POS Payment Method Category called 'Cards'
2. For the POS Terminal type 'VBS POS Terminal Type' include 'Voucher' and 'Credit Card' in the category created in the step1.
3. In the preference window, define that the user Vall Blanca Store User has NOT access to the payment method 'Voucher' and 'Credit Card'
Proposed Solution
Additional Information
TagsSER-QA
Relationships
Attached Files? payment_category (4,557,118) 2015-12-14 11:45
https://issues.openbravo.com/file_download.php?file_id=8803&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-11-25 09:59amayavicenteNew Issue
2015-11-25 09:59amayavicenteAssigned To => Retail
2015-11-25 09:59amayavicenteResolution time => 1449615600
2015-11-25 09:59amayavicenteTriggers an Emergency Pack => No
2015-11-25 12:59OrekariaStatusnew => acknowledged
2015-11-26 11:55ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2015-11-26 11:55ranjith_qualiantech_comStatusacknowledged => scheduled
2015-12-01 11:13ageteTag Attached: SER-QA
2015-12-01 11:13ageteSummaryA user who has NOT access to any payment methods belong to a category, see the category in the webpos => [SERQA 436] A user who has NOT access to any payment methods belong to a category, see the category in the webpos
2015-12-02 06:31hgbotCheckin
2015-12-02 06:31hgbotNote Added: 0082513
2015-12-02 06:31hgbotCheckin
2015-12-02 06:31hgbotNote Added: 0082514
2015-12-02 06:31hgbotStatusscheduled => resolved
2015-12-02 06:31hgbotResolutionopen => fixed
2015-12-02 06:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/99240bd55802265de720d8516787c3b4ced3b983 [^]
2015-12-07 12:10guilleaerNote Added: 0082594
2015-12-07 12:10guilleaerStatusresolved => new
2015-12-07 12:10guilleaerResolutionfixed => open
2015-12-07 12:10guilleaerStatusnew => scheduled
2015-12-11 04:17hgbotCheckin
2015-12-11 04:17hgbotNote Added: 0082661
2015-12-11 04:17hgbotStatusscheduled => resolved
2015-12-11 04:17hgbotResolutionopen => fixed
2015-12-11 04:17hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/99240bd55802265de720d8516787c3b4ced3b983 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/555cf6ca5d800e8a415fec9c63d9299904125d40 [^]
2015-12-14 11:45guilleaerNote Added: 0082701
2015-12-14 11:45guilleaerStatusresolved => new
2015-12-14 11:45guilleaerResolutionfixed => open
2015-12-14 11:45guilleaerFile Added: payment_category
2015-12-14 13:45OrekariaStatusnew => scheduled
2015-12-15 07:58hgbotCheckin
2015-12-15 07:58hgbotNote Added: 0082744
2015-12-15 07:58hgbotStatusscheduled => resolved
2015-12-15 07:58hgbotResolutionopen => fixed
2015-12-15 07:58hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/555cf6ca5d800e8a415fec9c63d9299904125d40 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8b79e190a66eeea8fb8c2267ac219d3c1f47f690 [^]
2015-12-15 16:39OrekariaReview Assigned To => marvintm
2015-12-22 13:46ageteNote Added: 0082939
2015-12-22 13:46ageteStatusresolved => new
2015-12-22 13:46ageteResolutionfixed => open
2015-12-23 13:20OrekariaReview Assigned Tomarvintm => Orekaria
2015-12-23 13:20OrekariaStatusnew => closed
2015-12-23 13:20OrekariaResolutionopen => fixed
2015-12-23 13:20OrekariaFixed in Version => RR16Q1

Notes
(0082513)
hgbot   
2015-12-02 06:31   
Repository: tools/automation/pi-mobile
Changeset: 916e6b2ed905cb8a92caaf0d766195dba4f84fb8
Author: Ranjith <ranjith <at> qualiantech.com>
Date: Wed Dec 02 11:00:29 2015 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/916e6b2ed905cb8a92caaf0d766195dba4f84fb8 [^]

Verifies issue 31570: Added automated test 'I31570CheckPaymentTypesBasedonPreference'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I31570CheckPaymentTypesBasedonPreference.java
---
(0082514)
hgbot   
2015-12-02 06:31   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 99240bd55802265de720d8516787c3b4ced3b983
Author: Ranjith <ranjith <at> qualiantech.com>
Date: Wed Dec 02 11:00:43 2015 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/99240bd55802265de720d8516787c3b4ced3b983 [^]

Fixes issue 31570 : Show Payment Types based on Preferences

---
M src/org/openbravo/retail/posterminal/term/Payments.java
---
(0082594)
guilleaer   
2015-12-07 12:10   
The fix is not valid, because in the fix just "default" payments preferences are being checked. If there are more payment methods with different keys they also should be checked.
To do it, the query should search preferences for the "distinct" search key defined in OBPOS_APP_Payment

http://wiki.openbravo.com/wiki/Retail:Configuration_Guide#POS_Terminal_window [^]
(0082661)
hgbot   
2015-12-11 04:17   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 555cf6ca5d800e8a415fec9c63d9299904125d40
Author: Ranjith <ranjith <at> qualiantech.com>
Date: Fri Dec 11 08:46:25 2015 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/555cf6ca5d800e8a415fec9c63d9299904125d40 [^]

Fixes issue 31570 : Show Payment Types based on Preferences

---
M src/org/openbravo/retail/posterminal/term/Payments.java
---
(0082701)
guilleaer   
2015-12-14 11:45   
I can still reproduce the issue:

1. create debit payment category
2. open ps-1 terminal
3. navigate to terminal type
4. set voucher and card with the created category
5. check in web pos that everything is ok.
6. create a preference to disable card
7. check in web pos that just voucher is shown in the category popup
8. create a preference to disable voucher

check that category is still being shown in web POS, but the popup is empty.

Attached a video
(0082744)
hgbot   
2015-12-15 07:58   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8b79e190a66eeea8fb8c2267ac219d3c1f47f690
Author: Ranjith <ranjith <at> qualiantech.com>
Date: Tue Dec 15 12:27:03 2015 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8b79e190a66eeea8fb8c2267ac219d3c1f47f690 [^]

Fixes issue 31570 : Show Payment Types based on Preferences

---
M src/org/openbravo/retail/posterminal/term/Payments.java
---
(0082939)
agete   
2015-12-22 13:46   
The solution is incomplete because the payment method category still appears if the payment methods that belong to it are deactivated.

Steps to reproduce:
1. Go to POS terminal and deactivate all payment methods of one payment method category.
2. Log into WEB POS and check the payment method category is available but when clicking no payment method is available there