Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031566Openbravo ERPA. Platformpublic2015-11-24 18:332015-11-30 10:46
Reportermaite 
Assigned Tocaristu 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031566: Error when closing window where view personalization and grid configuration are defined
DescriptionError when closing window where view personalization and grid configuration are defined
Steps To Reproduce1. Ensure that instance is active
2. Access Producto window, filter by Active=Yes and save view as "active products"
3. Move Active column to be the first one of the grid
4. Close window
5. Access Product window again (NOT by clicking on Recent Views by searching it) and try to close window. Realize that tab is left blank and following javascript error is raised "Uncaught TypeError: Cannot read property 'dataPath' of null"

NOTE: if you select any product record then you will be able to close the window
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-11-24 18:33maiteNew Issue
2015-11-24 18:33maiteAssigned To => platform
2015-11-24 18:33maiteModules => Core
2015-11-24 18:33maiteTriggers an Emergency Pack => No
2015-11-24 18:33maiteIssue Monitored: networkb
2015-11-27 11:11caristuSeverityminor => major
2015-11-27 11:11caristuNote Added: 0082415
2015-11-27 11:11caristuAssigned Toplatform => caristu
2015-11-27 11:11caristuStatusnew => scheduled
2015-11-27 12:29caristuReview Assigned To => alostale
2015-11-27 12:29caristuIssue Monitored: alostale
2015-11-27 12:29hgbotCheckin
2015-11-27 12:29hgbotNote Added: 0082423
2015-11-27 12:29hgbotStatusscheduled => resolved
2015-11-27 12:29hgbotResolutionopen => fixed
2015-11-27 12:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/71227823d93070ee91799425511be0bd8a0de7b0 [^]
2015-11-28 15:24hudsonbotCheckin
2015-11-28 15:24hudsonbotNote Added: 0082450
2015-11-30 10:46alostaleNote Added: 0082464
2015-11-30 10:46alostaleStatusresolved => closed
2015-11-30 10:46alostaleFixed in Version => 3.0PR16Q1

Notes
(0082415)
caristu   
2015-11-27 11:11   
This can be reproduced also when closing any tab having the focus on the filter of a yes/no field.
(0082423)
hgbot   
2015-11-27 12:29   
Repository: erp/devel/pi
Changeset: 71227823d93070ee91799425511be0bd8a0de7b0
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Nov 27 12:19:15 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/71227823d93070ee91799425511be0bd8a0de7b0 [^]

fixes issue 31566: Error when closing window having focus on a yes/no filter

When closing the tab having the focus on a OBYesNoItem, the handleEditorExit() method of this class is executed, causing an unexpected javascript error on the getCriteriaFieldName() method, because is not possible to reference the form as it is being destroyed.

It does not make sense to execute handleEditorExit() when closing (destroying) the window. So to avoid this execution we introduce a new flag for the items (isBeingDestroyed) to mark that they are being destroyed. Thus, it is used for OBYesNoItem to identify whether standard handleEditorExit() flow must be executed or not.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-yesno.js
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
(0082450)
hudsonbot   
2015-11-28 15:24   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a30fd74371da [^]
Maturity status: Test
(0082464)
alostale   
2015-11-30 10:46   
code reviewed + tested