Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031547Retail ModulesLayaway orderpublic2015-11-20 12:152016-02-03 13:26
Reporterlorenzofidalgo 
Assigned ToOrekaria 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in VersionRR16Q1 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression levelPackaging and release
Regression date
Regression introduced in releasemain
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031547: Clicking more than once in "Layaway" button induces that it is not possible save layaways from that moment
DescriptionWhen a receipt is going to be laid away, clicking more than once in "Layaway" button induces that it is not possible to save layaways from that moment. In chrome console several errors can be seen. I have tried to logout/login and it is still not possible to save layaways.
This issue is reproducible in pi, main & RR15Q4, but this is working correctly in RR15Q3.2

Some of the logs of the console are attached
Steps To Reproduce0-Login POS as vallblanca.
1-Add a product to the receipt.
2-In dropdown menu, click "Layaway this Receipt".
3-Click Total Amount button.
4-Open Chrome console.
5-Click quickly several times in "Layaway" button.
6-Defect: Watch errors in chrome console.
7-Defect: Go to "Layaways" section in dropdown menu. Watch the just created layaway does not appear. No more layaways can be saved.

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0030236 closed Orekaria Pressing Layaway button more than once we increment doc number 
depends on backport 0031555RR15Q4.1 closed guilleaer Clicking more than once in "Layaway" button induces that it is not possible save layaways from that moment  
depends on backport 0031706RR15Q4.2 closed Orekaria Clicking more than once in "Layaway" button induces that it is not possible save layaways from that moment  
related to defect 0031781 scheduled rqueralta All buttons in payment window of the POS must have the same behaviour 
Attached Filespng ConsoleErrors.png (80,899) 2015-11-20 12:15
https://issues.openbravo.com/file_download.php?file_id=8755&type=bug
png

log console.log (21,324) 2015-11-20 13:19
https://issues.openbravo.com/file_download.php?file_id=8758&type=bug
diff issue.diff (1,245) 2015-11-21 16:18
https://issues.openbravo.com/file_download.php?file_id=8759&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-11-20 12:15lorenzofidalgoNew Issue
2015-11-20 12:15lorenzofidalgoAssigned To => Retail
2015-11-20 12:15lorenzofidalgoFile Added: ConsoleErrors.png
2015-11-20 12:15lorenzofidalgoRegression level => Packaging and release
2015-11-20 12:15lorenzofidalgoRegression introduced in release => main
2015-11-20 12:15lorenzofidalgoTriggers an Emergency Pack => No
2015-11-20 12:16lorenzofidalgoRelationship addedrelated to 0030236
2015-11-20 12:40lorenzofidalgoSummary[RR15Q4] Clicking more than once in "Layaway" button to layaway a receipt induce visible errors in chrome console => [RR15Q4] Clicking more than once in "Layaway" button induce visible errors in chrome console and receipt is not saved
2015-11-20 12:40lorenzofidalgoDescription Updatedbug_revision_view_page.php?rev_id=10307#r10307
2015-11-20 12:40lorenzofidalgoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=10309#r10309
2015-11-20 12:40lorenzofidalgoSeverityminor => major
2015-11-20 13:01lorenzofidalgoSummary[RR15Q4] Clicking more than once in "Layaway" button induce visible errors in chrome console and receipt is not saved => [RR15Q4] Clicking more than once in "Layaway" button induces that it is not possible save layaways from that moment
2015-11-20 13:01lorenzofidalgoDescription Updatedbug_revision_view_page.php?rev_id=10312#r10312
2015-11-20 13:01lorenzofidalgoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=10313#r10313
2015-11-20 13:14OrekariaStatusnew => acknowledged
2015-11-20 13:19OrekariaDescription Updatedbug_revision_view_page.php?rev_id=10319#r10319
2015-11-20 13:19OrekariaFile Added: console.log
2015-11-21 16:17guilleaerAssigned ToRetail => guilleaer
2015-11-21 16:18guilleaerStatusacknowledged => scheduled
2015-11-21 16:18guilleaerFile Added: issue.diff
2015-11-21 16:19guilleaerNote Added: 0082040
2015-11-23 12:11guilleaerNote Added: 0082072
2015-11-23 12:11guilleaerStatusscheduled => resolved
2015-11-23 12:11guilleaerFixed in Version => RR16Q1
2015-11-23 12:11guilleaerResolutionopen => fixed
2015-12-07 18:23marvintmReview Assigned To => marvintm
2015-12-07 18:23marvintmStatusresolved => closed
2015-12-09 10:27guilleaerSummary[RR15Q4] Clicking more than once in "Layaway" button induces that it is not possible save layaways from that moment => Clicking more than once in "Layaway" button induces that it is not possible save layaways from that moment
2015-12-14 20:04OrekariaNote Added: 0082740
2015-12-14 20:04OrekariaStatusclosed => new
2015-12-14 20:04OrekariaResolutionfixed => open
2015-12-14 20:04OrekariaFixed in VersionRR16Q1 =>
2015-12-14 20:04OrekariaStatusnew => scheduled
2015-12-15 16:15OrekariaAssigned Toguilleaer => Orekaria
2015-12-17 12:49hgbotCheckin
2015-12-17 12:49hgbotNote Added: 0082821
2015-12-17 12:49hgbotCheckin
2015-12-17 12:49hgbotNote Added: 0082822
2015-12-17 12:51OrekariaStatusscheduled => resolved
2015-12-17 12:51OrekariaFixed in Version => RR16Q1
2015-12-17 12:51OrekariaResolutionopen => fixed
2015-12-17 13:46hgbotCheckin
2015-12-17 13:46hgbotNote Added: 0082829
2015-12-17 13:46hgbotCheckin
2015-12-17 13:46hgbotNote Added: 0082830
2015-12-28 10:48jorge-garciaRelationship addedrelated to 0031781
2015-12-28 10:49jorge-garciaNote Added: 0083008
2015-12-28 10:49jorge-garciaReview Assigned Tomarvintm => jorge-garcia
2015-12-28 10:49jorge-garciaStatusresolved => closed
2016-02-03 13:25hgbotCheckin
2016-02-03 13:25hgbotNote Added: 0083890
2016-02-03 13:26hgbotCheckin
2016-02-03 13:26hgbotNote Added: 0083891

Notes
(0082040)
guilleaer   
2015-11-21 16:19   
Attached a diff which have passed try
(0082072)
guilleaer   
2015-11-23 12:11   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1adb4a2d23e9f8ac698ab122b17b7d4e4f14a129
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Nov 23 12:06:51 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1adb4a2d23e9f8ac698ab122b17b7d4e4f14a129 [^] [^]

Fixed issue 30236, 31547: Layaway button is disabled when it is pressed and scrim is shown

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0082740)
Orekaria   
2015-12-14 20:04   
using show/hide and enable/disable is inconsistent
the effect can be shown if this test is run:

    tap(TestId.BUTTON_BROWSE);
    tap(TestId.BUTTON_CATEGORY_BACKPACKSANDTRAVEL);
    tap(TestId.BUTTON_PRODUCT_BACKPACKSANDTRAVEL_ALPINESKIING);
    verify(TestId.LABEL_TOTALTOPAY, "109.90");
    tap(TestId.BUTTON_PAY);
    isVisible(TestId.BUTTON_PAY_EXACT, true);
    isVisible(TestId.BUTTON_LAYAWAY, false);
    isVisible(TestId.BUTTON_PAY_USECREDIT, false);
    tap(TestId.BUTTON_MENU);
    tap(TestId.BUTTON_MENU_LAYAWAYTHISRECEIPT);
    verify(TestId.LABEL_RECEIPT_TYPE, "To be laid away");
    isVisible(TestId.BUTTON_LAYAWAY, true);
    isVisible(TestId.BUTTON_PAY_USECREDIT, false);
    isVisible(TestId.BUTTON_PAY_EXACT, false);
    tap(TestId.BUTTON_LAYAWAY);
    verify(TestId.LABEL_TOTALTOPAY, "0.00");

    tap(TestId.BUTTON_BROWSE);
    tap(TestId.BUTTON_CATEGORY_BACKPACKSANDTRAVEL);
    tap(TestId.BUTTON_PRODUCT_BACKPACKSANDTRAVEL_ALPINESKIING);
    verify(TestId.LABEL_TOTALTOPAY, "109.90");
    tap(TestId.BUTTON_PAY);
    isVisible(TestId.BUTTON_PAY_EXACT, true);
    isVisible(TestId.BUTTON_LAYAWAY, false);
    isVisible(TestId.BUTTON_PAY_USECREDIT, false);
    tap(TestId.BUTTON_MENU);
    tap(TestId.BUTTON_MENU_LAYAWAYTHISRECEIPT);
    verify(TestId.LABEL_RECEIPT_TYPE, "To be laid away");
    isVisible(TestId.BUTTON_LAYAWAY, true);
    isVisible(TestId.BUTTON_PAY_USECREDIT, false);
    isVisible(TestId.BUTTON_PAY_EXACT, false);
    tap(TestId.BUTTON_LAYAWAY);
    verify(TestId.LABEL_TOTALTOPAY, "0.00");
(0082821)
hgbot   
2015-12-17 12:49   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9342c18cd1856bc3e631d21c2846fd54bdfcc636
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Mon Dec 14 20:07:44 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9342c18cd1856bc3e631d21c2846fd54bdfcc636 [^]

Backed out issue 30236, issue 31547; changeset: 1adb4a2d23e9

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0082822)
hgbot   
2015-12-17 12:49   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1e7064538e5efd7e7c9c9fb22b4c9627676b2087
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Mon Dec 14 20:15:34 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1e7064538e5efd7e7c9c9fb22b4c9627676b2087 [^]

Fixes issue 30236, issue 31547: The scrim and the 'showing' value prevent the layaway button from being tapped more than once

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0082829)
hgbot   
2015-12-17 13:46   
Repository: tools/automation/pi-mobile
Changeset: 3127dd2a732e98cdbb4f48994e93e8a7cc32dcbb
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Thu Dec 17 12:47:21 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/3127dd2a732e98cdbb4f48994e93e8a7cc32dcbb [^]

Automated issue 31547: The layaway button is replaced by the done button when the amount exact

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I26458_LayawayCashupWrongTaxesInformation.java
---
(0082830)
hgbot   
2015-12-17 13:46   
Repository: tools/automation/pi-mobile
Changeset: cd045e6c7ecf79461b037c29b089f5062579ebed
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Mon Dec 14 20:20:08 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/cd045e6c7ecf79461b037c29b089f5062579ebed [^]

Verifies issue 31547: Added automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31547_LayawayButtonMultipleTaps.java
---
(0083008)
jorge-garcia   
2015-12-28 10:49   
Code review and testing OK
(0083890)
hgbot   
2016-02-03 13:25   
Repository: tools/automation/pi-mobile
Changeset: 87fd92da7f2798c15bb3ded0b21acc6d309022bd
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Thu Dec 17 12:47:21 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/87fd92da7f2798c15bb3ded0b21acc6d309022bd [^]

Automated issue 31547: The layaway button is replaced by the done button when the amount exact

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I26458_LayawayCashupWrongTaxesInformation.java
---
(0083891)
hgbot   
2016-02-03 13:26   
Repository: tools/automation/pi-mobile
Changeset: d36fdd72317c5e9e28b84484183679229bb53b2b
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Mon Dec 14 20:20:08 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/d36fdd72317c5e9e28b84484183679229bb53b2b [^]

Verifies issue 31547: Added automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31547_LayawayButtonMultipleTaps.java
---