Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031516Openbravo ERP09. Financial managementpublic2015-11-17 13:322015-11-19 15:49
Reporteraferraz 
Assigned Toaferraz 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionProfessional Appliance
Product Version 
Target Version3.0PR15Q4Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPackaging and release
Regression date2015-11-11
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/fe7e7c17712b [^]
Triggers an Emergency PackNo
Summary0031516: Empty matched document when running Match Statement pocess
DescriptionMatched Document keeps empty in Match Statement grid although record is matched.
Steps To ReproduceAs FB Admin:

- Go to Financial Account windonw and select Cuenta de Banco
  Move to Imported Bank Statements tab and create a record.
  Move to Bank Statement Lines tab and create a record with payment in = 10.
  Click on Process button.

- Click on Match Statement button.
  Click Cancel in Confirm popup.
  Select the record shown in the grid and click + button (Add new transaction).
  Select any gl item in Add Transaction popup and click Done.
  Clear filter is necessary to show matched bank statements.
  Realize record appears as matched but Matched Document column is empty.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 00315153.0PR16Q1 closed aferraz Empty matched document when running Match Statement pocess 
Attached Filesdiff 31516.diff (5,688) 2015-11-18 14:02
https://issues.openbravo.com/file_download.php?file_id=8745&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-11-17 15:29aferrazTypedefect => backport
2015-11-17 15:29aferrazTarget Version3.0PR16Q1 => 3.0PR15Q4
2015-11-18 14:02vmromanosFile Added: 31516.diff
2015-11-18 14:04vmromanosNote Added: 0081954
2015-11-19 15:49hgbotCheckin
2015-11-19 15:49hgbotNote Added: 0081992
2015-11-19 15:49hgbotStatusscheduled => resolved
2015-11-19 15:49hgbotResolutionopen => fixed
2015-11-19 15:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q4/rev/ae68ce4ec8712f3bc48386edfacb89b39f439adb [^]
2015-11-19 15:49vmromanosReview Assigned To => vmromanos
2015-11-19 15:49vmromanosStatusresolved => closed

Notes
(0081954)
vmromanos   
2015-11-18 14:04   
Code review + testing of the attached changeset OK
(0081992)
hgbot   
2015-11-19 15:49   
Repository: erp/backports/3.0PR15Q4
Changeset: ae68ce4ec8712f3bc48386edfacb89b39f439adb
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Nov 17 18:03:25 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q4/rev/ae68ce4ec8712f3bc48386edfacb89b39f439adb [^]

Fixes issue 31516: Empty matched document in Match Statement

The problem was that two new columns were added in aprm_matchstatement hql query in the middle of the select clause, while they were added as two new columns at the end of ad_column. As the columns order was not the same between the hql query and the ad_column and some columns did not have an alias in hql query and some others did not have an entity alias in ad_column, some column values were lost.
To fix it, we added an alias to all columns in aprm_matchstatement hql query (matchedDocument had no alias) and an entity alias to all ad_columns in aprm_matchstatement table (Transaction, bslUpdated and matchedDocument columns had no entity alias and Affinity column had a wrong entity alias).
With this, all columns of aprm_matchstatement will be correctly filled with their values in Match Statement grid.
If new columns are added to the hql query, they can go in any order in the select clause and in the ad_column, but they will need to have both an alias in the hql query and an entity alias in the ad_column, following this documentation: http://wiki.openbravo.com/wiki/How_to_create_a_HQL_Based_Table#Column_Definition [^]

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TABLE.xml
---