Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031482Openbravo ERPZ. Otherspublic2015-11-14 14:322015-11-23 08:28
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031482: Cleanup warnings of Raw Types / non generics usage
DescriptionCleanup code using un-parametric types for no good reason.


Steps To ReproduceCheck eclipse warnings on 'Type Safety and Raw Types'
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks feature request 0031477 new shuehner Tracking issue to reduce the huge number of eclipse warnings in pi 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-11-14 14:32shuehnerNew Issue
2015-11-14 14:32shuehnerAssigned To => shuehner
2015-11-14 14:32shuehnerOBNetwork customer => No
2015-11-14 14:32shuehnerModules => Core
2015-11-14 14:32shuehnerTriggers an Emergency Pack => No
2015-11-14 14:32shuehnerRelationship addedblocks 0031477
2015-11-16 14:01shuehnerReview Assigned To => alostale
2015-11-16 19:18hgbotCheckin
2015-11-16 19:18hgbotNote Added: 0081910
2015-11-16 19:18hgbotStatusnew => resolved
2015-11-16 19:18hgbotResolutionopen => fixed
2015-11-16 19:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/75603f5172e634a82622adf4216e948026f527b7 [^]
2015-11-23 08:28alostaleNote Added: 0082054
2015-11-23 08:28alostaleStatusresolved => closed
2015-11-23 08:28alostaleFixed in Version => 3.0PR16Q1

Notes
(0081910)
hgbot   
2015-11-16 19:18   
Repository: erp/devel/pi
Changeset: 75603f5172e634a82622adf4216e948026f527b7
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sat Nov 14 14:34:45 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/75603f5172e634a82622adf4216e948026f527b7 [^]

Fixed 31482: Fix Type Safety and Raw Types warnings

- AdvPaymentMngtDao, parametrize obc parameters as function
  is private and only used with that specific paramtetric type
- ConvertQuotationIntoOrder
  - Iterator+Entry usage of a already parametric Map
    So no reason to abandon type info + later need manual casts
    again.
- ProductionMultiple problem is older servlet api not having
  a generic version of those methods so just silence this one
  with a SupressWarnings

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java
M src/org/openbravo/erpCommon/ad_process/ConvertQuotationIntoOrder.java
M src/org/openbravo/erpCommon/info/ProductMultiple.java
---
(0082054)
alostale   
2015-11-23 08:28   
code reviewed