Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031464Retail ModulesWeb POSpublic2015-10-26 14:532015-11-13 16:30
Reportermtaal 
Assigned Tomigueldejuana 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q4Fixed in VersionRR15Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031464: Address popup does an additional request when selecting an address
DescriptionWhen selecting an address (click on it) the address popup does an extra request when hiding the popup. See this part of the code in the components/bplocation.js

clearAction: function () {
    this.$.bpsLocationSearchfilterText.setValue('');
    this.doSearchAction({
      locName: this.$.bpsLocationSearchfilterText.getValue()
    });
    return true;
  },

which is called from here:
  executeOnHide: function () {
    this.$.body.$.listBpsLoc.$.bpsloclistitemprinter.$.theader.$.modalBpLocScrollableHeader.clearAction();
  },

Probably it is nicer/better to clear the search results in a different way instead of doing an extra request
Steps To Reproduce- Login into webpos
- click on address button in the ticket
- search for addresses
- click on one
- see that an additional request is done
Proposed SolutionPrevent the extra request and clear the result table directly
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0031249RR16Q1 closed migueldejuana Address popup does an additional request when selecting an address 
causes backport 0031508 closed Retail [RR15Q4] Uncaught exception is shown clicking in an address in "Assign customer address to receipt" Popup 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-11-13 11:41OrekariaTypedefect => backport
2015-11-13 11:41OrekariaTarget VersionRR16Q1 => RR15Q4
2015-11-13 11:43hgbotCheckin
2015-11-13 11:43hgbotNote Added: 0081817
2015-11-13 11:43hgbotStatusscheduled => resolved
2015-11-13 11:43hgbotResolutionopen => fixed
2015-11-13 11:43hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b40a1c825f77a453c373a1e16552abbd2f12fac1 [^] => http://code.openbravo.com/retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal/rev/e22a89d214b0d96ed412ef205c88787f04feaa02 [^]
2015-11-13 11:43hgbotCheckin
2015-11-13 11:43hgbotNote Added: 0081818
2015-11-13 11:43hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal/rev/e22a89d214b0d96ed412ef205c88787f04feaa02 [^] => http://code.openbravo.com/retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal/rev/2ed55cd7801ea00c73fcbab6fcd4cf19fc85d2e2 [^]
2015-11-13 16:30marvintmReview Assigned Tomtaal => marvintm
2015-11-13 16:30marvintmStatusresolved => closed
2015-11-13 16:30marvintmFixed in Version => RR15Q4
2015-11-16 16:43lorenzofidalgoRelationship addedcauses 0031508

Notes
(0081817)
hgbot   
2015-11-13 11:43   
Repository: retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal
Changeset: e22a89d214b0d96ed412ef205c88787f04feaa02
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Oct 28 09:31:36 2015 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal/rev/e22a89d214b0d96ed412ef205c88787f04feaa02 [^]

Fixed issue 31464: Address popup does an additional request when selecting an address

It is not necessary to search onHide, just clean filter and later onShow will do the search

---
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
---
(0081818)
hgbot   
2015-11-13 11:43   
Repository: retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal
Changeset: 2ed55cd7801ea00c73fcbab6fcd4cf19fc85d2e2
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Nov 02 15:05:41 2015 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal/rev/2ed55cd7801ea00c73fcbab6fcd4cf19fc85d2e2 [^]

Fixed issue 31464: Address popup does an additional request when selecting an address

Change label name
Remove unneeded forceInsert

---
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
M web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js
---