Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031445Openbravo ERPA. Platformpublic2015-11-10 09:032015-12-14 08:46
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q4.1Fixed in Version3.0PR15Q4.1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031445: Import entry process can have a stopped but not deregistered thread: tickets remain in the queue
DescriptionIf a low-level error occurs when processing import entries there is a possibility that the run method ([1]) in the ImportEntryProcessRunnable is exited without deregistering.

[1] https://code.openbravo.com/erp/devel/pi/file/710400f71264/src/org/openbravo/service/importprocess/ImportEntryProcessor.java#l274 [^]
Steps To ReproduceForce a low level exception, for example throw an exception around this line:
https://code.openbravo.com/erp/devel/pi/file/710400f71264/src/org/openbravo/service/importprocess/ImportEntryProcessor.java#l375 [^]
Proposed SolutionAdd a catch (Throwable logIt) before the finally block in this location:
https://code.openbravo.com/erp/devel/pi/file/710400f71264/src/org/openbravo/service/importprocess/ImportEntryProcessor.java#l381 [^]

Also add more logging statements to log errors/exceptions. Backend threads shallow exceptions/they are not logged.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 00314103.0PR16Q1 closed mtaal Import entry process can have a stopped but not deregistered thread: tickets remain in the queue 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-11-12 11:14mtaalTypedefect => backport
2015-11-12 11:14mtaalTarget Version3.0PR16Q1 => 3.0PR15Q4
2015-11-13 09:34mtaalTarget Version3.0PR15Q4 => 3.0PR15Q4.1
2015-12-01 23:20hgbotCheckin
2015-12-01 23:20hgbotNote Added: 0082505
2015-12-01 23:20hgbotStatusscheduled => resolved
2015-12-01 23:20hgbotResolutionopen => fixed
2015-12-01 23:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q4.1/rev/4883ab9e4334ff7add5f15d118431788905bf7b2 [^]
2015-12-01 23:21mtaalReview Assigned To => marvintm
2015-12-14 08:46marvintmStatusresolved => closed
2015-12-14 08:46marvintmFixed in Version => 3.0PR15Q4.1

Notes
(0082505)
hgbot   
2015-12-01 23:20   
Repository: erp/backports/3.0PR15Q4.1
Changeset: 4883ab9e4334ff7add5f15d118431788905bf7b2
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Dec 01 23:19:57 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q4.1/rev/4883ab9e4334ff7add5f15d118431788905bf7b2 [^]

Fixes issue 31445: Import entry process can have a stopped but not deregistered thread: tickets remain in the queue
Adding log statements and catch block to prevent exiting loop

---
M src/org/openbravo/service/importprocess/ImportEntryManager.java
M src/org/openbravo/service/importprocess/ImportEntryProcessor.java
---