Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031440Openbravo ERPZ. Otherspublic2015-11-06 10:382015-11-12 19:25
Reportermaite 
Assigned Toaferraz 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q4Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2014-09-23
Regression introduced in release3.0PR14Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/179d97ee602d [^]
Triggers an Emergency PackNo
Summary0031440: Hover over Sender field in Match Statement pop-up only shows Business Partner Name instead of Business Partner Name and Descript
DescriptionBefore Match Statement refactor, if you hover over Sender field both bank statement line Business Partner Name and Description are shown
Steps To Reproduce1. Access Cuenta de Banco financial account, create new Bank Statement record
2. Add Bank Statement line seeting Business Partner Name as "name of my bp" and Description as "bsl description". Process bank statement
3. Run "Match Statement" process and hover over Sender field in your line. Realize that only "name of my bp" is shown

If you follow similar process in version prior to refactor (for example MP30.3) you can verify that both values are shown:

"name of my bp
 bsl description"
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 00313873.0PR16Q1 closed aferraz Hover over Sender field in Match Statement pop-up only shows Business Partner Name instead of Business Partner Name and Descript 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-11-12 10:14aferrazTypedefect => backport
2015-11-12 10:14aferrazTarget Version3.0PR16Q1 => 3.0PR15Q4.1
2015-11-12 17:38vmromanosTarget Version3.0PR15Q4.1 => 3.0PR15Q4
2015-11-12 19:19hgbotCheckin
2015-11-12 19:19hgbotNote Added: 0081776
2015-11-12 19:19hgbotStatusscheduled => resolved
2015-11-12 19:19hgbotResolutionopen => fixed
2015-11-12 19:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q4/rev/5418fa79304a2a5e9b7a1f63f89b696fd3db0292 [^]
2015-11-12 19:19hgbotCheckin
2015-11-12 19:19hgbotNote Added: 0081778
2015-11-12 19:19hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/backports/3.0PR15Q4/rev/5418fa79304a2a5e9b7a1f63f89b696fd3db0292 [^] => http://code.openbravo.com/erp/backports/3.0PR15Q4/rev/6b4449fa8b26695b21baf5cb326e203fac3ed84a [^]
2015-11-12 19:25vmromanosReview Assigned To => vmromanos
2015-11-12 19:25vmromanosNote Added: 0081791
2015-11-12 19:25vmromanosStatusresolved => closed

Notes
(0081776)
hgbot   
2015-11-12 19:19   
Repository: erp/backports/3.0PR15Q4
Changeset: 5418fa79304a2a5e9b7a1f63f89b696fd3db0292
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Nov 11 20:01:21 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q4/rev/5418fa79304a2a5e9b7a1f63f89b696fd3db0292 [^]

Fixes issue 31440 & Fixes issue 31442: Add two new columns in Match Statement

Added Business Partner Name and Transaction Description as new fields in Match Statement P&E window. They will not be shown in grid by default.
HQL Query in aprm_matchstatement table has been modified to retrieve this two new columns from FIN_BankStatementLine and FIN_Finacc_Transaction tables, and to retrieve bp.name as businessPartner also in case it is null.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TABLE.xml
---
(0081778)
hgbot   
2015-11-12 19:19   
Repository: erp/backports/3.0PR15Q4
Changeset: 6b4449fa8b26695b21baf5cb326e203fac3ed84a
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Nov 12 18:42:04 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q4/rev/6b4449fa8b26695b21baf5cb326e203fac3ed84a [^]

Fixes issue 31440 & Fixes issue 31442: code review improvements

Reverted back the behavior of the Sender field. It shows the Business Partner Name (from the OB object) or the Business Partner Name string as it was doing before.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TABLE.xml
---
(0081791)
vmromanos   
2015-11-12 19:25   
Code review + testing OK