Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031434Openbravo ERPA. Platformpublic2015-11-11 18:292015-11-23 21:17
Reportercaristu 
Assigned Tocaristu 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031434: Error thrown when refreshing the grid after canceling the creation of a record in a child tab
DescriptionThe following error appears in the interface:

"Data was tried to be fetched from server without pagination. Request was aborted to prevent server performance issues. This is most likely a bug, please contact your System Administrator."

when refreshing the grid after canceling the creation of a record in a child tab
Steps To Reproduce1) Go to the [Sales Order] window
2) Create a new record in the header
3) Navigate to the [Lines] tab
4) Create a new record in grid view, cancel the edition (without saving)
5) Click on the refresh button. Notice that the error appears.
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to defect 0029896 closed AugustoMauch double grid request when filtering grid after scrolling to 2nd page 
related to defect 0029259 closed caristu WARN: Datasource request with targetRecordId but without directNavigation detected when reloading Sales Invoice form view 
has duplicate defect 0028321 closed caristu Request without pagination when refreshing the grid 
related to defect 0036459 closed caristu error thrown when refreshing after cancelling row creation before FIC response is processed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-11-11 18:29caristuNew Issue
2015-11-11 18:29caristuAssigned To => platform
2015-11-11 18:29caristuModules => Core
2015-11-11 18:29caristuTriggers an Emergency Pack => No
2015-11-11 18:29caristuIssue Monitored: networkb
2015-11-11 18:31caristuRelationship addedrelated to 0029896
2015-11-11 19:06caristuAssigned Toplatform => caristu
2015-11-11 19:07caristuReview Assigned To => alostale
2015-11-11 19:07caristuIssue Monitored: alostale
2015-11-11 19:14hgbotCheckin
2015-11-11 19:14hgbotNote Added: 0081726
2015-11-11 19:14hgbotStatusnew => resolved
2015-11-11 19:14hgbotResolutionopen => fixed
2015-11-11 19:14hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bc003391103bb456428563231196609f946172cc [^]
2015-11-11 19:21hgbotCheckin
2015-11-11 19:21hgbotNote Added: 0081727
2015-11-12 18:58caristuRelationship addedhas duplicate 0028321
2015-11-16 12:41alostaleTag Attached: Performance
2015-11-16 12:45alostaleRelationship addedrelated to 0029259
2015-11-16 12:47alostaleNote Added: 0081871
2015-11-16 12:47alostaleStatusresolved => new
2015-11-16 12:47alostaleResolutionfixed => open
2015-11-16 13:16hgbotCheckin
2015-11-16 13:16hgbotNote Added: 0081873
2015-11-16 13:20caristuStatusnew => scheduled
2015-11-16 13:21caristuStatusscheduled => resolved
2015-11-16 13:21caristuResolutionopen => fixed
2015-11-16 13:31alostaleNote Added: 0081876
2015-11-16 13:31alostaleStatusresolved => closed
2015-11-16 13:31alostaleFixed in Version => 3.0PR16Q1
2015-11-23 21:17hudsonbotCheckin
2015-11-23 21:17hudsonbotNote Added: 0082199
2015-11-23 21:17hudsonbotCheckin
2015-11-23 21:17hudsonbotNote Added: 0082200
2015-11-23 21:17hudsonbotCheckin
2015-11-23 21:17hudsonbotNote Added: 0082231
2017-07-11 14:58alostaleRelationship addedrelated to 0036459

Notes
(0081726)
hgbot   
2015-11-11 19:14   
Repository: erp/devel/pi
Changeset: bc003391103bb456428563231196609f946172cc
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Nov 11 19:12:51 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/bc003391103bb456428563231196609f946172cc [^]

fixes issue 31434: Error after cancel record creation in grid view and refresh

The problem was that when refreshing after cancelling the record creation in grid view, the refresh request was done considering that an existing record was selected. To avoid this problem, now after canceling, the getSelectedRecord() is cleared if the canceled record is a new one.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0081727)
hgbot   
2015-11-11 19:21   
Repository: erp/devel/pi
Changeset: 760f25c01ef4cfdab3be2a58e7c43e6875e48063
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Nov 11 19:20:24 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/760f25c01ef4cfdab3be2a58e7c43e6875e48063 [^]

related to issue 31434: improvement to not execute the same method two times

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0081871)
alostale   
2015-11-16 12:47   
Code review -> reopening selectedRecord variable is declared within if statement, according to JavaScript Coding Conventions, it should be declared on top of the function [1].

[1] http://wiki.openbravo.com/wiki/JavaScript_Coding_Conventions#Variable_Declaration [^]
(0081873)
hgbot   
2015-11-16 13:16   
Repository: erp/devel/pi
Changeset: 6adee27906f6141ac9b3ac1a8717e3fd04023d22
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Nov 16 13:15:27 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6adee27906f6141ac9b3ac1a8717e3fd04023d22 [^]

related to issue 31434: code review improvements

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0081876)
alostale   
2015-11-16 13:31   
code reviewed + tested
(0082199)
hudsonbot   
2015-11-23 21:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test
(0082200)
hudsonbot   
2015-11-23 21:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test
(0082231)
hudsonbot   
2015-11-23 21:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test