Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031432Openbravo ERPA. Platformpublic2015-11-11 17:492015-11-26 09:22
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031432: Update version of commons-io library from 2.0.1 to 2.4
DescriptionWe are currently working on a database synchronization module that will require the version 2.4 of the commons-io library.

That module does not work with the current version 2.0.1. But Openbravo does work with the 2.4 version.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0031671 closed AugustoMauch The dbsourcemanager classpath references the old version commons-io 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-11-11 17:49AugustoMauchNew Issue
2015-11-11 17:49AugustoMauchAssigned To => platform
2015-11-11 17:49AugustoMauchOBNetwork customer => No
2015-11-11 17:49AugustoMauchModules => Core
2015-11-11 17:49AugustoMauchTriggers an Emergency Pack => No
2015-11-11 18:00AugustoMauchNote Added: 0081723
2015-11-11 18:01AugustoMauchNote Edited: 0081723bug_revision_view_page.php?bugnote_id=0081723#r10167
2015-11-11 18:02AugustoMauchNote Edited: 0081723bug_revision_view_page.php?bugnote_id=0081723#r10168
2015-11-16 13:27AugustoMauchReview Assigned To => alostale
2015-11-16 13:31AugustoMauchNote Added: 0081875
2015-11-16 13:32hgbotCheckin
2015-11-16 13:32hgbotNote Added: 0081877
2015-11-16 13:32hgbotStatusnew => resolved
2015-11-16 13:32hgbotResolutionopen => fixed
2015-11-16 13:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/dcc7fba68b208c0715cd969954d587cd8b88c5e2 [^]
2015-11-16 14:32alostaleAssigned Toplatform => AugustoMauch
2015-11-16 14:33AugustoMauchNote Added: 0081885
2015-11-16 18:12hgbotCheckin
2015-11-16 18:12hgbotNote Added: 0081899
2015-11-23 21:17hudsonbotCheckin
2015-11-23 21:17hudsonbotNote Added: 0082233
2015-11-23 21:17hudsonbotCheckin
2015-11-23 21:17hudsonbotNote Added: 0082241
2015-11-26 09:22alostaleNote Added: 0082357
2015-11-26 09:22alostaleStatusresolved => closed
2015-11-26 09:22alostaleFixed in Version => 3.0PR16Q1
2015-12-09 12:38AugustoMauchRelationship addedrelated to 0031671

Notes
(0081723)
AugustoMauch   
2015-11-11 18:00   
(edited on: 2015-11-11 18:02)
Checks done to know if the change is safe:
- Binary APIs compared using the Openbravo API check tools -> OK
- Release notes checked to see if there are any other API changes / incompatibilities:
   * From 2.0.1 to 2.1 [1] -> OK
   * From 2.1 to 2.2 [2] -> OK
   * From 2.2 to 2.3 [3] -> NOT OK
   * From 2.3 to 2.4 [4] -> OK

The problem introduced in 2.3 [5] is that the method toByteArray(Reader input, Charset encoding) was created. This method can conflict with the existing method toByteArray(Reader input, String encoding) if NULL is passed to the second parameter. The sources for all the modules published in the central repository have been checked, and no one invoked IOUtils.toByteArray with two parameters, so the change is safe.

Also the library license remains the same.

[1] https://commons.apache.org/proper/commons-io/upgradeto2_1.html [^]
[2] https://commons.apache.org/proper/commons-io/upgradeto2_2.html [^]
[3] https://commons.apache.org/proper/commons-io/upgradeto2_3.html [^]
[4] https://commons.apache.org/proper/commons-io/upgradeto2_4.html [^]
[5] https://issues.apache.org/jira/browse/IO-318 [^]
(0081875)
AugustoMauch   
2015-11-16 13:31   
Other checks:
- It passes try
- It passes try-retail
- The licence remains the same
- The new version requires Java 6, Openbravo already required it
(0081877)
hgbot   
2015-11-16 13:32   
Repository: erp/devel/pi
Changeset: dcc7fba68b208c0715cd969954d587cd8b88c5e2
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Nov 11 17:48:28 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/dcc7fba68b208c0715cd969954d587cd8b88c5e2 [^]

Fixes issue 31432: Upgrade version of commons-io from 2.0.1 to 2.4

In the near future a module related with database synchronization is going to be published. This module requires the 2.4 version of the commons-io library, that's why the commons-io library has been updated to this version.

---
A lib/runtime/commons-io-2.4.jar
R lib/runtime/commons-io-2.0.1.jar
---
(0081885)
AugustoMauch   
2015-11-16 14:33   
Licensing.txt file has been updated [1] and the wiki has been updated [2]

[1] https://code.openbravo.com/erp/devel/pi/rev/9bc23e1bab78 [^]
[2] http://wiki.openbravo.com/wiki/Openbravo_Libraries [^]
(0081899)
hgbot   
2015-11-16 18:12   
Repository: erp/devel/pi
Changeset: ecf5c6932ff2186e7fb01cdcb54dd10fe8bc73de
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Nov 16 18:09:03 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ecf5c6932ff2186e7fb01cdcb54dd10fe8bc73de [^]

Related with issue 31432: Updates classpath

---
M src-core/.classpath
---
(0082233)
hudsonbot   
2015-11-23 21:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test
(0082241)
hudsonbot   
2015-11-23 21:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test
(0082357)
alostale   
2015-11-26 09:22   
code reviewed, checked actual impact for existing modules should be low