0031425: many boolean columns incorrectly defined in AD and DB

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0031425

Openbravo ERP

A. Platform

public

2015-11-11 11:02

2022-02-01 08:09

Reporter

alostale

Assigned To

Triage Platform Base

Priority

normal

Severity

trivial

Reproducibility

have not tried

Status

acknowledged

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0031425: many boolean columns incorrectly defined in AD and DB

Description

Boolean columns (reference Y/N) should be defined as:
1. Mandatory: other case when working with DAL a Boolean null object is obtained failing when doing "if (object)"
2. They should have standard DB check for Y/N values

Steps To Reproduce

For case 1, check with:
select t.tablename, c.columnname
from ad_column c, ad_table t
where c.ad_reference_id = '20'
and t.ad_table_id = c.ad_table_id
and t.isview ='N'
and c.ismandatory ='N'
order by 1,2

For case 2, check with:
select t.tablename, c.columnname
from ad_column c, ad_table t
where c.ad_reference_id = '20'
and t.ad_table_id = c.ad_table_id
and t.isview ='N'
and not exists (
        select 1
        from pg_constraint ct, pg_class pt
        where pt.relname ilike t.tablename
        and ct.conrelid = pt.oid
        and contype ='c'
        and consrc ilike '%'||c.columnname||'%'
        and consrc ilike '%''Y''%'
        and consrc ilike '%''N''%')
order by 1,2

Proposed Solution

Decide whether we should enforce these two rules, if so, fix existent columns (note will be an API change) and automate test case to prevent it in future.

Additional Information