Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031410Openbravo ERPA. Platformpublic2015-11-10 09:032015-12-31 11:26
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q1Fixed in Version3.0PR16Q1 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031410: Import entry process can have a stopped but not deregistered thread: tickets remain in the queue
DescriptionIf a low-level error occurs when processing import entries there is a possibility that the run method ([1]) in the ImportEntryProcessRunnable is exited without deregistering.

[1] https://code.openbravo.com/erp/devel/pi/file/710400f71264/src/org/openbravo/service/importprocess/ImportEntryProcessor.java#l274 [^]
Steps To ReproduceForce a low level exception, for example throw an exception around this line:
https://code.openbravo.com/erp/devel/pi/file/710400f71264/src/org/openbravo/service/importprocess/ImportEntryProcessor.java#l375 [^]
Proposed SolutionAdd a catch (Throwable logIt) before the finally block in this location:
https://code.openbravo.com/erp/devel/pi/file/710400f71264/src/org/openbravo/service/importprocess/ImportEntryProcessor.java#l381 [^]

Also add more logging statements to log errors/exceptions. Backend threads shallow exceptions/they are not logged.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0031368 closed mtaal Add log in importprocess to get more information if it fails 
depends on backport 00314453.0PR15Q4.1 closed mtaal Import entry process can have a stopped but not deregistered thread: tickets remain in the queue 
depends on backport 00314463.0PR15Q3.4 closed mtaal Import entry process can have a stopped but not deregistered thread: tickets remain in the queue 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-11-10 09:03mtaalNew Issue
2015-11-10 09:03mtaalAssigned To => mtaal
2015-11-10 09:03mtaalOBNetwork customer => No
2015-11-10 09:03mtaalModules => Core
2015-11-10 09:03mtaalTriggers an Emergency Pack => No
2015-11-10 09:03mtaalRelationship addedrelated to 0031368
2015-11-11 12:23hgbotCheckin
2015-11-11 12:23hgbotNote Added: 0081697
2015-11-12 11:14mtaalStatusnew => scheduled
2015-11-13 11:07hgbotCheckin
2015-11-13 11:07hgbotNote Added: 0081810
2015-11-23 21:17hudsonbotCheckin
2015-11-23 21:17hudsonbotNote Added: 0082197
2015-11-23 21:17hudsonbotCheckin
2015-11-23 21:17hudsonbotNote Added: 0082226
2015-12-01 22:10mtaalReview Assigned To => marvintm
2015-12-01 23:21mtaalNote Added: 0082506
2015-12-01 23:21mtaalStatusscheduled => resolved
2015-12-01 23:21mtaalFixed in Version => 3.0PR16Q1
2015-12-01 23:21mtaalFixed in SCM revision => .
2015-12-01 23:21mtaalResolutionopen => fixed
2015-12-31 11:26OrekariaReview Assigned Tomarvintm => Orekaria
2015-12-31 11:26OrekariaStatusresolved => closed

Notes
(0081697)
hgbot   
2015-11-11 12:23   
Repository: erp/devel/pi
Changeset: f37f05074060785c4c63633b6b637c4c42071fda
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Nov 10 09:05:49 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f37f05074060785c4c63633b6b637c4c42071fda [^]

Related to issue 31410: Import entry process can have a stopped but not deregistered thread: tickets remain in the queue
Added logging statements, add wait in ImportEntryManager loop, also make sure that the wait time computation does not round, add a catch block in ImportEntryProcessorRunnable, moved the inner loop to a separate method for readability

---
M src/org/openbravo/service/importprocess/ImportEntryManager.java
M src/org/openbravo/service/importprocess/ImportEntryProcessor.java
---
(0081810)
hgbot   
2015-11-13 11:07   
Repository: erp/devel/pi
Changeset: 24ecac05d0fd8b6e156f69ced36f9229f58459e0
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Nov 13 11:07:02 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/24ecac05d0fd8b6e156f69ced36f9229f58459e0 [^]

Related to issue 31410: Import entry process can have a stopped but not deregistered thread: tickets remain in the queue
Handle the case that the import entry has no role set, use the default in that case

---
M src/org/openbravo/service/importprocess/ImportEntryProcessor.java
---
(0082197)
hudsonbot   
2015-11-23 21:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test
(0082226)
hudsonbot   
2015-11-23 21:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test
(0082506)
mtaal   
2015-12-01 23:21   
Fixed by commits for the issue, child issues are resolved