Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0031406Openbravo ERP01. General setuppublic2015-11-09 13:382015-12-15 23:49
ngarcia 
AtulOpenbravo 
urgentmajoralways
closedfixed 
5
 
 
vmromanos
Core
No
0031406: Post button is not hidden in some windows although Show Accounting Tabs is set to No
Post button is not hidden in some windows although Show Accounting Tabs is set to No
As group admin role:
   Go to Session Preferences window and remove the selection of the Show Accounting tabs checkbox
   Go to Preference window and check the ShowAcct preference
   Log out and log in
   Go to the following windows, select a completed record and check the post button is shown:
      Payment In
      Payment Out
      Financial Account - Transaction
      ...
No tags attached.
png issue_31406.png (72,836) 2015-12-09 12:36
https://issues.openbravo.com/file_download.php?file_id=8788&type=bug
png
Issue History
2015-11-09 13:38ngarciaNew Issue
2015-11-09 13:38ngarciaAssigned To => Triage Finance
2015-11-09 13:38ngarciaModules => Core
2015-11-09 13:38ngarciaResolution time => 1450566000
2015-11-09 13:38ngarciaTriggers an Emergency Pack => No
2015-11-09 13:38ngarciaIssue Monitored: networkb
2015-12-07 20:41AtulOpenbravoAssigned ToTriage Finance => AtulOpenbravo
2015-12-07 20:43AtulOpenbravoStatusnew => scheduled
2015-12-07 20:43AtulOpenbravoNote Added: 0082601
2015-12-09 12:35psanjuanNote Added: 0082615
2015-12-09 12:36psanjuanNote Edited: 0082615bug_revision_view_page.php?bugnote_id=0082615#r10412
2015-12-09 12:36psanjuanFile Added: issue_31406.png
2015-12-09 14:16psanjuanNote Added: 0082621
2015-12-09 14:17psanjuanNote Edited: 0082601bug_revision_view_page.php?bugnote_id=0082601#r10424
2015-12-10 12:43psanjuanNote Added: 0082636
2015-12-15 18:05hgbotCheckin
2015-12-15 18:05hgbotNote Added: 0082778
2015-12-15 18:05hgbotStatusscheduled => resolved
2015-12-15 18:05hgbotResolutionopen => fixed
2015-12-15 18:05hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8942b6596f0bdfbacfcc0f8b348e7485aa12f022 [^]
2015-12-15 18:06vmromanosReview Assigned To => vmromanos
2015-12-15 18:06vmromanosNote Added: 0082779
2015-12-15 18:06vmromanosStatusresolved => closed
2015-12-15 23:49hudsonbotCheckin
2015-12-15 23:49hudsonbotNote Added: 0082792

Notes
(0082601)
AtulOpenbravo   
2015-12-07 20:43   
(edited on: 2015-12-09 14:17)
Test Plan
- Login as Group Admin role.
- Go to Session Preferences window and remove the selection of the Show Accounting tabs checkbox
- Log out and log in
- Go to the following windows, select a completed record and check the post button is not shown in following windows.
     - Payment In
     - Payment Out
     - Financial Account - Transaction
As well as for windows such as : Sales Invoice or Purchase Invoice.

*** Recheck Post button is again visible in all above windows by setting Show Accounting tabs = Yes in session preferences by Log out and Login again.

(0082615)
psanjuan   
2015-12-09 12:35   
(edited on: 2015-12-09 12:36)
Issue Verified.
If the checkbox "Show Accounting Tabs" is not checked post button is not shown in forms such as sales/purchase invoice, while it is shown in forms such as Payment In, Payment Out and Financial Account.

To take advantage of the resolution of this issue, the checkbox needs to be renamed as "Enable Accounting"; because current string is confusing as it is not just the matter of showing/not showing "Accounting" tabs but "Post" button which enable or not posting documents to the ledger. See image attached.

(0082621)
psanjuan   
2015-12-09 14:16   
Test Plan above verified.

Issue can be closed once it is code review after changing checkbox label to "Enable Accounting".
(0082636)
psanjuan   
2015-12-10 12:43   
Verified. Label changed, Issue can be code reviewed and closed.
(0082778)
hgbot   
2015-12-15 18:05   
Repository: erp/devel/pi
Changeset: 8942b6596f0bdfbacfcc0f8b348e7485aa12f022
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Thu Dec 10 15:10:00 2015 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/8942b6596f0bdfbacfcc0f8b348e7485aa12f022 [^]

Fixes Issue 31406:Post button is not hidden in some windows although Show
Accounting Tabs is set to No

Added missing part to display logic of Posted Button field based on Show
Accounting Flag in session preferences for Payment In - Header Tab,
Payment Out - Header Tab and financial Account Transaction Tab.
Show Accouting flag is renamed as Enable Accounting

---
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M src/org/openbravo/erpCommon/ad_forms/ShowSessionPreferences.html
---
(0082779)
vmromanos   
2015-12-15 18:06   
Code review + testing OK
(0082792)
hudsonbot   
2015-12-15 23:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ecd185534f50 [^]
Maturity status: Test