Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031400Retail ModulesWeb POSpublic2015-11-08 20:062015-11-13 11:42
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q1Fixed in VersionRR16Q1 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031400: Javascript error when adding a new customer and address in remote product
DescriptionRun test I31196_ReassignNewCustomer in postgresql with remote data prefs to Y.

https://ci.openbravo.com/view/retail/job/ret-test-pgsql/2878/testReport/org.openbravo.test.mobile.retail.pack.selenium.tests.receipts/I31196_ReassignNewCustomer/test/ [^]


TypeError: empty is not a function
    at 256a151481c95212dc7def7698fc92a9_WebPOS.js:4185
    at serviceSuccess (256a151481c95212dc7def7698fc92a9_WebPOS.js:1028)
    at Object.enyo.Ajax.success [as origSuccess] (256a151481c95212dc7def7698fc92a9_WebPOS.js:1109)
    at Object.ajaxRequest.success (256a151481c95212dc7def7698fc92a9_WebPOS.js:1517)
    at Object.enyo.call (lang.js:354)
    at Object.enyo.kind.handle (Async.js:76)
    at Object.enyo.kind.respond (Async.js:107)
    at Object.enyo.kind.receive (Ajax.js:89)
    at XMLHttpRequest.inXhr.onreadystatechange (xhr.js:71); line: Object.OB.UTIL.showError (http://127.0.0.1:8080/openbravo/web/js/gen/256a151481c95212dc7def7698fc92a9_WebPOS.js:9813:6 [^]) (*,+)processConsoleLevel @ 256a151481c95212dc7def7698fc92a9_WebPOS.js:2467OB.error @ 256a151481c95212dc7def7698fc92a9_WebPOS.js:2497OB.UTIL.showError @ 256a151481c95212dc7def7698fc92a9_WebPOS.js:9813window.onerror @ 256a151481c95212dc7def7698fc92a9_WebPOS.js:19308
256a151481c95212dc7def7698fc92a9_WebPOS.js:4185 Uncaught TypeError: empty is not a function
Steps To ReproduceSee description
Proposed SolutionThe error appears because of a change done in the related issue. The cause of the error was in the remote code, adding the parameter true on the wrong place.

Additional Information
TagsNo tags attached.
Relationships
related to defect 0031372 closed marvintm When executing OB.Dal.get in Remote mode, if it returns no record, it fails with a hard crash 
depends on backport 0031465RR15Q4 closed mtaal Javascript error when adding a new customer and address in remote product 
related to defect 0031249RR16Q1 closed migueldejuana Address popup does an additional request when selecting an address 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-11-08 20:06mtaalNew Issue
2015-11-08 20:06mtaalAssigned To => mtaal
2015-11-08 20:06mtaalOBNetwork customer => No
2015-11-08 20:06mtaalTriggers an Emergency Pack => No
2015-11-08 20:06mtaalRelationship addedrelated to 0031372
2015-11-08 20:25hgbotCheckin
2015-11-08 20:25hgbotNote Added: 0081588
2015-11-08 20:26hgbotCheckin
2015-11-08 20:26hgbotNote Added: 0081589
2015-11-08 20:28mtaalReview Assigned To => migueldejuana
2015-11-08 20:34hgbotCheckin
2015-11-08 20:34hgbotNote Added: 0081591
2015-11-08 20:35hgbotCheckin
2015-11-08 20:35hgbotNote Added: 0081592
2015-11-08 20:35hgbotStatusnew => resolved
2015-11-08 20:35hgbotResolutionopen => fixed
2015-11-08 20:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/38ce43cc342f151f9dc4d2a62da6e92068092584 [^]
2015-11-09 16:32migueldejuanaNote Added: 0081627
2015-11-09 16:32migueldejuanaStatusresolved => closed
2015-11-12 11:30migueldejuanaRelationship addedrelated to 0031249
2015-11-13 11:42OrekariaStatusclosed => new
2015-11-13 11:42OrekariaResolutionfixed => open
2015-11-13 11:42OrekariaStatusnew => scheduled
2015-11-13 11:42OrekariaStatusscheduled => resolved
2015-11-13 11:42OrekariaResolutionopen => fixed
2015-11-13 11:42OrekariaStatusresolved => closed
2015-11-13 11:42OrekariaFixed in Version => RR16Q1

Notes
(0081588)
hgbot   
2015-11-08 20:25   
Repository: tools/automation/pi-mobile
Changeset: 7f59d105a17c64fbfba389407adbdb03b61d4749
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Nov 08 20:25:15 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/7f59d105a17c64fbfba389407adbdb03b61d4749 [^]

Related to issue 31400: Javascript error when adding a new customer and address in remote product
A small wait seems to make the test more stable

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I31196_ReassignNewCustomer.java
---
(0081589)
hgbot   
2015-11-08 20:26   
Repository: tools/automation/pi-mobile
Changeset: b29168d5ee2b687a3a6db5691d4e9db150f2ec60
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Nov 08 20:26:35 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b29168d5ee2b687a3a6db5691d4e9db150f2ec60 [^]

Related to issue 31400: Javascript error when adding a new customer and address in remote product
Corrected author

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I31196_ReassignNewCustomer.java
---
(0081591)
hgbot   
2015-11-08 20:34   
Repository: tools/automation/pi-mobile
Changeset: 43608eebcdd7fa035f68683e6aed762996fa0125
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Nov 08 20:34:08 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/43608eebcdd7fa035f68683e6aed762996fa0125 [^]

Related to issue 31400: Javascript error when adding a new customer and address in remote product
Instead of waiting fixed millis, wait until the data is synced

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I31196_ReassignNewCustomer.java
---
(0081592)
hgbot   
2015-11-08 20:35   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 38ce43cc342f151f9dc4d2a62da6e92068092584
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Nov 08 20:35:07 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/38ce43cc342f151f9dc4d2a62da6e92068092584 [^]

Fixes issue 31400: Javascript error when adding a new customer and address in remote product
Remove unintended parameter

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0081627)
migueldejuana   
2015-11-09 16:32   
Tested and reviewed in 33b1c383618d