Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031387Openbravo ERPZ. Otherspublic2015-11-06 10:382015-11-23 21:17
Reportermaite 
Assigned Toaferraz 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q1Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2014-09-23
Regression introduced in release3.0PR14Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/179d97ee602d [^]
Triggers an Emergency PackNo
Summary0031387: Hover over Sender field in Match Statement pop-up only shows Business Partner Name instead of Business Partner Name and Descript
DescriptionBefore Match Statement refactor, if you hover over Sender field both bank statement line Business Partner Name and Description are shown
Steps To Reproduce1. Access Cuenta de Banco financial account, create new Bank Statement record
2. Add Bank Statement line seeting Business Partner Name as "name of my bp" and Description as "bsl description". Process bank statement
3. Run "Match Statement" process and hover over Sender field in your line. Realize that only "name of my bp" is shown

If you follow similar process in version prior to refactor (for example MP30.3) you can verify that both values are shown:

"name of my bp
 bsl description"
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00314403.0PR15Q4 closed aferraz Hover over Sender field in Match Statement pop-up only shows Business Partner Name instead of Business Partner Name and Descript 
depends on backport 00314413.0PR15Q3.4 closed aferraz Hover over Sender field in Match Statement pop-up only shows Business Partner Name instead of Business Partner Name and Descript 
caused by feature request 00293903.0PR14Q4 closed Sandrahuguet Reconciliation refactor project 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-11-06 10:38maiteNew Issue
2015-11-06 10:38maiteAssigned To => Triage Finance
2015-11-06 10:38maiteModules => Advanced Payables and Receivables Mngmt
2015-11-06 10:38maiteResolution time => 1449702000
2015-11-06 10:38maiteTriggers an Emergency Pack => No
2015-11-06 10:38maiteIssue Monitored: networkb
2015-11-10 13:48aferrazAssigned ToTriage Finance => aferraz
2015-11-10 13:55aferrazRelationship addedcaused by 0029390
2015-11-10 13:58aferrazRegression level => Production - Confirmed Stable
2015-11-10 13:58aferrazRegression date => 2014-09-23
2015-11-10 13:58aferrazRegression introduced in release => 3.0PR14Q4
2015-11-10 13:58aferrazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/179d97ee602d [^]
2015-11-11 17:54aferrazNote Added: 0081722
2015-11-11 17:56aferrazNote Edited: 0081722bug_revision_view_page.php?bugnote_id=0081722#r10165
2015-11-11 18:19aferrazNote Edited: 0081722bug_revision_view_page.php?bugnote_id=0081722#r10169
2015-11-12 10:14aferrazStatusnew => scheduled
2015-11-12 19:20hgbotCheckin
2015-11-12 19:20hgbotNote Added: 0081781
2015-11-12 19:20hgbotStatusscheduled => resolved
2015-11-12 19:20hgbotResolutionopen => fixed
2015-11-12 19:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/fe7e7c17712bcf75d97d44bc313b0d3e6e5d6377 [^]
2015-11-12 19:20hgbotCheckin
2015-11-12 19:20hgbotNote Added: 0081783
2015-11-12 19:20hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/fe7e7c17712bcf75d97d44bc313b0d3e6e5d6377 [^] => http://code.openbravo.com/erp/devel/pi/rev/fcda68dddca6df0c946d754ec956f7635ce0fe9c [^]
2015-11-12 19:27vmromanosReview Assigned To => vmromanos
2015-11-12 19:27vmromanosNote Added: 0081793
2015-11-12 19:27vmromanosStatusresolved => closed
2015-11-20 15:12aferrazNote Added: 0082030
2015-11-23 21:17hudsonbotCheckin
2015-11-23 21:17hudsonbotNote Added: 0082217
2015-11-23 21:17hudsonbotCheckin
2015-11-23 21:17hudsonbotNote Added: 0082219

Notes
(0081722)
aferraz   
2015-11-11 17:54   
(edited on: 2015-11-11 18:19)
Test plan:

As F&B Admin:

- Access Cuenta de Banco financial account, create new Bank Statement record
  Add Bank Statement line seting Business Partner empty, Business Partner Name as "name of my bp" and Description as "bsl description".
  Add Bank Statement line seting Business Partner as "Alimentos y Supermercados", Business Partner Name as "name of my bp" and Description empty.
  Add Bank Statement line seting Business Partner empty, Business Partner Name empty and Description as "bsl description".
  Add Bank Statement line seting Business Partner as "Alimentos y Supermercados", Business Partner Name empty and Description empty.
  Process bank statement

- Run "Match Statement" process and show Business Partner Name and Description columns. Realize the following lines are shown:
- First line: sender = "", business partner name = "name of my bp", description = "bsl description"
- Second line: sender = "Alimentos y Supermercados", business partner name = "name of my bp", description = ""
- Third line: sender = "", business partner name = "", description = "bsl description"
- Fourth line: sender = "Alimentos y Supermercados", business partner name = "", description = ""
(0081781)
hgbot   
2015-11-12 19:20   
Repository: erp/devel/pi
Changeset: fe7e7c17712bcf75d97d44bc313b0d3e6e5d6377
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Nov 11 20:01:21 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/fe7e7c17712bcf75d97d44bc313b0d3e6e5d6377 [^]

Fixes issue 31387 & Fixes issue 31389: Add two new columns in Match Statement

Added Business Partner Name and Transaction Description as new fields in Match Statement P&E window. They will not be shown in grid by default.
HQL Query in aprm_matchstatement table has been modified to retrieve this two new columns from FIN_BankStatementLine and FIN_Finacc_Transaction tables, and to retrieve bp.name as businessPartner also in case it is null.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TABLE.xml
---
(0081783)
hgbot   
2015-11-12 19:20   
Repository: erp/devel/pi
Changeset: fcda68dddca6df0c946d754ec956f7635ce0fe9c
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Nov 12 18:42:04 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/fcda68dddca6df0c946d754ec956f7635ce0fe9c [^]

Fixes issue 31387 & Fixes issue 31389: code review improvements

Reverted back the behavior of the Sender field. It shows the Business Partner Name (from the OB object) or the Business Partner Name string as it was doing before.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TABLE.xml
---
(0081793)
vmromanos   
2015-11-12 19:27   
Code review + testing OK
(0082030)
aferraz   
2015-11-20 15:12   
https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-8627 [^]
(0082217)
hudsonbot   
2015-11-23 21:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test
(0082219)
hudsonbot   
2015-11-23 21:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test