Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031366Openbravo ERPA. Platformpublic2015-11-05 09:472015-11-23 21:17
ReporterOrekaria 
Assigned Toalostale 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q1 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031366: 2 tests failing in try-ret-checks-oracle
DescriptionIn the try-ret-checks-oracle job, these 2 tests are failing because the Oracle database is being accessed by different users and the sql query does not take it into account

org.openbravo.test.db.model.functions.SqlCallableStatement.transactionalCallableStatemetsShouldBeClosed
org.openbravo.test.db.model.functions.SqlCallableStatement.noTransactionalCallableStatemetsShouldBeClosedCallableStatemetsShouldBeClosed
Steps To ReproduceNavigate to https://ci.openbravo.com/view/try-retail/job/try-ret-checks-oracle/ [^]

Verify that some of the builds have these failing tests due to unexpected number of cursors:
- org.openbravo.test.db.model.functions.SqlCallableStatement.transactionalCallableStatemetsShouldBeClosed
- org.openbravo.test.db.model.functions.SqlCallableStatement.noTransactionalCallableStatemetsShouldBeClosedCallableStatemetsShouldBeClosed

Send some builds with the attached cursors.diff until the tests fail

Verify that there are more users than expected:
    # of open cursors for the statement. DB Users TRY_RET_MODULES_ORACLE TRY_RET_FULL_ORACLE
Proposed SolutionChange the query to filter by user. The user can probably be picked up from the JOB_NAME environmental variable
    System.getenv("JOB_NAME")
Additional Information
TagsNo tags attached.
Relationships
related to defect 00308913.0PR16Q1 closed alostale Xsql files parser does not release statement for callable statements 
Attached Filesdiff cursors.diff (1,406) 2015-11-05 09:47
https://issues.openbravo.com/file_download.php?file_id=8688&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-11-05 09:47OrekariaNew Issue
2015-11-05 09:47OrekariaAssigned To => platform
2015-11-05 09:47OrekariaFile Added: cursors.diff
2015-11-05 09:47OrekariaModules => Core
2015-11-05 09:47OrekariaTriggers an Emergency Pack => No
2015-11-05 09:54OrekariaPrioritynormal => urgent
2015-11-05 10:07alostalePriorityurgent => immediate
2015-11-05 10:08alostaleRelationship addedrelated to 0030891
2015-11-05 10:08alostaleStatusnew => scheduled
2015-11-05 10:08alostaleAssigned Toplatform => alostale
2015-11-05 10:08alostaleReview Assigned To => Orekaria
2015-11-05 10:34hgbotCheckin
2015-11-05 10:34hgbotNote Added: 0081496
2015-11-05 10:34hgbotStatusscheduled => resolved
2015-11-05 10:34hgbotResolutionopen => fixed
2015-11-05 10:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/cd794e1d482e959a541531081149c925a55e1575 [^]
2015-11-05 22:29OrekariaStatusresolved => closed
2015-11-05 22:29OrekariaFixed in Version => 3.0PR16Q1
2015-11-23 21:17hudsonbotCheckin
2015-11-23 21:17hudsonbotNote Added: 0082175

Notes
(0081496)
hgbot   
2015-11-05 10:34   
Repository: erp/devel/pi
Changeset: cd794e1d482e959a541531081149c925a55e1575
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Nov 05 10:32:23 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/cd794e1d482e959a541531081149c925a55e1575 [^]

fixed bug 31366: SqlCallableStatement test cases fail in try-ret-checks-oracle

  Retail oracle try infrastructure is executed in parallel for different DB users.
  When querying as DBA for open cursors, cursors only for current user should be
  checked, other way different executions can cause clashes.

---
M src-test/src/org/openbravo/test/db/model/functions/SqlCallableStatement.java
---
(0082175)
hudsonbot   
2015-11-23 21:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test