0031350: Many warnings in log generated by import entry code when a cashup can not be processed

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0031350

Retail Modules

Web POS

public

2015-11-03 16:38

2015-11-05 14:05

Reporter

mtaal

Assigned To

Retail

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR15Q4

Fixed in Version

RR15Q4

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0031350: Many warnings in log generated by import entry code when a cashup can not be processed

Description

See this log:

f760168d 2015-11-03 11:20:06,095 [Import Entry - 3] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,134 [Import Entry - 1] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,173 [Import Entry - 2] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,212 [Import Entry - 3] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,250 [Import Entry - 1] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,290 [Import Entry - 2] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,329 [Import Entry - 3] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,369 [Import Entry - 1] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.

Steps To Reproduce

Create an entry manually in import entry window in error state
Do a cashup in webpos
it won't be processed instead the above message is shown in the code

Proposed Solution

Add this line:

// close and commit
OBDal.getInstance().commitAndClose();

In case the processor code returns without committing in the following classes in the processEntry method:

CashUpImportEntryProcessor
CustomerAddrImportEntryProcessor

See OrderImportEntryProcessor.processEntry as an example

Additional Information