Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031340Retail ModulesWeb POSpublic2015-11-03 16:382015-12-02 10:05
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q1Fixed in VersionRR16Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031340: Many warnings in log generated by import entry code when a cashup can not be processed
DescriptionSee this log:

f760168d 2015-11-03 11:20:06,095 [Import Entry - 3] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,134 [Import Entry - 1] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,173 [Import Entry - 2] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,212 [Import Entry - 3] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,250 [Import Entry - 1] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,290 [Import Entry - 2] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,329 [Import Entry - 3] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
f760168d 2015-11-03 11:20:06,369 [Import Entry - 1] WARN org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable - Session handler present after processing import entry, this indicates that the processing code does not correctly clean/close the session after its last actions. This should be fixed.
Steps To ReproduceCreate an entry manually in import entry window in error state
Do a cashup in webpos
it won't be processed instead the above message is shown in the code
Proposed SolutionAdd this line:

        // close and commit
        OBDal.getInstance().commitAndClose();

In case the processor code returns without committing in the following classes in the processEntry method:

CashUpImportEntryProcessor
CustomerAddrImportEntryProcessor

See OrderImportEntryProcessor.processEntry as an example
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0031350RR15Q4 closed Retail Retail Modules Many warnings in log generated by import entry code when a cashup can not be processed 
depends on backport 0031351RR15Q3.2 closed Retail Retail Modules Many warnings in log generated by import entry code when a cashup can not be processed 
related to defect 0031368 closed mtaal Openbravo ERP Add log in importprocess to get more information if it fails 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-11-03 16:38mtaalNew Issue
2015-11-03 16:38mtaalAssigned To => mtaal
2015-11-03 16:38mtaalTriggers an Emergency Pack => No
2015-11-04 09:41mtaalStatusnew => scheduled
2015-11-04 09:41mtaalNote Added: 0081465
2015-11-04 09:42mtaalAssigned Tomtaal => Retail
2015-11-04 09:42mtaalAssigned ToRetail => mtaal
2015-11-04 23:31hgbotCheckin
2015-11-04 23:31hgbotNote Added: 0081488
2015-11-04 23:31hgbotStatusscheduled => resolved
2015-11-04 23:31hgbotResolutionopen => fixed
2015-11-04 23:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ab692da24b99b493e91b6c40a43579076de20f30 [^]
2015-11-05 08:18hgbotCheckin
2015-11-05 08:18hgbotNote Added: 0081490
2015-11-05 08:18hgbotCheckin
2015-11-05 08:18hgbotNote Added: 0081491
2015-11-05 11:30guilleaerNote Added: 0081507
2015-11-05 13:13shuehnerRelationship addedrelated to 0031368
2015-11-05 13:50hgbotCheckin
2015-11-05 13:50hgbotNote Added: 0081520
2015-11-05 13:50hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ab692da24b99b493e91b6c40a43579076de20f30 [^] => http://code.openbravo.com/retail/backports/3.0RR15Q3.2/org.openbravo.retail.posterminal/rev/257164ce07c59e85690926a54f9e9cb6154e27f2 [^]
2015-11-05 13:51guilleaerNote Deleted: 0081520
2015-11-05 14:05marvintmReview Assigned To => marvintm
2015-11-05 14:05marvintmStatusresolved => closed
2015-11-05 14:05marvintmFixed in Version => RR16Q1
2015-11-23 21:17hudsonbotCheckin
2015-11-23 21:17hudsonbotNote Added: 0082173
2015-11-23 21:17hudsonbotCheckin
2015-11-23 21:17hudsonbotNote Added: 0082174
2015-12-01 23:17hgbotCheckin
2015-12-01 23:17hgbotNote Added: 0082504
2015-12-02 10:05hudsonbotCheckin
2015-12-02 10:05hudsonbotNote Added: 0082519

Notes
(0081465)
mtaal   
2015-11-04 09:41   
Backport
(0081488)
hgbot   
2015-11-04 23:31   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ab692da24b99b493e91b6c40a43579076de20f30
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Nov 04 16:15:51 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ab692da24b99b493e91b6c40a43579076de20f30 [^]

Fixes issue 31340: Many warnings in log generated by import entry code when a cashup can not be processed
Commit and close when returning early from processing import entry

---
M src/org/openbravo/retail/posterminal/importprocess/CashUpImportEntryProcessor.java
M src/org/openbravo/retail/posterminal/importprocess/CustomerAddrImportEntryProcessor.java
---
(0081490)
hgbot   
2015-11-05 08:18   
Repository: erp/devel/pi
Changeset: 7cf9102a806625738743f1a08d51ed9789fcf759
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Nov 04 23:32:41 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7cf9102a806625738743f1a08d51ed9789fcf759 [^]

Related to issue 31340: Many warnings in log generated by import entry code when a cashup can not be processed
More log statements for debugging, add a minimum 1 second wait before re-reading entries

---
M .hgignore
M src/org/openbravo/service/importprocess/ImportEntryManager.java
M src/org/openbravo/service/importprocess/ImportEntryProcessor.java
---
(0081491)
hgbot   
2015-11-05 08:18   
Repository: erp/devel/pi
Changeset: e4d5e3db31fd6c6120f92aa4806c7d08a0d3c412
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Nov 05 08:17:46 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e4d5e3db31fd6c6120f92aa4806c7d08a0d3c412 [^]

Related to issue 31340: Many warnings in log generated by import entry code when a cashup can not be processed
Make the wait slightly longer and fit to 1800 records/min

---
M src/org/openbravo/service/importprocess/ImportEntryManager.java
---
(0081507)
guilleaer   
2015-11-05 11:30   
2nd are 3th commits are related to the following issue:

https://issues.openbravo.com/view.php?id=31368 [^]
(0082173)
hudsonbot   
2015-11-23 21:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test
(0082174)
hudsonbot   
2015-11-23 21:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test
(0082504)
hgbot   
2015-12-01 23:17   
Repository: erp/devel/pi
Changeset: 266c95c576177847da9920682647b2fad8242df1
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Dec 01 23:16:54 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/266c95c576177847da9920682647b2fad8242df1 [^]

Related to issue 31340: Many warnings in log generated by import entry code when a cashup can not be processed
Reverting unintended changed file

---
M .hgignore
---
(0082519)
hudsonbot   
2015-12-02 10:05   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f4f21fc4c72d [^]
Maturity status: Test