Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031322Openbravo ERP02. Master data managementpublic2015-11-02 12:152015-11-27 02:55
Reportermaite 
Assigned Toaferraz 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q1Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket38015
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031322: Sales Representative defined for logged user should be maintained in case order's business partner has not sales rep defined
DescriptionSales Representative defined for logged user should be maintained in case order's business partner has not sales rep defined
Steps To Reproduce1. Create new User with any username and password. Expand More information section and define "Alimentos y Supermercados" as business partner. Define "F&B International Group Admin" in User Roles tab
2. Navigate to "Alimentos y Supermercados" business partner and go to Employee tab to define it as "sales representative"
3. Logout and login with new user
4. Access Sales Order window and realize that Sales Representative field is filled with your user as default. Select "Hoteles Buenas noches" business partner and realize that Sales Representative field is empty

NOTE: When registering a sales order from WebPOS, in case Business Partner has not specific Sales Representative defined then value for logged user is maintained
Proposed SolutionIf selected business partner has not specific Sales Representative defined in its Customer tab, then default Sales Representative for logged user should be maintained
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-11-02 12:15maiteNew Issue
2015-11-02 12:15maiteAssigned To => Triage Finance
2015-11-02 12:15maiteOBNetwork customer => Yes
2015-11-02 12:15maiteModules => Core
2015-11-02 12:15maiteSupport ticket => 38015
2015-11-02 12:15maiteResolution time => 1449615600
2015-11-02 12:15maiteTriggers an Emergency Pack => No
2015-11-02 12:15maiteIssue Monitored: networkb
2015-11-25 14:38aferrazAssigned ToTriage Finance => aferraz
2015-11-25 14:38aferrazStatusnew => scheduled
2015-11-25 19:19aferrazNote Added: 0082351
2015-11-26 15:21hgbotCheckin
2015-11-26 15:21hgbotNote Added: 0082374
2015-11-26 15:21hgbotStatusscheduled => resolved
2015-11-26 15:21hgbotResolutionopen => fixed
2015-11-26 15:21hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1168e004ce351bcc56c7b9678599ad109f054896 [^]
2015-11-26 15:21vmromanosReview Assigned To => vmromanos
2015-11-26 15:21vmromanosNote Added: 0082375
2015-11-26 15:21vmromanosStatusresolved => closed
2015-11-27 02:55hudsonbotCheckin
2015-11-27 02:55hudsonbotNote Added: 0082389

Notes
(0082351)
aferraz   
2015-11-25 19:19   
Test plan:

1. Create new User with any username and password. Expand More information section and define "Alimentos y Supermercados" as business partner. Define "F&B International Group Admin" in User Roles tab
2. Navigate to "Alimentos y Supermercados" business partner and go to Employee tab to define it as "is sales representative"
3. Navigate to "Hoteles Buenas Noches, S.A." business partner and go to Customer tab to define its sales representative as "Javier Martín"
4. Logout and login with new user
5. Access Sales Order window.
   Realize that Sales Representative field is filled with your user as default.
   Select "Alimentos y Supermercados, S.A" business partner and realize that Sales Representative field is filled with your user.
   Select "Hoteles Buenas Noches, S.A." business partner and realize that Sales Representative field is filled with "Javier Martín".
   Select "Restaurantes Luna Llena, S.A." business partner and realize that Sales Representative field is filled with your user.
   Repeat the same step in Goods Shipment (needs to display "sales representative" field) and in Sales Invoice and behaviour should be the same.
6. Navigate to "Alimentos y Supermercados" business partner and go to Employee tab and unselect "is sales representative" checkbox.
7. Access Sales Order window.
   Realize that Sales Representative field is empty by default.
   Select "Alimentos y Supermercados, S.A" business partner and realize that Sales Representative field is empty.
   Select "Hoteles Buenas Noches, S.A." business partner and realize that Sales Representative field is filled with "Javier Martín".
   Select "Restaurantes Luna Llena, S.A." business partner and realize that Sales Representative field is empty.
   Repeat the same step in Goods Shipment (needs to display "sales representative" field) and in Sales Invoice and behaviour should be the same.
(0082374)
hgbot   
2015-11-26 15:21   
Repository: erp/devel/pi
Changeset: 1168e004ce351bcc56c7b9678599ad109f054896
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Nov 25 19:04:45 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1168e004ce351bcc56c7b9678599ad109f054896 [^]

Fixes issue 31322: Sales Representative defined for logged user should be used

Sales representative defined for logged user should be used in case sales order, goods receipt or sales invoice business partner does not have a sales representative defined.

---
M src/org/openbravo/erpCommon/ad_callouts/SE_Invoice_BPartner.java
M src/org/openbravo/erpCommon/ad_callouts/SE_Order_BPartner.java
M src/org/openbravo/erpCommon/ad_callouts/SL_InOut_BPartner.java
---
(0082375)
vmromanos   
2015-11-26 15:21   
Code review + testing OK
(0082389)
hudsonbot   
2015-11-27 02:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/39adcac68310 [^]
Maturity status: Test