Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031297Retail ModulesWeb POSpublic2015-10-29 12:532016-02-15 16:35
Reportermalsasua 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031297: barcode scanner is adding one unit of the last product added to the ticket
Descriptionwhen the barcode scanner is used when a product has been added, no the scanned product is added, instead of it, the quantity of the previous product is increased
Steps To Reproduce. in web pos
 . go to browse
 . click in Avalanche Transceiver
(avalanche transceiver is added to the ticket -> qty 1)
 . scan a some barcode
no new line is added with the product related with the barcode, instead of it, qty to product avalance transceiver is increased in one unit
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0031000 closed jorge-garcia barcode scanner should be disabled when done button is clicked 
related to defect 0031001 closed jorge-garcia barcode scanner should not add a payment 
depends on backport 0032232RR15Q4.3 closed jorge-garcia barcode scanner is adding one unit of the last product added to the ticket 
has duplicate defect 0032141 closed jorge-garcia External keyboard responds on the second key stroke 
causes defect 0031704 new Retail If a popup is shown in the payment flow, barcode scanner doesn't work properly 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-10-29 12:53malsasuaNew Issue
2015-10-29 12:53malsasuaAssigned To => Retail
2015-10-29 12:53malsasuaResolution time => 1448578800
2015-10-29 12:53malsasuaTriggers an Emergency Pack => No
2015-10-30 08:37OrekariaAssigned ToRetail => jorge-garcia
2015-10-30 08:37OrekariaStatusnew => acknowledged
2015-10-30 10:38OrekariaRelationship addedrelated to 0031000
2015-10-30 10:38OrekariaRelationship addedrelated to 0031001
2015-11-02 13:01hgbotCheckin
2015-11-02 13:01hgbotNote Added: 0081432
2015-11-02 13:01hgbotStatusacknowledged => resolved
2015-11-02 13:01hgbotResolutionopen => fixed
2015-11-02 13:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/58770718dfae7bfc16a9f5f791ecf0b5a7b5fbb2 [^]
2015-11-02 13:02hgbotCheckin
2015-11-02 13:02hgbotNote Added: 0081434
2015-11-20 18:08OrekariaReview Assigned To => marvintm
2015-11-23 12:57hgbotCheckin
2015-11-23 12:57hgbotNote Added: 0082075
2015-11-23 12:57hgbotCheckin
2015-11-23 12:57hgbotNote Added: 0082076
2015-11-23 13:10marvintmStatusresolved => closed
2015-11-23 13:10marvintmFixed in Version => RR16Q1
2015-12-10 11:52marvintmNote Added: 0082635
2015-12-10 11:52marvintmStatusclosed => new
2015-12-10 11:52marvintmResolutionfixed => open
2015-12-10 11:53marvintmFixed in VersionRR16Q1 =>
2015-12-10 11:53marvintmStatusnew => scheduled
2015-12-11 08:26hgbotCheckin
2015-12-11 08:26hgbotNote Added: 0082668
2015-12-11 08:33jorge-garciaStatusscheduled => resolved
2015-12-11 08:33jorge-garciaResolutionopen => fixed
2015-12-14 09:19marvintmStatusresolved => closed
2015-12-14 09:19marvintmFixed in Version => RR16Q1
2015-12-14 12:07marvintmNote Added: 0082707
2015-12-14 12:07marvintmStatusclosed => new
2015-12-14 12:07marvintmResolutionfixed => open
2015-12-14 12:07marvintmFixed in VersionRR16Q1 =>
2015-12-14 12:07marvintmStatusnew => scheduled
2015-12-14 15:36jorge-garciaRelationship addedcauses 0031704
2015-12-14 15:38jorge-garciaNote Added: 0082725
2015-12-14 15:38jorge-garciaStatusscheduled => resolved
2015-12-14 15:38jorge-garciaResolutionopen => fixed
2015-12-14 15:38jorge-garciaFixed in Version => RR16Q1
2015-12-14 15:39jorge-garciaStatusresolved => closed
2016-02-15 13:40jorge-garciaStatusclosed => new
2016-02-15 13:40jorge-garciaResolutionfixed => open
2016-02-15 13:40jorge-garciaFixed in VersionRR16Q1 =>
2016-02-15 13:40jorge-garciaStatusnew => scheduled
2016-02-15 13:42jorge-garciaRelationship addedhas duplicate 0032141
2016-02-15 16:35jorge-garciaStatusscheduled => resolved
2016-02-15 16:35jorge-garciaResolutionopen => fixed
2016-02-15 16:35jorge-garciaStatusresolved => closed

Notes
(0081432)
hgbot   
2015-11-02 13:01   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 58770718dfae7bfc16a9f5f791ecf0b5a7b5fbb2
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Oct 30 12:08:00 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/58770718dfae7bfc16a9f5f791ecf0b5a7b5fbb2 [^]

Fixed issue 31297: barcode scanner is working wrong in some scenarios

This commit fixes the following issues:
* 31297: barcode scanner is adding one unit of the last product added to the
  ticket.
* 31000: barcode scanner should be disabled when done button is clicked.
* 31001: barcode scanner should not add a payment.

This commit fixes also these aditional scenarios:
* If you click in the scan tab the Quantity button and the user use the barcode
   scanner, a huge quantity is added for the product selected.
* If you click in the scan tab the Price button and the user use the barcode
   scanner, a huge price is added for the product selected.
* If you click in the scan tab the Discount button and the user use the barcode
   scanner, a huge discount is added for the product selected.

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---
(0081434)
hgbot   
2015-11-02 13:02   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 46b58bd5bdea226878e7cce61820d41c8b31b4f2
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Oct 30 12:08:45 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/46b58bd5bdea226878e7cce61820d41c8b31b4f2 [^]

Related to issue 31297: barcode scanner is working wrong in some scenarios

This commit fixes the following issues:
* 31297: barcode scanner is adding one unit of the last product added to the
  ticket.
* 31000: barcode scanner should be disabled when done button is clicked.
* 31001: barcode scanner should not add a payment.

This commit fixes also these aditional scenarios:
* If you click in the scan tab the Quantity button and the user use the barcode
   scanner, a huge quantity is added for the product selected.
* If you click in the scan tab the Price button and the user use the barcode
   scanner, a huge price is added for the product selected.
* If you click in the scan tab the Discount button and the user use the barcode
   scanner, a huge discount is added for the product selected.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js
---
(0082075)
hgbot   
2015-11-23 12:57   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8a3dbbb810ed033b462845fc2ce88b7a66667cda
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Nov 19 17:08:54 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8a3dbbb810ed033b462845fc2ce88b7a66667cda [^]

Related to issue 31297: barcode scanner is working wrong in some scenarios

* Enable to use barcode scanner in edit tab

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js
---
(0082076)
hgbot   
2015-11-23 12:57   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 93fe24d36e049a31eed3de27667096bcf09422fd
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Nov 19 17:13:39 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/93fe24d36e049a31eed3de27667096bcf09422fd [^]

Related to issue 31297: barcode scanner is working wrong in some scenarios

Some changes are necessary

* Only disable key Enter from external keyboard if the barcode is being used.

* Even if the barcode is being used and the keyPressProcessed is true, we
   execute the key that is being pressed.

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
---
(0082635)
marvintm   
2015-12-10 11:52   
Scanning with an external barcode scanner seems not to work.
(0082668)
hgbot   
2015-12-11 08:26   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 8bd561aa30d6060a7626421b613cae369e925ca2
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Dec 10 11:58:37 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/8bd561aa30d6060a7626421b613cae369e925ca2 [^]

Related to issue 31297: barcode scanner is working wrong in some scenarios

If it's not using an external input, the keyboard and the barcode scanner
shouldn't generate an input event

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---
(0082707)
marvintm   
2015-12-14 12:07   
Now the scan action is detected in the payment tab, and it shouldn't be.
(0082725)
jorge-garcia   
2015-12-14 15:38   
A new related issue has been created:

https://issues.openbravo.com/view.php?id=31704 [^]