Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031292Openbravo ERPA. Platformpublic2015-10-27 16:452015-11-09 09:40
Reportermfuertes 
Assigned Tocaristu 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0PR15Q1.4 
Target Version3.0PR15Q4Fixed in Version 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2014-05-26
Regression introduced in release3.0PR14Q3
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/402d7bca3f774737bf194cb7cbe41d2454a69326 [^]
Triggers an Emergency PackNo
Summary0031292: current combo value is not selected when opening drop down list with mouse in form view
DescriptionWhen editing in form view and a combo's drop down is opened by clicking with the mouse the picker down arrow icon (in the right of the field's text box), the current value of the field does not get automatically selected in the field's text box.

This behavior forces the user to have to select the field value in order to start typing a different one.

In previous releases (<=3.0PR14Q2), the value got selected for Table, TableDir and List references, but not for Selectors. Starting from 3.0PR14Q2 it is not selected for any of them.

Notes:
  * When editing in grid view, the behavior is different, being the text selected for the 3 references mentioned above.
  * When drop down is opened use keyboard (alt+key down), text never gets selected.
Steps To ReproduceDo the same for both versions:
- Go to Sales Order (or any other window with a drop-down field)
- Create a new Order in form view
- Click on the dropdown arrow for "Organization" field (for example)

For Version 14Q2.5 (Version from livebuilds tested) the text "F&B España - Región Norte" for example will be selected so that the user can start typing to select another value.

For Version 15Q1.4 and PI (PI tested in livebuilds), the text "F&B España - Región Norte" will not be selected and the user will need to select the text in order to start typing another value.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0031274 closed caristu current combo value is not selected when opening drop down list with mouse in form view 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-10-29 11:10alostaleTypedefect => backport
2015-10-29 11:10alostaleTarget Version => 3.0PR15Q4
2015-11-05 16:34hgbotCheckin
2015-11-05 16:34hgbotNote Added: 0081525
2015-11-05 16:34hgbotStatusscheduled => resolved
2015-11-05 16:34hgbotResolutionopen => fixed
2015-11-05 16:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q4/rev/7642e92644ebcc92d2c2b547bec10c3820f02d66 [^]
2015-11-05 19:14caristuReview Assigned To => alostale
2015-11-05 19:14caristuIssue Monitored: alostale
2015-11-06 14:40alostaleAssigned Toplatform => caristu
2015-11-09 09:40alostaleNote Added: 0081604
2015-11-09 09:40alostaleStatusresolved => closed

Notes
(0081525)
hgbot   
2015-11-05 16:34   
Repository: erp/backports/3.0PR15Q4
Changeset: 7642e92644ebcc92d2c2b547bec10c3820f02d66
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Nov 05 16:33:40 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q4/rev/7642e92644ebcc92d2c2b547bec10c3820f02d66 [^]

fixes issue 31292: current combo value is not selected when opening drop down

The problem is caused because after the combo refactor project table and tabledir references make use of a class with different behavior (OBFKComboItem).

Together with this, currently in the FormItem class there is a logic on the _shouldSelectOnFocus method which performs the selection just when tabbing through the form, or on programmatic focus, but not on mouse click. This is the main reason why the text is not being selected when clicking on the drop-down in form view for any reference.

In order to have a common behavior for all the combos in both grid and form view, we are overriding the showPicker() method of OBComboBoxItem to ensure that we select the text after clicking on the drop-down

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-combo.js
---
(0081604)
alostale   
2015-11-09 09:40   
code reviewed

tested:

Value is selected when drop down is opened in with mouse both in grid and form view for table, tableDir and list references.