Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031274Openbravo ERPA. Platformpublic2015-10-27 16:452015-11-23 21:17
Reportermfuertes 
Assigned Tocaristu 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0PR15Q1.4 
Target VersionFixed in Version3.0PR16Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2014-05-26
Regression introduced in release3.0PR14Q3
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/402d7bca3f774737bf194cb7cbe41d2454a69326 [^]
Triggers an Emergency PackNo
Summary0031274: current combo value is not selected when opening drop down list with mouse in form view
DescriptionWhen editing in form view and a combo's drop down is opened by clicking with the mouse the picker down arrow icon (in the right of the field's text box), the current value of the field does not get automatically selected in the field's text box.

This behavior forces the user to have to select the field value in order to start typing a different one.

In previous releases (<=3.0PR14Q2), the value got selected for Table, TableDir and List references, but not for Selectors. Starting from 3.0PR14Q2 it is not selected for any of them.

Notes:
  * When editing in grid view, the behavior is different, being the text selected for the 3 references mentioned above.
  * When drop down is opened use keyboard (alt+key down), text never gets selected.
Steps To ReproduceDo the same for both versions:
- Go to Sales Order (or any other window with a drop-down field)
- Create a new Order in form view
- Click on the dropdown arrow for "Organization" field (for example)

For Version 14Q2.5 (Version from livebuilds tested) the text "F&B España - Región Norte" for example will be selected so that the user can start typing to select another value.

For Version 15Q1.4 and PI (PI tested in livebuilds), the text "F&B España - Región Norte" will not be selected and the user will need to select the text in order to start typing another value.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0030507 closed inigosanchez When clicking on a field on edit mode on the grid the value is not selected 
related to defect 00187393.0MP4 closed mtaal Business Partner selector overwrites first typed letter 
depends on backport 00312923.0PR15Q4 closed caristu current combo value is not selected when opening drop down list with mouse in form view 
depends on backport 00312933.0PR15Q3.4 closed caristu current combo value is not selected when opening drop down list with mouse in form view 
caused by feature request 00262673.0PR14Q3 closed shankarb Re-implement combos (table and tableDir) to use datasources 
related to defect 00313773.0PR16Q1 closed caristu Current combo value is not selected when opening drop down list with the keyboard 
related to defect 0031391 closed caristu Current combo value is not selected when opening drop down list with mouse in Edge 
Attached Files? 15q1.avi (1,070,592) 2015-10-27 16:45
https://issues.openbravo.com/file_download.php?file_id=8655&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-10-27 16:45mfuertesNew Issue
2015-10-27 16:45mfuertesAssigned To => platform
2015-10-27 16:45mfuertesFile Added: 15q1.avi
2015-10-27 16:45mfuertesModules => Core
2015-10-27 16:45mfuertesResolution time => 1450134000
2015-10-27 16:45mfuertesTriggers an Emergency Pack => No
2015-10-27 17:40alostaleNote Added: 0081358
2015-10-27 17:40alostaleAssigned Toplatform => mfuertes
2015-10-27 17:40alostaleStatusnew => feedback
2015-10-28 14:10mfuertesAssigned Tomfuertes => platform
2015-10-28 14:10mfuertesStatusfeedback => new
2015-10-28 14:10mfuertesSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=9952#r9952
2015-10-29 10:20alostaleRelationship addedrelated to 0030507
2015-10-29 10:35alostaleRegression level => Production - Confirmed Stable
2015-10-29 10:35alostaleRegression date => 2014-05-26
2015-10-29 10:35alostaleRegression introduced in release => 3.0PR14Q3
2015-10-29 10:35alostaleRegression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/402d7bca3f774737bf194cb7cbe41d2454a69326 [^]
2015-10-29 10:36alostaleRelationship addedcaused by 0026267
2015-10-29 10:58alostaleSummaryField is not automatically selected (to delete) in selector-fields => current combo value is not selected when opening drop down list with mouse in form view
2015-10-29 10:58alostaleDescription Updatedbug_revision_view_page.php?rev_id=9955#r9955
2015-10-29 10:58alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=9956#r9956
2015-10-29 11:03alostaleDescription Updatedbug_revision_view_page.php?rev_id=9957#r9957
2015-10-29 11:04alostaleDescription Updatedbug_revision_view_page.php?rev_id=9958#r9958
2015-10-29 11:09alostaleNote Added: 0081387
2015-10-29 11:10alostaleStatusnew => acknowledged
2015-10-29 11:10alostaleStatusacknowledged => scheduled
2015-11-04 09:05alostaleNote Added: 0081462
2015-11-04 09:40alostaleAssigned Toplatform => caristu
2015-11-04 13:38caristuRelationship addedrelated to 0018739
2015-11-05 16:30hgbotCheckin
2015-11-05 16:30hgbotNote Added: 0081524
2015-11-05 16:30hgbotStatusscheduled => resolved
2015-11-05 16:30hgbotResolutionopen => fixed
2015-11-05 16:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e8d3e7c131e94820cc47d7ad9a4601ecd87511a4 [^]
2015-11-05 16:51caristuRelationship addedrelated to 0031377
2015-11-05 17:30caristuNote Added: 0081530
2015-11-05 19:13caristuReview Assigned To => alostale
2015-11-05 19:13caristuIssue Monitored: alostale
2015-11-06 11:22caristuRelationship addedrelated to 0031391
2015-11-09 09:47alostaleNote Added: 0081606
2015-11-09 09:47alostaleStatusresolved => closed
2015-11-09 09:47alostaleFixed in Version => 3.0PR16Q1
2015-11-23 21:17hudsonbotCheckin
2015-11-23 21:17hudsonbotNote Added: 0082181

Notes
(0081358)
alostale   
2015-10-27 17:40   
Please report the issue properly.

Summary nor description are detailed enough to understand the issue (not even with the attached video). Include also steps to reproduce.
(0081387)
alostale   
2015-10-29 11:09   
This behavior was not properly defined (nor in older neither in newer releases). Being different depending on the reference of the field, method used to open the drop down list and view (grid/form) the record is being edited from. A table with the different cases can be found here [1].

Therefore, before fixing the issue, UX should be properly defined.

[1] https://docs.google.com/a/openbravo.com/spreadsheets/d/1hfsMCusQW_1GkwoX6VYxGEieWljJXCAJr5-px5xgNMk/edit?usp=sharing [^]
(0081462)
alostale   
2015-11-04 09:05   
After discussing it with UX expert: text should be selected in all cases (grid and form, opening drop down with keyboard and mouse).
(0081524)
hgbot   
2015-11-05 16:30   
Repository: erp/devel/pi
Changeset: e8d3e7c131e94820cc47d7ad9a4601ecd87511a4
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Nov 05 16:19:46 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e8d3e7c131e94820cc47d7ad9a4601ecd87511a4 [^]

fixes issue 31274: current combo value is not selected when opening drop down
The problem is caused because after the combo refactor project table and tabledir references make use of a class with different behavior (OBFKComboItem).

Together with this, currently in the FormItem class there is a logic on the _shouldSelectOnFocus method which performs the selection just when tabbing through the form, or on programmatic focus, but not on mouse click. This is the main reason why the text is not being selected when clicking on the drop-down in form view for any reference.

In order to have a common behavior for all the combos in both grid and form view, we are overriding the showPicker() method of OBComboBoxItem to ensure that we select the text after clicking on the drop-down

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-combo.js
---
(0081530)
caristu   
2015-11-05 17:30   
Created the following test cases in TestLink:

- Grid editing mode: https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-9912 [^]

- Form editing mode: https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-9913 [^]
(0081606)
alostale   
2015-11-09 09:47   
code reviewed

tested:

Value is selected when drop down is opened in with mouse both in grid and form view for table, tableDir and list references.
(0082181)
hudsonbot   
2015-11-23 21:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test