Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031217Openbravo ERPB. User interfacepublic2015-10-22 14:082015-11-23 21:16
Reportercaristu 
Assigned Toplatform 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0PR16Q1 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPackaging and release
Regression date2015-10-13
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/da1f8f6d7339b4f799da52ec735f3fcb5b97a636 [^]
Triggers an Emergency PackNo
Summary0031217: Toolbar disappears under some circumnstances
DescriptionToolbar disappears (see attached) under some circumnstances.
Steps To Reproduce1) Go to the [Goods Shipments] window
2) Create a new record in the header
3) Navigate to the [Lines] tab
4) Create a new record
5) Without saving the record, click on the header tab (on the top, in the green part where the name of the header is placed). Notice that the toolbar is gone.

The following error appears on the client console: Uncaught TypeError: Cannot read property 'parameters' of null
Proposed SolutionThe problem is on ob-standard-window.js file at this point:

dirtyEditForm.autoSave(action.parameters);

it shoulr be checked if action is null.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00312243.0PR15Q4 closed caristu Toolbar disappears under some circumnstances 
depends on backport 00312253.0PR15Q3.2 closed caristu Toolbar disappears under some circumnstances 
depends on backport 00312263.0PR15Q2.6 closed caristu Toolbar disappears under some circumnstances 
caused by defect 0030940 closed NaroaIriarte When add a second new line in goods movements, the product field is already filled 
Attached Filespng toolbarGone.png (83,531) 2015-10-22 14:08
https://issues.openbravo.com/file_download.php?file_id=8622&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2015-10-22 14:08caristuNew Issue
2015-10-22 14:08caristuAssigned To => platform
2015-10-22 14:08caristuFile Added: toolbarGone.png
2015-10-22 14:08caristuModules => Core
2015-10-22 14:08caristuTriggers an Emergency Pack => No
2015-10-22 14:08caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=9821#r9821
2015-10-22 14:08caristuIssue Monitored: networkb
2015-10-22 14:09caristuPrioritynormal => high
2015-10-22 16:07caristuRegression level => Packaging and release
2015-10-22 16:07caristuRegression date => 2015-10-13
2015-10-22 16:07caristuRegression introduced in release => pi
2015-10-22 16:07caristuRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/da1f8f6d7339b4f799da52ec735f3fcb5b97a636 [^]
2015-10-22 16:07caristuDescription Updatedbug_revision_view_page.php?rev_id=9829#r9829
2015-10-22 16:07caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=9830#r9830
2015-10-22 16:07caristuProposed Solution updated
2015-10-22 16:19caristuRelationship addedcaused by 0030940
2015-10-22 16:28caristuStatusnew => scheduled
2015-10-22 17:52hgbotCheckin
2015-10-22 17:52hgbotNote Added: 0081234
2015-10-22 17:52hgbotStatusscheduled => resolved
2015-10-22 17:52hgbotResolutionopen => fixed
2015-10-22 17:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b8f2fffd73f4bfafc54bb724675f5dcc66202ad1 [^]
2015-10-22 17:53caristuReview Assigned To => AugustoMauch
2015-10-22 17:53caristuIssue Monitored: AugustoMauch
2015-10-23 09:41AugustoMauchNote Added: 0081248
2015-10-23 09:41AugustoMauchStatusresolved => closed
2015-10-23 09:41AugustoMauchFixed in Version => 3.0PR16Q1
2015-11-23 21:16hudsonbotCheckin
2015-11-23 21:16hudsonbotNote Added: 0082150

Notes
(0081234)
hgbot   
2015-10-22 17:52   
Repository: erp/devel/pi
Changeset: b8f2fffd73f4bfafc54bb724675f5dcc66202ad1
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Oct 22 17:51:34 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b8f2fffd73f4bfafc54bb724675f5dcc66202ad1 [^]

fixes issue 31217: Toolbar disappears under some circumnstances
The problem was that action can be null when invoking dirtyEditForm.autoSave. Now we have prevented the error by avoiding to use action.parameters if action is null

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
---
(0081248)
AugustoMauch   
2015-10-23 09:41   
Code reviewed and verified in pi@7afc66ef62b4
(0082150)
hudsonbot   
2015-11-23 21:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test