Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0031215Openbravo ERP07. Sales managementpublic2015-10-22 12:302015-11-27 15:40
ngarcia 
aferraz 
urgentmajoralways
closedfixed 
5
 
 
vmromanos
Core
No
0031215: Cannot reserve the pending amount in a partially delivered sales order line if there is not the whole amount in stock
Cannot reserve the pending amount in a partially delivered sales order line if there is not the whole amount in stock
As group admin role:
   Create the Enable Stock Reservations preference
   Log out and log in
   Check the stock of a product that only has stock in one storage bin (e.g. 600)
   Create a sales order for more amount than the available stock and book it (e.g. 1000)
   Click on Manage Reservation button and reserve all the available quantity (e.g. 600)
   Create the Goods Shipment with the Create Shipments From Orders process
   Create a Goods Receipt for the pending quantity, assign the same storage bin of the reservation and complete it (e.g. 400)
   Go to the Sales Order line again, Manage Reservation and update the Quantity to the whole ordered quantity (e.g. 1000)
   Check you cannot do it:
      "Reserved quantity exceeds the available quantity (400) considering the quantity reserved in other reservations (0). Please, enter a valid number."
Note: the check should be made with Quantity - Released and currently it is done with Quantity
No tags attached.
Issue History
2015-10-22 12:30ngarciaNew Issue
2015-10-22 12:30ngarciaAssigned To => Triage Finance
2015-10-22 12:30ngarciaModules => Core
2015-10-22 12:30ngarciaResolution time => 1449010800
2015-10-22 12:30ngarciaTriggers an Emergency Pack => No
2015-10-22 12:30ngarciaIssue Monitored: networkb
2015-10-22 13:09heccamIssue Monitored: heccam
2015-11-24 20:29aferrazAssigned ToTriage Finance => aferraz
2015-11-24 20:29aferrazStatusnew => scheduled
2015-11-25 12:44aferrazNote Added: 0082322
2015-11-25 14:27psanjuanNote Added: 0082324
2015-11-25 14:33psanjuanNote Edited: 0082322bug_revision_view_page.php?bugnote_id=0082322#r10356
2015-11-25 14:33psanjuanNote Added: 0082326
2015-11-27 09:55hgbotCheckin
2015-11-27 09:55hgbotNote Added: 0082396
2015-11-27 09:55hgbotStatusscheduled => resolved
2015-11-27 09:55hgbotResolutionopen => fixed
2015-11-27 09:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2c7a04678d4886146b9167945e82d122673e452d [^]
2015-11-27 09:56vmromanosReview Assigned To => vmromanos
2015-11-27 09:56vmromanosNote Added: 0082397
2015-11-27 09:56vmromanosStatusresolved => closed
2015-11-27 15:40hudsonbotCheckin
2015-11-27 15:40hudsonbotNote Added: 0082438

Notes
(0082322)
aferraz   
2015-11-25 12:44   
(edited on: 2015-11-25 14:33)
Test plan:

As group admin role:
   Create the Enable Stock Reservations preference
   Log out and log in
   Check the stock of a product that only has stock in one storage bin (e.g. 600)
   Create a sales order for more amount than the available stock and book it (e.g. 1000)
   Click on Manage Reservation button and reserve all the available quantity (e.g. 600)
   Create the Goods Shipment with the Create Shipments From Orders process
   Create a Goods Receipt for the pending quantity, assign the same storage bin of the reservation and complete it (e.g. 400)
   Go to the Sales Order line again, Manage Reservation and update the Quantity to the whole ordered quantity (e.g. 1000)
   Check you can do it
Go to Reserved Stock tab and verify that Quantity field = 1000 and Released = 600
Go to Create Shipment from orders and create the remaining shipment.
Verify it ends successfully with a message such as: Order nº 153 Shipment nº 171. Shipment completed successfully.
Go to the shipment window and verify there are now two shipments:
    Shipment 170 - 600 units
    Shipment 171 - 400 units

(0082324)
psanjuan   
2015-11-25 14:27   
Issue verified.
(0082326)
psanjuan   
2015-11-25 14:33   
Test Plan verified.
Issue can be code reviewed and closed.
(0082396)
hgbot   
2015-11-27 09:55   
Repository: erp/devel/pi
Changeset: 2c7a04678d4886146b9167945e82d122673e452d
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Nov 25 12:29:31 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2c7a04678d4886146b9167945e82d122673e452d [^]

Fixes issue 31215:Cannot reserve pending amount in partial delivered SalesOrder

When executing Manage Reservation from Sales Order and checking reservation quantity is less than (availableQty - reservedinothersQty), this check should be done with (quantity - releasedQty) instead of with quantity.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/materialmgmt/ob-reservation.js
---
(0082397)
vmromanos   
2015-11-27 09:56   
Code review OK
(0082438)
hudsonbot   
2015-11-27 15:40   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/69c005c2c741 [^]
Maturity status: Test