0031207: The costing background process fails when the 'fixbackdated from' is defined before the costing rule's starting date

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0031207

Openbravo ERP

04. Warehouse management

public

2015-10-21 16:43

2015-11-23 21:17

Reporter

VictorVillar

Assigned To

aferraz

Priority

immediate

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

3.0PR16Q1

Fixed in Version

Merge Request Status

Review Assigned To

dmiguelez

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0031207: The costing background process fails when the 'fixbackdated from' is defined before the costing rule's starting date

Description

The costing background process fails when the 'fixbackdated from' is defined before the costing rule's starting date and it should not.

Steps To Reproduce

The costing background process fails when the 'fixbackdated from' is defined before the costing rule's starting date and it should not because it does not make sense to adjust something either that was calculated by the old costing engine or by other costing algorithm.

Because of that we have identified 3 problems:

1.- UI: possibility to select the 'Fix backdated From' date before the starting date of the costing rule and if the starting date is blank it should not be possible to select one before it started the costing rule

2.- necessary to fix the following method: getCostingRuleFixBackdatedFrom in CostingUtils.java because is the same as getCostingRuleStartingDate.
if (rule.getStartingDate() == null) {
      SimpleDateFormat outputFormat = new SimpleDateFormat("dd-MM-yyyy");
      try {
        return outputFormat.parse("01-01-1900");
      } catch (ParseException e) {
        // Error parsing the date.
        log4j.error("Error parsing the date.", e);
        return null;
      }
    }
    return rule.getStartingDate();
  }

3.- Necessary to control in our code the FixBackdatedFrom date in order to adjust the backdated. Proposed solution (CostingServer.java - method:checkCostAdjustments)

    if (getCostingRule().isBackdatedTransactionsFixed()
        && transaction.getMovementDate().after(
            CostingUtils.getCostingRuleStartingDate(getCostingRule()))
            && transaction.getMovementDate().after(
            CostingUtils.getCostingRuleFixBackdatedFrom(getCostingRule()))
        && CostAdjustmentUtils.isNeededBackdatedCostAdjustment(transaction, getCostingRule()
            .isWarehouseDimension(), CostingUtils.getCostingRuleStartingDate(getCostingRule()))) {
      // BDT= Backdated transaction
      CostAdjustment costAdjustmentHeader = CostAdjustmentUtils.insertCostAdjustmentHeader(
          transaction.getOrganization(), "BDT");

Proposed Solution

Additional Information