Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0031198 | Openbravo ERP | A. Platform | public | 2015-10-21 12:59 | 2015-11-23 21:16 |
|
| Reporter | umartirena | |
| Assigned To | inigosanchez | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 3.0PR16Q1 | |
| Merge Request Status | |
| Review Assigned To | alostale |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0031198: Read Only logic does not work properly in grid view with combo type fields. |
| Description | Read Only logic does not work properly in grid view with combo type fields. If there are two fields on a grid, one having List as a reference and the second one being a tabledir and the second one has a read only logic based on the value of the first one, the second one does not work properly. When should be read only, it gets read only without any problem, but when turns editable the combo is not completely redrawn (the little arrow does not appear) and the combo is not filtered if any value is entered there. |
| Steps To Reproduce | -Create two fields on a window:
* First one as a List.
* Second one as a Tabledir.
-Add a readonly logic on the second one based on first one.
-Be sure that the value by default in the List is the one that makes the second field to be read only.
-Be sure also that 'List' field must be next to (leftside) of the 'TableDir' field.
-Go to the window and in grid view add a record.Check that the second field is read only.
-Change the value in the first field. Check that the second field turns editable, but the combo is not completely redrawn (the little arrow does not appear), and if any value is entered in the filter no values are displayed in the combo.
Note1: In the pictures it can see that 'List' field is not next to (leftside) of the 'TableDir' field but this is because the intermediate fields are not editables (RO).
Note2: If the second field is a 'List' instead of a 'TableDir' (Both 'List' fields) the behaviour is the same as described in the issue. |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0035658 | | closed | inigosanchez | Fields redraws in grid view when a numeric field is referenced by a read only logic |
|
| Attached Files |  Screenshot1.png (35,622) 2015-10-21 13:03
https://issues.openbravo.com/file_download.php?file_id=8605&type=bug
Screenshot2.png (35,394) 2015-10-21 13:03
https://issues.openbravo.com/file_download.php?file_id=8606&type=bug
Screenshot3.png (35,753) 2015-10-21 13:03
https://issues.openbravo.com/file_download.php?file_id=8607&type=bug
 issue31198.export (2,304) 2015-10-30 13:17
https://issues.openbravo.com/file_download.php?file_id=8669&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2015-10-21 12:59 | umartirena | New Issue | |
| 2015-10-21 12:59 | umartirena | Assigned To | => platform |
| 2015-10-21 12:59 | umartirena | Modules | => Core |
| 2015-10-21 12:59 | umartirena | Resolution time | => 1446591600 |
| 2015-10-21 12:59 | umartirena | Triggers an Emergency Pack | => No |
| 2015-10-21 13:03 | umartirena | File Added: Screenshot1.png | |
| 2015-10-21 13:03 | umartirena | File Added: Screenshot2.png | |
| 2015-10-21 13:03 | umartirena | File Added: Screenshot3.png | |
| 2015-10-22 16:00 | alostale | Status | new => scheduled |
| 2015-10-22 16:00 | alostale | Assigned To | platform => inigosanchez |
| 2015-10-27 18:23 | inigosanchez | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=9940#r9940 |
| 2015-10-28 13:33 | inigosanchez | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=9950#r9950 |
| 2015-10-30 12:34 | inigosanchez | Issue Monitored: alostale | |
| 2015-10-30 12:34 | inigosanchez | Note Added: 0081401 | |
| 2015-10-30 13:17 | inigosanchez | File Added: issue31198.export | |
| 2015-11-02 13:18 | hgbot | Checkin | |
| 2015-11-02 13:18 | hgbot | Note Added: 0081436 | |
| 2015-11-02 13:18 | hgbot | Status | scheduled => resolved |
| 2015-11-02 13:18 | hgbot | Resolution | open => fixed |
| 2015-11-02 13:18 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/543f652781a23ae2d4bda64983e346a171e92df0 [^] |
| 2015-11-02 13:19 | alostale | Review Assigned To | => alostale |
| 2015-11-02 13:22 | alostale | Note Added: 0081437 | |
| 2015-11-02 13:22 | alostale | Status | resolved => closed |
| 2015-11-02 13:22 | alostale | Fixed in Version | => 3.0PR16Q1 |
| 2015-11-23 21:16 | hudsonbot | Checkin | |
| 2015-11-23 21:16 | hudsonbot | Note Added: 0082165 | |
| 2017-04-18 14:32 | inigosanchez | Relationship added | related to 0035658 |
|
Notes |
|
|
|
Added tests in TestLink [1]:
*Platform > [ROL] Read Only Logic > [ROLa] Read Only in grid:
-ROLa010 RO with combo type fields.
-ROLa020 RO with combo type fields on focus. (I)
-ROLa030 RO with combo type fields on focus. (II)
*Platform > [ROL] Read Only Logic > [ROLb] Read Only in form.
-ROLb010 RO with combo type fields.
-ROLb020 RO with combo type fields on focus. (I)
-ROLb030 RO with combo type fields on focus. (II)
[1] https://testlink.openbravo.com/testlink [^] [^] |
|
|
|
(0081436)
|
|
hgbot
|
|
2015-11-02 13:18
|
|
Repository: erp/devel/pi
Changeset: 543f652781a23ae2d4bda64983e346a171e92df0
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Fri Oct 30 13:15:08 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/543f652781a23ae2d4bda64983e346a171e92df0 [^]
Fixed bug 31198:RO logic doesn't work properly in grid view with combo fields
The problem was that Read Only logic did not work properly in grid view with
combo type fields. If there were two fields on a grid, one having 'List' as
a reference and the second one been a 'TableDir' and the second one had a read
only logic based on the value of the first one, the second one did not work
properly. This happend when 'List' field was next to (leftside) of the
'TableDir' field or if there were intermediate fields between 'List' and
'TableDir' fields that were not editables (RO).
The problem has been fixed overriding a 'refreshCell()' method to use
'allowEditCellRefresh' parameter. This parameter is taking into account in
'refreshCellValue()' method of SC and if there is a visible editor in the
cell with the focus on it, redrawing and update it's value.
This fix take into account when 'refreshCell()' method is called with a value
in 'allowEditCellRefresh' parameter and in this case it will not be called
the overridden method to avoid delete some preexisting correct fluxes.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
|
|
|
|
|
code reviewed
tested:
- Issue as reported
- Additional test cases added to test link (see above)
- No extra requests are performed on refresh |
|
|
|
|
|