Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0031180 | Openbravo ERP | A. Platform | public | 2015-10-20 10:27 | 2016-03-17 10:55 |
|
| Reporter | umartirena | |
| Assigned To | caristu | |
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | 3.0PR16Q2 | Fixed in Version | 3.0PR16Q2 | |
| Merge Request Status | |
| Review Assigned To | alostale |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0031180: [SERQA 304]"openDirectTab" action does not work properly when the opening tab is already opened |
| Description | "openDirectTab" action does not work properly when the opening tab is already opened.
The new tab is opened in the first position instead in the next position that should be opened.
This causes that other action executed inmediately after it like "showMsgInView" to not to perform properly displaying the message in the old tab instead on the new one. |
| Steps To Reproduce | * Clone the following branch of PI:
https://code.openbravo.com/erp/devel/pi-cancelreplace [^]
* Add the preference "Allow Multiple Tabs of a Window" for Sales Order window with value "Y" in order to allow open it in multiple tabs at the same time.
* Open openbravo and go to Sales Order window.
* Create a new Sales Order with a line and complete it.
* Click on Cancel and Replace button.
* Realize that the message that should appear in the message bar of the new opened tab is show in the old tab. |
| Proposed Solution | |
| Additional Information | |
| Tags | SER-QA |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2015-10-20 10:27 | umartirena | New Issue | |
| 2015-10-20 10:27 | umartirena | Assigned To | => platform |
| 2015-10-20 10:27 | umartirena | Modules | => Core |
| 2015-10-20 10:27 | umartirena | Triggers an Emergency Pack | => No |
| 2015-11-06 12:40 | alostale | Priority | urgent => normal |
| 2015-11-06 12:40 | alostale | Status | new => acknowledged |
| 2015-12-01 11:52 | agete | Tag Attached: SER-QA | |
| 2015-12-01 11:52 | agete | Summary | "openDirectTab" action does not work properly when the opening tab is already opened => [SERQA 304]"openDirectTab" action does not work properly when the opening tab is already opened |
| 2016-01-27 10:24 | alostale | Assigned To | platform => caristu |
| 2016-01-27 10:24 | alostale | Status | acknowledged => scheduled |
| 2016-01-27 10:24 | alostale | Target Version | => 3.0PR16Q2 |
| 2016-01-27 10:24 | alostale | Priority | normal => urgent |
| 2016-01-28 09:19 | caristu | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=10787#r10787 |
| 2016-01-28 18:56 | hgbot | Checkin | |
| 2016-01-28 18:56 | hgbot | Note Added: 0083693 | |
| 2016-01-28 18:56 | hgbot | Status | scheduled => resolved |
| 2016-01-28 18:56 | hgbot | Resolution | open => fixed |
| 2016-01-28 18:56 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/a0b036f79c114ff07c736743359358705612a719 [^] |
| 2016-01-29 09:14 | caristu | Note Added: 0083709 | |
| 2016-01-29 09:14 | caristu | Status | resolved => new |
| 2016-01-29 09:14 | caristu | Resolution | fixed => open |
| 2016-01-29 09:16 | caristu | Status | new => scheduled |
| 2016-01-29 09:56 | hgbot | Checkin | |
| 2016-01-29 09:56 | hgbot | Note Added: 0083718 | |
| 2016-01-29 13:22 | hgbot | Checkin | |
| 2016-01-29 13:22 | hgbot | Note Added: 0083726 | |
| 2016-01-29 13:22 | hgbot | Status | scheduled => resolved |
| 2016-01-29 13:22 | hgbot | Resolution | open => fixed |
| 2016-01-29 13:22 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/a0b036f79c114ff07c736743359358705612a719 [^] => http://code.openbravo.com/erp/devel/pi/rev/cc28a29cb724ae5c651d29f6705433fac75c8ead [^] |
| 2016-01-29 13:23 | caristu | Issue Monitored: alostale | |
| 2016-01-29 13:23 | caristu | Review Assigned To | => alostale |
| 2016-02-05 09:00 | alostale | Note Added: 0083948 | |
| 2016-02-05 09:00 | alostale | Status | resolved => closed |
| 2016-02-05 09:00 | alostale | Fixed in Version | => 3.0PR16Q2 |
| 2016-03-17 10:55 | hudsonbot | Checkin | |
| 2016-03-17 10:55 | hudsonbot | Note Added: 0085085 | |
| 2016-03-17 10:55 | hudsonbot | Checkin | |
| 2016-03-17 10:55 | hudsonbot | Note Added: 0085088 | |
| 2016-03-17 10:55 | hudsonbot | Checkin | |
| 2016-03-17 10:55 | hudsonbot | Note Added: 0085089 | |
|
Notes |
|
|
(0083693)
|
|
hgbot
|
|
2016-01-28 18:56
|
|
Repository: erp/devel/pi
Changeset: a0b036f79c114ff07c736743359358705612a719
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Jan 28 18:48:27 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a0b036f79c114ff07c736743359358705612a719 [^]
fixes issue 31180: openDirectTab action now works if the tab is already opened
Now the 'openDirectTab' response action takes into account if the 'Allow Multiple Tabs of a Window' preference is enabled. In that case when this action tries to open a tab which is already opened it opens a new tab in the last position instead of refreshing the old one.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities-action-def.js
---
|
|
|
|
|
The fix is not complete. It should take into account also this case:
- Opening a tab already opened but different to the tab where the process is fired. |
|
|
|
(0083718)
|
|
hgbot
|
|
2016-01-29 09:56
|
|
Repository: erp/devel/pi
Changeset: 9080d38ba5753cce20aec14208a3ffb816958de0
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Jan 29 09:55:26 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9080d38ba5753cce20aec14208a3ffb816958de0 [^]
related to issue 31180: backed out changeset
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities-action-def.js
---
|
|
|
|
(0083726)
|
|
hgbot
|
|
2016-01-29 13:22
|
|
Repository: erp/devel/pi
Changeset: cc28a29cb724ae5c651d29f6705433fac75c8ead
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Jan 29 12:56:36 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/cc28a29cb724ae5c651d29f6705433fac75c8ead [^]
fixes issue 31180: openDirectTab action now works if the tab is already opened
When the opening tab was already opened, the openDirectTab method was not waiting properly to the new tab be refreshed/opened. This was caused because the callout of OB.Utilities.openDirectTab method was invoked after the line that checks if the action needs to wait.
Now if the tab is already opened the action is called again with a delay of 100ms, giving OB.Utilities.openDirectTab enough time to execute its callout.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities-action-def.js
---
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|