Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031167Openbravo ERP05. Production managementpublic2015-10-09 12:272015-10-20 12:06
Reporterngarcia 
Assigned ToTriage Omni OMS 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q4Fixed in Version 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2014-04-24
Regression introduced in release3.0PR14Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/b856094303a9c6daff6db1d67e29563d273d512a [^]
Triggers an Emergency PackNo
Summary0031167: Copy Version process in Process Plan window is not working in Oracle
DescriptionCopy Version process in Process Plan window is not working in Oracle
Steps To ReproduceAs group admin role:
   Create a Process Plan, Version, Operation...
   Click on the Copy Version and select the already created version
   Check no new version is created and the logs shows:
      ERROR org.openbravo.base.exception.OBException - java.sql.SQLSyntaxErrorException: ORA-00904: "AD_SEQUENCE_DOC": invalid identifier

java.lang.IllegalStateException: java.sql.SQLSyntaxErrorException: ORA-00904: "AD_SEQUENCE_DOC": invalid identifier

    at org.openbravo.service.db.CallStoredProcedure.call(CallStoredProcedure.java:142)
    at org.openbravo.common.actionhandler.CopyProcessPlanVersion.callAdSequenceDoc(CopyProcessPlanVersion.java:188)
Proposed Solution
Additional Information
TagsApproved
Relationships
blocks defect 0031121 closed vmromanos Copy Version process in Process Plan window is not working in Oracle 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-10-19 12:18vmromanosTypedefect => backport
2015-10-19 12:18vmromanosTarget Version => 3.0PR15Q4
2015-10-19 12:19vmromanosTag Attached: Approved
2015-10-20 12:06hgbotCheckin
2015-10-20 12:06hgbotNote Added: 0081124
2015-10-20 12:06hgbotStatusscheduled => resolved
2015-10-20 12:06hgbotResolutionopen => fixed
2015-10-20 12:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q4/rev/5448cf9adeeb0d55a38726062e9db17a03fb7827 [^]
2015-10-20 12:06dmiguelezReview Assigned To => dmiguelez
2015-10-20 12:06dmiguelezNote Added: 0081125
2015-10-20 12:06dmiguelezStatusresolved => closed

Notes
(0081124)
hgbot   
2015-10-20 12:06   
Repository: erp/backports/3.0PR15Q4
Changeset: 5448cf9adeeb0d55a38726062e9db17a03fb7827
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Oct 19 12:38:32 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q4/rev/5448cf9adeeb0d55a38726062e9db17a03fb7827 [^]

Fixed bug 31167: Copy Version process in Process Plan window is not working in Oracle

Ad_Sequence_Doc is a stored procedure that returns the next sequence number using an "out" parameter. The CallStoredProcedure.call() used to call that procedure doesn't currently support parameters of type "out", creating an exception in Oracle only (and not in PostgreSQL because the procedure is declared as a function returning the value).

Instead of calling the procedure using CallStoredProcedure.call(), we use Utility.getDocumentNo() method instead, which is a more standard way to get the next sequence no. from Java, and supports Oracle procedures with "out" parameters.

Besides the class has been modified to properly show an error message in the UI in case an exception is raised, which is something not working before neither.

---
M src/org/openbravo/common/actionhandler/CopyProcessPlanVersion.java
---
(0081125)
dmiguelez   
2015-10-20 12:06   
Code Review + Testing Ok