Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031134Retail ModulesWeb POSpublic2015-10-13 11:002015-10-23 17:02
Reporterdmiguelez 
Assigned Tomarvintm 
PriorityimmediateSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionRR15Q4Fixed in VersionRR15Q4 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerNo
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2015-07-16
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3bfd5690abf1 [^]
Triggers an Emergency PackNo
Summary0031134: [Mobile Core] Some Code from POS is used in Mobile Core Module
DescriptionSome Code from POS is used in Mobile Core Module making it impossible to do an install.source.
Steps To ReproduceStart with a clean Openbravo instance.
Install Mobile Core Infrastructure Module.
Try to do an ant install.source, it fails.

compileSqlc:
    [javac] Compiling 2127 source files to /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/build/classes
    [javac] /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java:43: error: package org.openbravo.retail.posterminal does not exist
    [javac] import org.openbravo.retail.posterminal.OBPOSApplications;
    [javac] ^
    [javac] /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java:230: error: cannot find symbol
    [javac] protected JSONArray getServers(OBPOSApplications terminal) throws JSONException {
    [javac] ^
    [javac] symbol: class OBPOSApplications
    [javac] location: class MobileCoreLoginUtilsServlet
    [javac] /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java:265: error: cannot find symbol
    [javac] protected JSONArray getServices(OBPOSApplications terminal) throws JSONException {
    [javac] ^
    [javac] symbol: class OBPOSApplications
    [javac] location: class MobileCoreLoginUtilsServlet
    [javac] /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java:286: error: cannot find symbol
    [javac] OBPOSApplications terminal = null;
    [javac] ^
    [javac] symbol: class OBPOSApplications
    [javac] location: class MobileCoreLoginUtilsServlet
    [javac] /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java:287: error: cannot find symbol
    [javac] OBCriteria<OBPOSApplications> qApp = OBDal.getInstance().createCriteria(
    [javac] ^
    [javac] symbol: class OBPOSApplications
    [javac] location: class MobileCoreLoginUtilsServlet
    [javac] /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java:288: error: cannot find symbol
    [javac] OBPOSApplications.class);
    [javac] ^
    [javac] symbol: class OBPOSApplications
    [javac] location: class MobileCoreLoginUtilsServlet
    [javac] /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java:289: error: cannot find symbol
    [javac] qApp.add(Restrictions.eq(OBPOSApplications.PROPERTY_SEARCHKEY, terminalName));
    [javac] ^
    [javac] symbol: variable OBPOSApplications
    [javac] location: class MobileCoreLoginUtilsServlet
    [javac] /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java:292: error: cannot find symbol
    [javac] List<OBPOSApplications> apps = qApp.list();
    [javac] ^
    [javac] symbol: class OBPOSApplications
    [javac] location: class MobileCoreLoginUtilsServlet
    [javac] /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java:294: error: cannot find symbol
    [javac] terminal = ((OBPOSApplications) apps.get(0));
    [javac] ^
    [javac] symbol: class OBPOSApplications
    [javac] location: class MobileCoreLoginUtilsServlet
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 9 errors
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0031133 closed mtaal [Mobile Core] Some Code from POS is used in Mobile Core Module 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-10-13 11:09mtaalTypedefect => backport
2015-10-13 11:09mtaalTarget Version => RR15Q4
2015-10-19 07:57mtaalAssigned Tomtaal => Retail
2015-10-22 12:40hgbotCheckin
2015-10-22 12:40hgbotNote Added: 0081202
2015-10-22 12:40hgbotStatusscheduled => resolved
2015-10-22 12:40hgbotResolutionopen => fixed
2015-10-22 12:40hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal/rev/297e928356087f46b5f6c39e7af9ac6088309636 [^]
2015-10-22 12:41hgbotCheckin
2015-10-22 12:41hgbotNote Added: 0081203
2015-10-22 12:41hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal/rev/297e928356087f46b5f6c39e7af9ac6088309636 [^] => http://code.openbravo.com/retail/backports/3.0RR15Q4/org.openbravo.mobile.core/rev/9ef004ba430e0f65727bd791fe6f4bbeca8ac5cb [^]
2015-10-22 16:28marvintmAssigned ToRetail => marvintm
2015-10-23 17:02guilleaerReview Assigned To => guilleaer
2015-10-23 17:02guilleaerNote Added: 0081272
2015-10-23 17:02guilleaerStatusresolved => closed
2015-10-23 17:02guilleaerFixed in Version => RR15Q4

Notes
(0081202)
hgbot   
2015-10-22 12:40   
Repository: retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal
Changeset: 297e928356087f46b5f6c39e7af9ac6088309636
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Thu Oct 22 12:40:18 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal/rev/297e928356087f46b5f6c39e7af9ac6088309636 [^]

Fixed issue 31134. [Mobile Core] Some Code from POS is used in Mobile Core Module
Move code from mobile core to posterminal to make use of the pos terminal concept

---
M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java
---
(0081203)
hgbot   
2015-10-22 12:41   
Repository: retail/backports/3.0RR15Q4/org.openbravo.mobile.core
Changeset: 9ef004ba430e0f65727bd791fe6f4bbeca8ac5cb
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Thu Oct 22 12:40:57 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q4/org.openbravo.mobile.core/rev/9ef004ba430e0f65727bd791fe6f4bbeca8ac5cb [^]

Fixed issue 31134. [Mobile Core] Some Code from POS is used in Mobile Core Module
Move code from mobile core to posterminal to make use of the pos terminal concept

---
M src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java
---
(0081272)
guilleaer   
2015-10-23 17:02   
Install source done fine just using mobile core module -> closed