Openbravo Issue Tracking System - Retail Modules
View Issue Details
0031133Retail ModulesWeb POSpublic2015-10-13 11:002015-11-02 15:49
dmiguelez 
mtaal 
immediatecriticalalways
closedfixed 
20Community Appliance
 
RR16Q1 
marvintm
QA functional test
2015-07-16
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3bfd5690abf1 [^]
No
0031133: [Mobile Core] Some Code from POS is used in Mobile Core Module
Some Code from POS is used in Mobile Core Module making it impossible to do an install.source.
Start with a clean Openbravo instance.
Install Mobile Core Infrastructure Module.
Try to do an ant install.source, it fails.

compileSqlc:
    [javac] Compiling 2127 source files to /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/build/classes
    [javac] /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java:43: error: package org.openbravo.retail.posterminal does not exist
    [javac] import org.openbravo.retail.posterminal.OBPOSApplications;
    [javac] ^
    [javac] /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java:230: error: cannot find symbol
    [javac] protected JSONArray getServers(OBPOSApplications terminal) throws JSONException {
    [javac] ^
    [javac] symbol: class OBPOSApplications
    [javac] location: class MobileCoreLoginUtilsServlet
    [javac] /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java:265: error: cannot find symbol
    [javac] protected JSONArray getServices(OBPOSApplications terminal) throws JSONException {
    [javac] ^
    [javac] symbol: class OBPOSApplications
    [javac] location: class MobileCoreLoginUtilsServlet
    [javac] /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java:286: error: cannot find symbol
    [javac] OBPOSApplications terminal = null;
    [javac] ^
    [javac] symbol: class OBPOSApplications
    [javac] location: class MobileCoreLoginUtilsServlet
    [javac] /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java:287: error: cannot find symbol
    [javac] OBCriteria<OBPOSApplications> qApp = OBDal.getInstance().createCriteria(
    [javac] ^
    [javac] symbol: class OBPOSApplications
    [javac] location: class MobileCoreLoginUtilsServlet
    [javac] /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java:288: error: cannot find symbol
    [javac] OBPOSApplications.class);
    [javac] ^
    [javac] symbol: class OBPOSApplications
    [javac] location: class MobileCoreLoginUtilsServlet
    [javac] /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java:289: error: cannot find symbol
    [javac] qApp.add(Restrictions.eq(OBPOSApplications.PROPERTY_SEARCHKEY, terminalName));
    [javac] ^
    [javac] symbol: variable OBPOSApplications
    [javac] location: class MobileCoreLoginUtilsServlet
    [javac] /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java:292: error: cannot find symbol
    [javac] List<OBPOSApplications> apps = qApp.list();
    [javac] ^
    [javac] symbol: class OBPOSApplications
    [javac] location: class MobileCoreLoginUtilsServlet
    [javac] /home/openbravo/3.0/bugs-pg-1/openbravo/erp/devel/pi/modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java:294: error: cannot find symbol
    [javac] terminal = ((OBPOSApplications) apps.get(0));
    [javac] ^
    [javac] symbol: class OBPOSApplications
    [javac] location: class MobileCoreLoginUtilsServlet
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 9 errors
No tags attached.
depends on backport 0031134RR15Q4 closed marvintm [Mobile Core] Some Code from POS is used in Mobile Core Module 
Issue History
2015-10-13 11:00dmiguelezNew Issue
2015-10-13 11:00dmiguelezAssigned To => Retail
2015-10-13 11:00dmiguelezRegression level => Production - Confirmed Stable
2015-10-13 11:00dmiguelezRegression date => 2015-07-16
2015-10-13 11:00dmiguelezRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3bfd5690abf1 [^]
2015-10-13 11:00dmiguelezTriggers an Emergency Pack => No
2015-10-13 11:09mtaalAssigned ToRetail => mtaal
2015-10-13 11:09mtaalStatusnew => scheduled
2015-10-14 01:01hgbotCheckin
2015-10-14 01:01hgbotNote Added: 0080993
2015-10-14 01:01hgbotStatusscheduled => resolved
2015-10-14 01:01hgbotResolutionopen => fixed
2015-10-14 01:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/acae1e48bf25c12a3db8e61b66bd96545c7986f2 [^]
2015-10-14 01:02hgbotCheckin
2015-10-14 01:02hgbotNote Added: 0080994
2015-10-14 01:02hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/acae1e48bf25c12a3db8e61b66bd96545c7986f2 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8d373138e7b6ed1e2817ca841acd24fe00415d26 [^]
2015-10-22 08:25mtaalReview Assigned To => migueldejuana
2015-10-22 12:42marvintmReview Assigned Tomigueldejuana => marvintm
2015-10-22 12:42marvintmStatusresolved => closed
2015-10-22 12:42marvintmFixed in Version => RR16Q1
2015-10-22 15:22migueldejuanaRelationship addeddepends on 0031178
2015-10-22 15:23migueldejuanaRelationship deleteddepends on 0031178
2015-11-02 15:49marvintmRegression levelProduction - Confirmed Stable => QA functional test

Notes
(0080993)
hgbot   
2015-10-14 01:01   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: acae1e48bf25c12a3db8e61b66bd96545c7986f2
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Oct 13 19:18:08 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/acae1e48bf25c12a3db8e61b66bd96545c7986f2 [^]

Fixes issue 31133: [Mobile Core] Some Code from POS is used in Mobile Core Module
Move code from the MobileCoreLoginUtilsServlet to its subclass in pos terminal

---
M src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java
---
(0080994)
hgbot   
2015-10-14 01:02   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8d373138e7b6ed1e2817ca841acd24fe00415d26
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Oct 13 19:18:53 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8d373138e7b6ed1e2817ca841acd24fe00415d26 [^]

Fixes issue 31133: [Mobile Core] Some Code from POS is used in Mobile Core Module
Move code from mobile core to posterminal to make use of the pos terminal concept

---
M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java
---