Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0031114 | Retail Modules | Web POS | public | 2015-10-08 18:30 | 2015-10-28 16:03 |
|
| Reporter | adrianromero | |
| Assigned To | adrianromero | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR16Q1 | |
| Merge Request Status | |
| Review Assigned To | marvintm |
| OBNetwork customer | No |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0031114: New approval message is not validated properly |
| Description | The new approval messages implemented in changeset https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b367392dc5bed7e651b440e3d65ecd5e46d49b94 [^] does not work properly with the function https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/b282d25d0fd0/web/org.openbravo.mobile.core/source/component/obpos-approval.js#l23 [^] that expects as approvalType an string or array of strings |
| Steps To Reproduce | Currently there is no code in POS that uses this new functionality.
Steps to try this with a preference created on the fly, using developer tools:
Execute the following:
OB.MobileApp.model.attributes.permissions.test_dummy = false;
OB.UTIL.Approval.requestApproval(OB.MobileApp.view.$.containerWindow.$.pointOfSale.model, 'test_dummy', function(approved){if(approved){alert('done');}});
>> Verify that the 'Supervisor Required' popup is shown.
OB.MobileApp.model.attributes.permissions.test_dummy = true;
>> Verify that now the 'done' alert is shown (test_dummy approval granted).
OB.UTIL.Approval.requestApproval(OB.MobileApp.view.$.containerWindow.$.pointOfSale.model, {
approval: 'test_dummy',
message: 'test_dummy',
params: []
}, function(approved){if(approved){alert('done');}});
>> ERROR: 'Supervisor Required' popup is shown, even if we have the permission for 'test_dummy'.
|
| Proposed Solution | see attached patch |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | feature request | 0027002 | | closed | ebecerra | Extend Approval dialog to allow show custom message on approval dialog. |
|
| Attached Files |  issue31114.diff (683) 2015-10-08 18:32
https://issues.openbravo.com/file_download.php?file_id=8546&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2015-10-08 18:30 | adrianromero | New Issue | |
| 2015-10-08 18:30 | adrianromero | Assigned To | => Retail |
| 2015-10-08 18:30 | adrianromero | OBNetwork customer | => No |
| 2015-10-08 18:30 | adrianromero | Triggers an Emergency Pack | => No |
| 2015-10-08 18:30 | adrianromero | Relationship added | related to 0027002 |
| 2015-10-08 18:32 | adrianromero | File Added: issue31114.diff | |
| 2015-10-09 08:41 | aaroncalero | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=9653#r9653 |
| 2015-10-19 18:57 | hgbot | Checkin | |
| 2015-10-19 18:57 | hgbot | Note Added: 0081100 | |
| 2015-10-19 18:57 | hgbot | Status | new => resolved |
| 2015-10-19 18:57 | hgbot | Resolution | open => fixed |
| 2015-10-19 18:57 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2aa4e1c6ba9093a8be2b8c781e0c05e670b2ee33 [^] |
| 2015-10-20 09:16 | marvintm | Assigned To | Retail => adrianromero |
| 2015-10-27 09:13 | adrianromero | Review Assigned To | => marvintm |
| 2015-10-28 16:03 | marvintm | Status | resolved => closed |
| 2015-10-28 16:03 | marvintm | Fixed in Version | => RR16Q1 |