Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031108ModulesSEPA Framework and Utilitiespublic2015-10-08 17:292015-10-13 14:25
Reportermaite 
Assigned Tovmromanos 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket38390
OBNetwork customerOBPS
Regression introduced in release
Summary0031108: Bank Instruction description should not contain new line (\n)
DescriptionBank Instruction description should not contain new line (\n)
Steps To Reproduce1. Register Payment Out document selecting any invoice and including GL Item line
2. Process payment and realize that Description contains 2 lines (including \n)
3. Register SEPA remittance and run "Select payments" process
4. Select previous payment and process remittance
5. Access Bank Instruction tab and realize that Description field also contains several lines. This is causing not accepted XML forma
Proposed SolutionaddRemittanceBankInstruction method in line 818 of REM_RemittanceProcess.java should treat payment.getDescription() to substitute \n character by " ", instead of use it directly
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-10-08 17:29maiteNew Issue
2015-10-08 17:29maiteAssigned To => Triage Finance
2015-10-08 17:29maiteResolution time => 1446073200
2015-10-08 17:29maiteSupport ticket => 38390
2015-10-08 17:29maiteOBNetwork customer => Yes
2015-10-08 17:30maiteIssue Monitored: networkb
2015-10-09 14:31vmromanosAssigned ToTriage Finance => vmromanos
2015-10-09 14:31vmromanosStatusnew => acknowledged
2015-10-13 09:28vmromanosStatusacknowledged => scheduled
2015-10-13 09:49vmromanosNote Added: 0080938
2015-10-13 09:49vmromanosCategorySEPA Credit Transfer Customer-to-Bank => SEPA Framework and Utilities
2015-10-13 09:49hgbotCheckin
2015-10-13 09:49hgbotNote Added: 0080939
2015-10-13 09:49hgbotStatusscheduled => resolved
2015-10-13 09:49hgbotResolutionopen => fixed
2015-10-13 09:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022/rev/762688fa87d8afd72bfdb71b3eac9c824b02db36 [^]
2015-10-13 09:59vmromanosNote Added: 0080940
2015-10-13 10:16hgbotCheckin
2015-10-13 10:16hgbotNote Added: 0080945
2015-10-13 12:33psanjuanNote Edited: 0080938bug_revision_view_page.php?bugnote_id=0080938#r9672
2015-10-13 13:49psanjuanNote Edited: 0080938bug_revision_view_page.php?bugnote_id=0080938#r9673
2015-10-13 13:50psanjuanNote Edited: 0080938bug_revision_view_page.php?bugnote_id=0080938#r9674
2015-10-13 13:56psanjuanNote Edited: 0080938bug_revision_view_page.php?bugnote_id=0080938#r9675
2015-10-13 14:01psanjuanNote Edited: 0080938bug_revision_view_page.php?bugnote_id=0080938#r9676
2015-10-13 14:05psanjuanNote Added: 0080977
2015-10-13 14:25psanjuanNote Added: 0080980
2015-10-13 14:25psanjuanStatusresolved => closed
2015-10-13 14:26psanjuanNote Edited: 0080977bug_revision_view_page.php?bugnote_id=0080977#r9678

Notes
(0080938)
vmromanos   
2015-10-13 09:49   
(edited on: 2015-10-13 14:01)
Test plan:

1. Register Payment Out document selecting any invoice and including GL Item line
2. Process payment and realize that Description contains 2 lines (including \n). For instance:
Invoice No.: 10000000
GL Item: Fee
3. Go to remittance window and create a new SEPA remittance "SEPA Credit Transfer", run "Select payments" process
4. Select previous payment and process remittance
5. Access Bank Instruction tab and realize that Description field also contains several lines.
6. Create remittance file.
7. Open it in a text editor and verify the description is merged into 1 line.
<Ustrd>Invoice No.: 10000000 GL Item: Fee</Ustrd>

Repeat same steps for a Payment IN including a GL Item and SEPA Direct Debit.
(0080939)
hgbot   
2015-10-13 09:49   
Repository: erp/pmods/org.openbravo.sepa.iso20022
Changeset: 762688fa87d8afd72bfdb71b3eac9c824b02db36
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Oct 13 09:45:16 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022/rev/762688fa87d8afd72bfdb71b3eac9c824b02db36 [^]

Fixed bug 31108: Implemented EPC Guidelines for the basic Latic character set.

First replace common characters (like á-->a, '\n'-->' ').
Then we remove any other character not in the following list to fulfill the EPC Guidelines:

a b c d e f g h i j k l m n o p q r s t u v w x y z
A B C D E F G H I J K L M N O P Q R S T U V W X Y Z
0 1 2 3 4 5 6 7 8 9
/ - ? : ( ) . , ' +
Space

---
M src-db/database/sourcedata/AD_MODULE.xml
M src/org/openbravo/sepa/iso20022/util/SEPAUtil.java
A doc/EPC217-08 Best Practices SEPA Requirements for Character Set SSG.pdf
A doc/EPC217-08-SEPA-Conversion-Table.xls
---
(0080940)
vmromanos   
2015-10-13 09:59   
Fixed in SEPA Framework and Utilities 1.0.7 (or higher)
(0080945)
hgbot   
2015-10-13 10:16   
Repository: erp/pmods/org.openbravo.sepa.iso20022
Changeset: e7acef8700ea1cd63b1a978f1d26d30d19939e99
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Oct 13 10:14:51 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022/rev/e7acef8700ea1cd63b1a978f1d26d30d19939e99 [^]

Related to issue 31108: replace more characters as per recommendations,
Fixed - in regext

---
M src/org/openbravo/sepa/iso20022/util/SEPAUtil.java
---
(0080977)
psanjuan   
2015-10-13 14:05   
(edited on: 2015-10-13 14:26)
Test Plan above verified.
Issue can be closed.

Documentation updated. See:
http://wiki.openbravo.com/wiki/SEPA_Direct_Debit_Customer-to-Bank/User_Documentation#EPC_Guidelines [^]

http://wiki.openbravo.com/wiki/SEPA_Credit_Transfer_Customer-to-Bank/User_Documentation#EPC_Guidelines [^]
(0080980)
psanjuan   
2015-10-13 14:25   
Issue closed.