Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0031070 | Openbravo ERP | A. Platform | public | 2015-10-06 17:01 | 2015-11-23 21:17 |
|
| Reporter | caristu | |
| Assigned To | caristu | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | 3.0PR16Q1 | Fixed in Version | 3.0PR16Q1 | |
| Merge Request Status | |
| Review Assigned To | alostale |
| OBNetwork customer | No |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0031070: Deleting pop-up is never closed under some circumnstances |
| Description | Deleting pop-up is never closed if we click on edit record and then we click on the delete button of the toolbar. |
| Steps To Reproduce | 1) Go to the Sales Invoice window
2) Create a new record in the header
3) Go to the Lines tab, and create a new record
4) Still on the Lines tab, in grid view, click on the edit icon
5) Without saving the record, click directly on the delete button of the toolbar
Notice that the record is deleted but the deleting pop-up is not closed |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  popUpNotHidden.png (46,669) 2015-10-06 17:02
https://issues.openbravo.com/file_download.php?file_id=8529&type=bug
|
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2015-10-06 17:01 | caristu | New Issue | |
| 2015-10-06 17:01 | caristu | Assigned To | => platform |
| 2015-10-06 17:01 | caristu | OBNetwork customer | => No |
| 2015-10-06 17:01 | caristu | Modules | => Core |
| 2015-10-06 17:01 | caristu | Triggers an Emergency Pack | => No |
| 2015-10-06 17:02 | caristu | File Added: popUpNotHidden.png | |
| 2015-10-06 17:02 | caristu | Issue Monitored: networkb | |
| 2015-10-07 08:31 | alostale | Status | new => acknowledged |
| 2015-10-07 08:31 | alostale | Target Version | => 3.0PR16Q1 |
| 2015-11-11 11:33 | alostale | Priority | high => urgent |
| 2015-11-11 12:26 | caristu | Assigned To | platform => caristu |
| 2015-11-11 12:26 | caristu | Status | acknowledged => scheduled |
| 2015-11-11 16:43 | caristu | Review Assigned To | => alostale |
| 2015-11-11 16:43 | caristu | Issue Monitored: alostale | |
| 2015-11-11 16:44 | hgbot | Checkin | |
| 2015-11-11 16:44 | hgbot | Note Added: 0081719 | |
| 2015-11-11 16:44 | hgbot | Status | scheduled => resolved |
| 2015-11-11 16:44 | hgbot | Resolution | open => fixed |
| 2015-11-11 16:44 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/b59a2f4e4a114754328a34722d4f7c64c56ade2e [^] |
| 2015-11-16 12:02 | alostale | Note Added: 0081867 | |
| 2015-11-16 12:02 | alostale | Status | resolved => closed |
| 2015-11-16 12:02 | alostale | Fixed in Version | => 3.0PR16Q1 |
| 2015-11-23 21:17 | hudsonbot | Checkin | |
| 2015-11-23 21:17 | hudsonbot | Note Added: 0082198 | |
|
Notes |
|
|
(0081719)
|
|
hgbot
|
|
2015-11-11 16:44
|
|
Repository: erp/devel/pi
Changeset: b59a2f4e4a114754328a34722d4f7c64c56ade2e
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Nov 11 16:42:20 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b59a2f4e4a114754328a34722d4f7c64c56ade2e [^]
fixes issue 31070: Deleting pop-up is never closed under some circumnstances
The problem was that when removing a record that is being editing, the updateTabTitle function was crashing when trying to access to this.viewGrid.getEditForm().isNew because this.viewGrid.getEditForm() is undefined at that point.
Apart from this, the isEditingGrid is not restored to false when removing a record which is being edited. This caused new errors after removing, because the view is not marked as in non-editing state. For this reason, now the isEditingGrid value is set to false for this case also.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
|
|
|
|
|
code reviewed
tested:
- Deletion in grid while editing without saving
- Deletion in grid not editing
- Deletion in grid multiple record
- Deletion in form |
|
|
|
|
|