Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031055Openbravo ERPB. User interfacepublic2015-09-26 02:192015-10-20 11:11
Reporterrbianchini 
Assigned ToNaroaIriarte 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0PR15Q3.1 
Target Version3.0PR15Q3.2Fixed in Version3.0PR15Q3.2 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date
Regression introduced in release3.0PR15Q2
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031055: When add a second new line in goods movements, the product field is already filled
DescriptionWhen you add the first new line (in form mode) in good movements, all fields are empty and when you select the product some fields are loaded, but when yos save the first line (Ctrl+s) and create a new line (the second one) with Ctrl+d, the product field is filled with the product from line one (or with the first product in the list). This is confusing for the user and the partner reports security problems.
Steps To Reproduce1 - Log in ERP
2 - Go to Goods Movements window
3 - Create a new header
4 - Create a new line in form view and DO NOT save it
5 - With Ctrl+d or with the new button create other line
6 - Observes that almost fields are already filled with the first line's product
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0030940 closed NaroaIriarte When add a second new line in goods movements, the product field is already filled 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-10-06 09:27alostaleTypedefect => backport
2015-10-06 09:27alostaleTarget Version => 3.0PR15Q3.3
2015-10-13 10:49NaroaIriarteTarget Version3.0PR15Q3.3 => 3.0PR15Q3.2
2015-10-14 15:54hgbotCheckin
2015-10-14 15:54hgbotNote Added: 0081011
2015-10-14 15:54hgbotStatusscheduled => resolved
2015-10-14 15:54hgbotResolutionopen => fixed
2015-10-14 15:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q3.2/rev/e46c445f88e608d08f5711d621a67be445f03bb9 [^]
2015-10-14 15:58NaroaIriarteReview Assigned To => alostale
2015-10-14 15:58NaroaIriarteAssigned Toplatform => NaroaIriarte
2015-10-15 09:18NaroaIriarteReview Assigned Toalostale => AugustoMauch
2015-10-15 10:33hgbotCheckin
2015-10-15 10:33hgbotNote Added: 0081036
2015-10-20 11:11AugustoMauchNote Added: 0081114
2015-10-20 11:11AugustoMauchStatusresolved => closed
2015-10-20 11:11AugustoMauchFixed in Version => 3.0PR15Q3.2

Notes
(0081011)
hgbot   
2015-10-14 15:54   
Repository: erp/backports/3.0PR15Q3.2
Changeset: e46c445f88e608d08f5711d621a67be445f03bb9
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Wed Oct 14 15:45:22 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q3.2/rev/e46c445f88e608d08f5711d621a67be445f03bb9 [^]

Fixed issue 31055: Create a new record in a form was not working fine.

The problem was that, if you create a new record in form view, and after fulfilling the form, you
click in the create a new record in a form button without previously saving the firstly created record,
it was not working fine. In Goods Movements lines tab, for example, the value of the product chosen in
the first record was shown. That wasn't correct, the product should be empty.

The problem was in the "ob-standard-view-datasource.js" the value map cache was being invalidated.

To fix this, some clases have been changed.
In the "ob-standard-view.js" in the "newDocument" function the parameters the isNewDocument parameter
has been added and it is set to true.
This parameter is passed to the request for being able to take it in the class "ob-standard-view-datasource.js"
and to use it in the logic that invalidates the value map cache.
Now, if this parameter is set to true, the value map cache is not invalidated.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view-datasource.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
---
(0081036)
hgbot   
2015-10-15 10:33   
Repository: erp/backports/3.0PR15Q3.2
Changeset: 7cedd4cac8cee407d0489ae01a691175121e7580
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Thu Oct 15 10:04:13 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q3.2/rev/7cedd4cac8cee407d0489ae01a691175121e7580 [^]

Related with issue 31055: The condition has been changed.

The if condition which handles the invalidation of the value maps cache has been modified for getting the correct behaviour.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view-datasource.js
---
(0081114)
AugustoMauch   
2015-10-20 11:11   
Code reviewed and verified in [1]@7cedd4cac8ce

[1] https://code.openbravo.com/erp/backports/3.0PR15Q3.2 [^]