Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031046Retail ModulesOffline Modepublic2015-10-05 15:492015-10-23 16:51
Reporterplujan 
Assigned Tomigueldejuana 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in VersionRR16Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelPackaging and release
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031046: [RR15Q4] Uncaught exception while browsing pending cashups
DescriptionWhile creating a cashup in offline mode, the data is kept pending to synchronise until connection is back.
Browsing the data pending to synchronise shows an uncaught exception "Type Error: Cannot Read property 'creationDate' of undefined"
This flow is working fine in RR15Q3.1
Steps To Reproduce1. Login online as vallblanca user
2. Unplug the network cable to get no Internet connection
3. From the top-left menu, choose Cash Up
4. Add some money to Cash, and continue till the end of the process
5. After the success message, since we are offline, the data will be kept to later synchronise.
6. Click the to left menu and seek for the "pending to synchronise" option
7. A pop up will open, showing a Cash Up. Click the record.
8. [Expected] A date identifying the Cash Up (see attached screenshot of RRQ3.1)
   [Got] An uncaugt exception "TypeError: Cannot read property 'creationDate' of undefined (see attched screenshot of RRQ4)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0031047 closed migueldejuana [RR15Q4] During the automatic synchronization executed when it is detected client is online again, uncaught exceptions are shown 
depends on backport 0031084RR15Q4 closed marvintm [RR15Q4] Uncaught exception while browsing pending cashups 
Attached Filespng RR15Q3.1.png (66,156) 2015-10-05 15:50
https://issues.openbravo.com/file_download.php?file_id=8521&type=bug
png

png RR15Q4_Error.png (167,330) 2015-10-05 15:55
https://issues.openbravo.com/file_download.php?file_id=8522&type=bug
png

diff issue31046.diff (4,447) 2015-10-13 16:42
https://issues.openbravo.com/file_download.php?file_id=8559&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-10-05 15:49plujanNew Issue
2015-10-05 15:49plujanAssigned To => Retail
2015-10-05 15:49plujanFile Added: RR15Q4_Error.png
2015-10-05 15:49plujanRegression level => Packaging and release
2015-10-05 15:49plujanTriggers an Emergency Pack => No
2015-10-05 15:50plujanFile Added: RR15Q3.1.png
2015-10-05 15:52plujanFile Deleted: RR15Q4_Error.png
2015-10-05 15:55plujanFile Added: RR15Q4_Error.png
2015-10-05 17:41OrekariaTarget Version => RR15Q4
2015-10-06 12:08OrekariaStatusnew => acknowledged
2015-10-06 12:20migueldejuanaAssigned ToRetail => migueldejuana
2015-10-07 10:37migueldejuanaReview Assigned To => mtaal
2015-10-07 14:10migueldejuanaStatusacknowledged => scheduled
2015-10-08 16:56hgbotCheckin
2015-10-08 16:56hgbotNote Added: 0080895
2015-10-08 16:56hgbotStatusscheduled => resolved
2015-10-08 16:56hgbotResolutionopen => fixed
2015-10-08 16:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d237f6f364cfbe9f171d663e3edd7cd4a47fe538 [^]
2015-10-08 16:57hgbotCheckin
2015-10-08 16:57hgbotNote Added: 0080897
2015-10-08 16:57hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d237f6f364cfbe9f171d663e3edd7cd4a47fe538 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f0d13fc6928ca0f7445590c5dad8550038fb8d4d [^]
2015-10-13 13:58migueldejuanaNote Added: 0080975
2015-10-13 13:58migueldejuanaStatusresolved => new
2015-10-13 13:58migueldejuanaResolutionfixed => open
2015-10-13 16:42migueldejuanaFile Added: issue31046.diff
2015-10-13 17:54OrekariaTarget VersionRR15Q4 =>
2015-10-15 12:40hgbotCheckin
2015-10-15 12:40hgbotNote Added: 0081038
2015-10-15 12:40hgbotStatusnew => resolved
2015-10-15 12:40hgbotResolutionopen => fixed
2015-10-15 12:40hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f0d13fc6928ca0f7445590c5dad8550038fb8d4d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0c3f965527d803720a19dd5691679b1f89be6727 [^]
2015-10-22 11:38marvintmReview Assigned Tomtaal => marvintm
2015-10-22 11:38marvintmStatusresolved => closed
2015-10-22 11:38marvintmFixed in Version => RR16Q1
2015-10-22 13:23migueldejuanaRelationship addedrelated to 0031047
2015-10-23 16:51guilleaerNote Added: 0081269
2015-10-26 08:50guilleaerNote Edited: 0081269bug_revision_view_page.php?bugnote_id=0081269#r9851

Notes
(0080895)
hgbot   
2015-10-08 16:56   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: d237f6f364cfbe9f171d663e3edd7cd4a47fe538
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Oct 07 08:47:59 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d237f6f364cfbe9f171d663e3edd7cd4a47fe538 [^]

Fixed issue 0031046: [RR15Q4] Uncaught exception while browsing pending cashups

- Do not send to message table Cashups without objToSend

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0080897)
hgbot   
2015-10-08 16:57   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f0d13fc6928ca0f7445590c5dad8550038fb8d4d
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Oct 07 08:48:51 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f0d13fc6928ca0f7445590c5dad8550038fb8d4d [^]

Fixed issue 0031046: [RR15Q4] Uncaught exception while browsing pending cashups

- Do not send to message table Cash uos without objToSend

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0080975)
migueldejuana   
2015-10-13 13:58   
Backout

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/227c2786d6bf [^]

https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/af19bf1b8bde [^]
(0081038)
hgbot   
2015-10-15 12:40   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 0c3f965527d803720a19dd5691679b1f89be6727
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Oct 15 12:38:43 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0c3f965527d803720a19dd5691679b1f89be6727 [^]

Fixed issue 0031046: [RR15Q4] Uncaught exception while browsing pending cashups

- Do not process request without data

---
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
---
(0081269)
guilleaer   
2015-10-23 16:51   
(edited on: 2015-10-26 08:50)
For me this issue is not working fine in live builds following the steps to reproduce.

I have done a cashup to clean
Then I have created a order and completed it
Then I have gone offline
Then I have done a cashup

Returning to POS window, When Models to sync popup is opened the system says that there are 2 cashups pending to be sync (https://dl.dropboxusercontent.com/u/27152266/Screenshots/GAL_screenshoot_Selection_149.jpg [^])
and looking at the detail I can see that 2 lines are shown (https://dl.dropboxusercontent.com/u/27152266/Screenshots/GAL_screenshoot_Selection_148.jpg [^])