Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031035Retail ModulesWeb POSpublic2015-10-02 14:192015-10-09 13:03
Reporteraaroncalero 
Assigned Todbaz 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q4Fixed in VersionRR16Q1 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customer
Support ticket
Regression levelCode review
Regression date
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/def6db59d486662f86abaef2ac435dca19c5db5b [^]
Triggers an Emergency PackNo
Summary0031035: Deprecation messages when logging in web pos
DescriptionWarning/Deprecation messages are shown on the javascript console, related to the OBPOS_PreCreateNewReceipt and OBPOS_PostCreateNewReceipt hooks.
These hooks are using the old hookManager API.
Steps To ReproduceLogin in web pos.
Create an empty receipt.
Verify that the following messages are shown on the browser console:
adead8f74bf0fa2fef815f78f78c7f66_WebPOS.js:2366 Deprecated (since RR14Q4): 'OB.MobileApp.model.hookManager' is a child of the model of the terminal. Please use 'OB.UTIL.HookManager' instead. More info: http://wiki.openbravo.com/wiki/How_to_Add_Hooks. [^] Hook: 'OBPOS_PreCreateNewReceipt'; line: Object.hookManager.executeHooks (https://livebuilds.openbravo.com/retail_pi_pgsql/web/js/gen/adead8f74bf0fa2fef815f78f78c7f66_WebPOS.js:5413:14 [^]) (*,+)
2015-10-02 14:17:49.018 adead8f74bf0fa2fef815f78f78c7f66_WebPOS.js:2366 Deprecated (since RR14Q4): 'OB.MobileApp.model.hookManager' is a child of the model of the terminal. Please use 'OB.UTIL.HookManager' instead. More info: http://wiki.openbravo.com/wiki/How_to_Add_Hooks. [^] Hook: 'OBPOS_PostAddNewReceipt'; line: Object.hookManager.executeHooks (https://livebuilds.openbravo.com/retail_pi_pgsql/web/js/gen/adead8f74bf0fa2fef815f78f78c7f66_WebPOS.js:5413:14 [^]) (*,+)
Proposed SolutionReplace the old API calls:
OB.MobileApp.model.hookManager.executeHooks('OBPOS_PreCreateNewReceipt', {
OB.MobileApp.model.hookManager.executeHooks('OBPOS_PostAddNewReceipt', {
with:
OB.UTIL.HookManager.executeHooks('OBPOS_PreCreateNewReceipt', {
OB.UTIL.HookManager.executeHooks('OBPOS_PostAddNewReceipt', {
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0031037RR15Q4 closed marvintm Deprecation messages when logging in web pos 
caused by defect 0030208 closed guilleaer create a hook when receipt is created in webpos 
Attached Files? 31035.export (1,265) 2015-10-05 08:06
https://issues.openbravo.com/file_download.php?file_id=8516&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-10-02 14:19aaroncaleroNew Issue
2015-10-02 14:19aaroncaleroAssigned To => Retail
2015-10-02 14:19aaroncaleroResolution time => 1444341600
2015-10-02 14:19aaroncaleroTriggers an Emergency Pack => No
2015-10-02 16:01OrekariaReview Assigned To => Orekaria
2015-10-02 16:01OrekariaRelationship addedcaused by 0030208
2015-10-02 16:02OrekariaRegression level => Code review
2015-10-02 16:02OrekariaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/def6db59d486662f86abaef2ac435dca19c5db5b [^]
2015-10-02 16:02OrekariaAssigned ToRetail => guilleaer
2015-10-02 16:08OrekariaStatusnew => scheduled
2015-10-02 16:10OrekariaResolution time1444341600 =>
2015-10-05 08:06guilleaerFile Added: 31035.export
2015-10-07 11:00avicenteIssue Monitored: avicente
2015-10-07 12:11ageteIssue Monitored: agete
2015-10-07 13:14dbazAssigned Toguilleaer => dbaz
2015-10-08 18:30OrekariaTarget Version => RR15Q4
2015-10-08 23:53hgbotCheckin
2015-10-08 23:53hgbotNote Added: 0080908
2015-10-08 23:53hgbotStatusscheduled => resolved
2015-10-08 23:53hgbotResolutionopen => fixed
2015-10-08 23:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/96286d7ae2369fd01c0f2794ef3378a92bef1148 [^]
2015-10-09 13:02OrekariaStatusresolved => closed
2015-10-09 13:02OrekariaFixed in Version => pi
2015-10-09 13:03OrekariaFixed in Versionpi => RR16Q1

Notes
(0080908)
hgbot   
2015-10-08 23:53   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 96286d7ae2369fd01c0f2794ef3378a92bef1148
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Oct 05 08:00:36 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/96286d7ae2369fd01c0f2794ef3378a92bef1148 [^]

Fixed issue 31035: Hooks which were created using an old API now are using the current API

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---