Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031031Openbravo ERPZ. Otherspublic2015-10-01 13:402015-12-15 13:34
Reportermaite 
Assigned Toaferraz 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q4Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031031: Credit consumed although payment is not completed due to "payment currency should map business partner currency" error
DescriptionCredit consumed although payment is not completed due to "payment currency should map business partner currency" error
Steps To Reproduce1. Register Payment Out for bebidas alegres and set generated credit=150. Process payment
2. Register Purchase Invoice for bebidas alegres, add any line and process. Do NOT consume credit when processing invoice
3. Access Business Partner window and run "Set new currency" process. Select MXN currency, check "set amount" option and set 200
4. Register Payment Out for bebidas alegres, run "Add details", select credit to be consumed and pending invoice
5. Process payment and error "For credit generation and/or credit consumption payment currency should map business partner currency: MXN" will be raised
6. Run "add details" rocess again and realize that available credit is not 150 but invoice amount has been substracted
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 00310063.0PR16Q1 closed aferraz Credit consumed although payment is not completed due to "payment currency should map business partner currency" error 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-10-02 13:31vmromanosTypedefect => backport
2015-10-02 13:31vmromanosTarget Version3.0PR16Q1 => 3.0PR15Q4
2015-10-05 11:28hgbotCheckin
2015-10-05 11:28hgbotNote Added: 0080814
2015-10-05 11:28hgbotStatusscheduled => resolved
2015-10-05 11:28hgbotResolutionopen => fixed
2015-10-05 11:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q4/rev/4037171411fefff82c3924948db9104c158fd1c0 [^]
2015-10-05 11:32vmromanosReview Assigned To => vmromanos
2015-10-05 11:32vmromanosNote Added: 0080820
2015-10-05 11:32vmromanosStatusresolved => closed
2015-12-15 13:34eugeniIssue Monitored: eugeni

Notes
(0080814)
hgbot   
2015-10-05 11:28   
Repository: erp/backports/3.0PR15Q4
Changeset: 4037171411fefff82c3924948db9104c158fd1c0
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Oct 02 12:24:48 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q4/rev/4037171411fefff82c3924948db9104c158fd1c0 [^]

Fixes issue 31031: Credit consumed although payment not completed

When consuming a credit with a currency different than Business Partner's currency, an error is shown but credit was also consumed, which was wrong.
Now, this check will be also done before consuming credit in AddPaymentActionHandler addCredit method, as it was done in FIN_PaymentProcess doProcessPayment method.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java
---
(0080820)
vmromanos   
2015-10-05 11:32   
Code review + testing OK