Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031026Openbravo ERP04. Warehouse managementpublic2015-10-02 12:262015-11-23 21:16
ReporterVictorVillar 
Assigned Toaferraz 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket38014
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031026: wrong warehouse in the lines of the inventory amount update
Descriptionwrong warehouse in the lines of the inventory amount update.
Steps To ReproduceAs group admin role,
   Go to Inventory Amount Update
     Create a new for España.
  Lines tab:
     select the product Zumo de Naranja
Save it.
   In grid mode realise that the Warehouse field is filled and appears España Región norte and the on hand qty is: 523300 which is the sum between Norte and Sur warehouses.

Warehouse field is something that is displayed only when the Costing rule is defined as Warehouse dimension so in other case this field should be blank.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00310363.0PR16Q1 closed aferraz Wrong on hand quantity calculation in Inventory Amount Update 
related to defect 0031041 closed aferraz The inventory amount update is not working fine under some circunstancies 
related to defect 00310693.0PR16Q1 closed aferraz Wrong cost calculation using inventory amount update caused by remaining valuation 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-10-02 12:26VictorVillarNew Issue
2015-10-02 12:26VictorVillarAssigned To => Triage Finance
2015-10-02 12:26VictorVillarOBNetwork customer => Yes
2015-10-02 12:26VictorVillarModules => Core
2015-10-02 12:26VictorVillarSupport ticket => 38014
2015-10-02 12:26VictorVillarResolution time => 1444082400
2015-10-02 12:26VictorVillarTriggers an Emergency Pack => No
2015-10-02 12:27VictorVillarIssue Monitored: networkb
2015-10-05 11:42aferrazAssigned ToTriage Finance => aferraz
2015-10-05 12:44VictorVillarRelationship addedrelated to 0031036
2015-10-05 12:44VictorVillarRelationship addedrelated to 0031041
2015-10-05 13:45aferrazStatusnew => scheduled
2015-10-06 12:48psanjuanNote Added: 0080842
2015-10-06 13:55psanjuanNote Edited: 0080842bug_revision_view_page.php?bugnote_id=0080842#r9619
2015-10-06 13:57psanjuanNote Edited: 0080842bug_revision_view_page.php?bugnote_id=0080842#r9620
2015-10-06 16:11VictorVillarRelationship addedrelated to 0031069
2015-10-08 14:16hgbotCheckin
2015-10-08 14:16hgbotNote Added: 0080888
2015-10-08 14:16hgbotStatusscheduled => resolved
2015-10-08 14:16hgbotResolutionopen => fixed
2015-10-08 14:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8d000060c64f62322838aaaa3f7278dd6072bb82 [^]
2015-10-08 15:42psanjuanNote Edited: 0080842bug_revision_view_page.php?bugnote_id=0080842#r9647
2015-10-09 09:39psanjuanNote Edited: 0080842bug_revision_view_page.php?bugnote_id=0080842#r9654
2015-10-09 09:41psanjuanNote Edited: 0080842bug_revision_view_page.php?bugnote_id=0080842#r9655
2015-10-09 10:17psanjuanNote Edited: 0080842bug_revision_view_page.php?bugnote_id=0080842#r9660
2015-10-09 13:59hgbotCheckin
2015-10-09 13:59hgbotNote Added: 0080919
2015-10-09 14:59psanjuanNote Edited: 0080842bug_revision_view_page.php?bugnote_id=0080842#r9665
2015-10-09 15:00psanjuanNote Edited: 0080842bug_revision_view_page.php?bugnote_id=0080842#r9666
2015-10-09 15:00psanjuanNote Added: 0080923
2015-10-09 15:03dmiguelezReview Assigned To => dmiguelez
2015-10-09 15:03dmiguelezNote Added: 0080924
2015-10-09 15:03dmiguelezStatusresolved => closed
2015-11-23 21:16hudsonbotCheckin
2015-11-23 21:16hudsonbotNote Added: 0082119
2015-11-23 21:16hudsonbotCheckin
2015-11-23 21:16hudsonbotNote Added: 0082123

Notes
(0080842)
psanjuan   
2015-10-06 12:48   
(edited on: 2015-10-09 15:00)
Before installing the patch:

In F&B International Group, go to Costing Rule window.

Verify that the valid costing rule for F&B España does not have Warehouse Dimension selected.

Go to Product Window and search for "Zumo de Naranja Bio 0.33L" Product.

Go to Transaction tab and sum up Movement Quantity column, therefore you get below results:
Storage Bin RN-X-X-X = 454.200 (linked to Wh España Region Norte)
Storage Bin RS-X-X-X = 69.100 (Linkde to Wh España Region Sur)
Total quantity on hand = 523.300

Launch Stock Report and verify that data above are correct.

Go to Inventory Amount Update window and create a new one for F&B España, dated on current date, that is 09-10-2015, go to lines tab and in "form" view create a new record, select Zumo de Naranja product.

Realize that Warehouse field is not shown and the field On hand Qty shows 523.300 which is correct. Save

Change to Grid view and realize that Warehouse field is shown, showing España Region Norte which is not correct.

Delete the line and the inventory amount update.

Apply the patch.

Go to Inventory Amount Update window and create a new one for F&B España, go to lines tab and in "form" view create a new record, select Zumo de Naranja product.

Realize that Warehouse field is not shown now and the field On hand Qty shows 523.300 which is correct. Save

Change to Grid view and realize that Warehouse field is shown but empty which is correct.

Delete the line and the inventory amount update.

Go to Costing rule window, and create a new one for F&B España org by setting Warehouse as a costing dimension. Validate Costing Rule. Starting date of this new costing rule, is current date, that is 09-10-2015 HH:MM:SS

After that go to Inventory Amount Update window, create a new one dated on 09-10-2015

Go to lines tab and create a new record in form view.

Realize that warehouse field is now shown, therefore a warehouse can be selected.

Select product "Zumo de Naranja Bio 0.33L" and WH España Region Norte. An on hand quatity = 454.200 is shown, which is correct.

Change the warehouse to España Region Sur, an on hand quantity = 69.100 is shown, which is correct.
(0080888)
hgbot   
2015-10-08 14:16   
Repository: erp/devel/pi
Changeset: 8d000060c64f62322838aaaa3f7278dd6072bb82
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Oct 08 14:15:32 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8d000060c64f62322838aaaa3f7278dd6072bb82 [^]

Fixes issue 31026: Wrong warehouse in Inventory Amount Update Lines

When current costing rule does not have Warehouse Dimension flag activated, warehouse field should be empty in Inventory Amount Update Lines.
In this case, SL_InvAmtUpd_ProductRefDate callout will return a null warehouseId.
Document date and Reference date references in Inventory Amount update have been changed from Date to DateTime, to get the correct value when checking the current costing rule.
Reference date will also have Document date value as default value instead of current date.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src/org/openbravo/erpCommon/ad_callouts/SL_InvAmtUpd_ProductRefDate.java
---
(0080919)
hgbot   
2015-10-09 13:59   
Repository: erp/devel/pi
Changeset: b75349aa9d0f6167e75fe10b376e84fdada77f28
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Oct 09 13:57:19 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b75349aa9d0f6167e75fe10b376e84fdada77f28 [^]

Related to issue 31026: Change from DateTime to Absolute DateTime

Document date and Reference date references in Inventory Amount update have been changed from DateTime to Absolute DateTime, to avoid UTC conversion.
Also dateTimeFormat.java should be used instead of dateFormat.java for date formating.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src/org/openbravo/erpCommon/ad_callouts/SL_InvAmtUpd_ProductRefDate.java
---
(0080923)
psanjuan   
2015-10-09 15:00   
Test plan above verified, issue can be closed.
(0080924)
dmiguelez   
2015-10-09 15:03   
Code Review + Testing Ok
(0082119)
hudsonbot   
2015-11-23 21:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test
(0082123)
hudsonbot   
2015-11-23 21:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test