Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031023Openbravo ERPZ. Otherspublic2015-10-01 13:402015-10-05 11:31
Reportermaite 
Assigned Toaferraz 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q3.2Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket38625
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031023: Credit consumed although payment is not completed due to "payment currency should map business partner currency" error
DescriptionCredit consumed although payment is not completed due to "payment currency should map business partner currency" error
Steps To Reproduce1. Register Payment Out for bebidas alegres and set generated credit=150. Process payment
2. Register Purchase Invoice for bebidas alegres, add any line and process. Do NOT consume credit when processing invoice
3. Access Business Partner window and run "Set new currency" process. Select MXN currency, check "set amount" option and set 200
4. Register Payment Out for bebidas alegres, run "Add details", select credit to be consumed and pending invoice
5. Process payment and error "For credit generation and/or credit consumption payment currency should map business partner currency: MXN" will be raised
6. Run "add details" rocess again and realize that available credit is not 150 but invoice amount has been substracted
Proposed Solution
Additional Information
TagsApproved
Relationships
blocks defect 00310063.0PR16Q1 closed aferraz Credit consumed although payment is not completed due to "payment currency should map business partner currency" error 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-10-02 12:18aferrazTypedefect => backport
2015-10-02 12:18aferrazTarget Version3.0PR16Q1 => 3.0PR15Q3.2
2015-10-02 12:19aferrazTag Attached: Approved
2015-10-05 11:29hgbotCheckin
2015-10-05 11:29hgbotNote Added: 0080816
2015-10-05 11:29hgbotStatusscheduled => resolved
2015-10-05 11:29hgbotResolutionopen => fixed
2015-10-05 11:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q3.2/rev/e9095a803ab6966d1cd38fbd5d4cde211f944996 [^]
2015-10-05 11:31vmromanosReview Assigned To => vmromanos
2015-10-05 11:31vmromanosNote Added: 0080818
2015-10-05 11:31vmromanosStatusresolved => closed

Notes
(0080816)
hgbot   
2015-10-05 11:29   
Repository: erp/backports/3.0PR15Q3.2
Changeset: e9095a803ab6966d1cd38fbd5d4cde211f944996
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Oct 02 12:24:48 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q3.2/rev/e9095a803ab6966d1cd38fbd5d4cde211f944996 [^]

Fixes issue 31023: Credit consumed although payment not completed

When consuming a credit with a currency different than Business Partner's currency, an error is shown but credit was also consumed, which was wrong.
Now, this check will be also done before consuming credit in AddPaymentActionHandler addCredit method, as it was done in FIN_PaymentProcess doProcessPayment method.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java
---
(0080818)
vmromanos   
2015-10-05 11:31   
Code review + testing OK