Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031006Openbravo ERPZ. Otherspublic2015-10-01 13:402015-11-23 21:16
Reportermaite 
Assigned Toaferraz 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q1Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031006: Credit consumed although payment is not completed due to "payment currency should map business partner currency" error
DescriptionCredit consumed although payment is not completed due to "payment currency should map business partner currency" error
Steps To Reproduce1. Register Payment Out for bebidas alegres and set generated credit=150. Process payment
2. Register Purchase Invoice for bebidas alegres, add any line and process. Do NOT consume credit when processing invoice
3. Access Business Partner window and run "Set new currency" process. Select MXN currency, check "set amount" option and set 200
4. Register Payment Out for bebidas alegres, run "Add details", select credit to be consumed and pending invoice
5. Process payment and error "For credit generation and/or credit consumption payment currency should map business partner currency: MXN" will be raised
6. Run "add details" rocess again and realize that available credit is not 150 but invoice amount has been substracted
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00310233.0PR15Q3.2 closed aferraz Credit consumed although payment is not completed due to "payment currency should map business partner currency" error 
depends on backport 00310243.0PR15Q2.6 closed aferraz Credit consumed although payment is not completed due to "payment currency should map business partner currency" error 
depends on backport 00310313.0PR15Q4 closed aferraz Credit consumed although payment is not completed due to "payment currency should map business partner currency" error 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-10-01 13:40maiteNew Issue
2015-10-01 13:40maiteAssigned To => Triage Finance
2015-10-01 13:40maiteModules => Core
2015-10-01 13:40maiteResolution time => 1446505200
2015-10-01 13:40maiteTriggers an Emergency Pack => No
2015-10-01 13:40maiteIssue Monitored: networkb
2015-10-02 12:17aferrazAssigned ToTriage Finance => aferraz
2015-10-02 12:18aferrazStatusnew => scheduled
2015-10-02 12:38aferrazNote Added: 0080803
2015-10-02 13:30vmromanosStatusscheduled => acknowledged
2015-10-02 13:31vmromanosStatusacknowledged => scheduled
2015-10-05 11:28hgbotCheckin
2015-10-05 11:28hgbotNote Added: 0080815
2015-10-05 11:28hgbotStatusscheduled => resolved
2015-10-05 11:28hgbotResolutionopen => fixed
2015-10-05 11:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2671931ccb1ae3a0908e2eac9d6bb7ebf4ee2138 [^]
2015-10-05 11:32vmromanosReview Assigned To => vmromanos
2015-10-05 11:32vmromanosNote Added: 0080821
2015-10-05 11:32vmromanosStatusresolved => closed
2015-11-23 21:16hudsonbotCheckin
2015-11-23 21:16hudsonbotNote Added: 0082109

Notes
(0080803)
aferraz   
2015-10-02 12:38   
1. Register Payment Out for bebidas alegres and set generated credit=150. Process payment
2. Register Purchase Invoice for bebidas alegres, add any line and process. Do NOT consume credit when processing invoice
3. Access Business Partner window and run "Set new currency" process. Select MXN currency, check "set amount" option and set 200
4. Register Payment Out for bebidas alegres, run "Add details", select credit to be consumed and pending invoice
5. Process payment and error "For credit generation and/or credit consumption payment currency should map business partner currency: MXN" will be raised
6. Run "add details" process again and realize that available credit is still being 150
(0080815)
hgbot   
2015-10-05 11:28   
Repository: erp/devel/pi
Changeset: 2671931ccb1ae3a0908e2eac9d6bb7ebf4ee2138
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Oct 02 12:24:48 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2671931ccb1ae3a0908e2eac9d6bb7ebf4ee2138 [^]

Fixes issue 31006: Credit consumed although payment not completed

When consuming a credit with a currency different than Business Partner's currency, an error is shown but credit was also consumed, which was wrong.
Now, this check will be also done before consuming credit in AddPaymentActionHandler addCredit method, as it was done in FIN_PaymentProcess doProcessPayment method.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java
---
(0080821)
vmromanos   
2015-10-05 11:32   
Code review + testing OK
(0082109)
hudsonbot   
2015-11-23 21:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test