Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031004Retail ModulesWeb POSpublic2015-10-01 12:222016-05-18 18:34
Reportermigueldejuana 
Assigned Tomigueldejuana 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q3Fixed in VersionRR16Q3 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031004: A red icon indicating data not synchronised is shown even if nothing needs to be synchronised
DescriptionWhen using the front end in offline mode, a small red icon on the to left corner and a menu entry about data pending to synchronise is shown even if there is no actual data pending to synchronise. See steps.
Steps To Reproduce1. Start in online mode (network connected) by logging in as vallblanca user
2. Create a new ticket for a backpack.
3. Pay it to close the ticket. Check the blue icon shown while synchronising and that the icon disappears when the data has been synchronised.
4. Logout and unplug the network cable to go offline. Log in again as vallblanca user
5. Check that now a red icon is shown and a new menu entry "Pending Sync." was added.
6. Click that entry and see that there is no actual data to synchronise. See attached screenshot.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0030349RR15Q4 closed migueldejuana A red icon indicating data not synchronised is shown even if nothing needs to be synchronised 
depends on defect 0030799RR15Q4 closed migueldejuana [RR15Q4] A red icon indicating data not synchronised is shown even if nothing needs to be synchronised 
depends on defect 0031005RR16Q1 closed jorge-garcia runSyncProcess callback is not executed if last model has no data to synch 
depends on defect 0030958RR16Q3 closed migueldejuana Success callbacks in the RunSyncProcess are sometimes not executed even if the process finished successfully 
Attached Filesdiff issue31004Core.diff (1,613) 2016-03-16 08:43
https://issues.openbravo.com/file_download.php?file_id=9166&type=bug
diff issue31004Posterminal.diff (1,277) 2016-03-16 08:43
https://issues.openbravo.com/file_download.php?file_id=9167&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-10-01 12:22migueldejuanaNew Issue
2015-10-01 12:22migueldejuanaAssigned To => Retail
2015-10-01 12:22migueldejuanaTriggers an Emergency Pack => No
2015-10-01 12:25OrekariaRelationship addeddepends on 0030349
2015-10-01 12:29OrekariaRelationship addeddepends on 0030799
2015-10-26 14:40migueldejuanaNote Added: 0081313
2015-10-26 14:42migueldejuanaRelationship addedrelated to 0031245
2015-10-26 14:45migueldejuanaRelationship addeddepends on 0031005
2015-12-21 18:17OrekariaTarget VersionRR16Q1 =>
2015-12-21 18:38OrekariaTarget Version => RR16Q2
2016-03-16 08:43migueldejuanaFile Added: issue31004Core.diff
2016-03-16 08:43migueldejuanaFile Added: issue31004Posterminal.diff
2016-03-16 08:44migueldejuanaRelationship addeddepends on 0030958
2016-03-16 08:45migueldejuanaNote Added: 0085000
2016-03-16 08:45migueldejuanaNote Edited: 0085000bug_revision_view_page.php?bugnote_id=0085000#r11458
2016-03-31 11:52migueldejuanaTarget VersionRR16Q2 => RR16Q3
2016-04-26 11:36hgbotCheckin
2016-04-26 11:36hgbotNote Added: 0085976
2016-04-26 11:36hgbotStatusnew => resolved
2016-04-26 11:36hgbotResolutionopen => fixed
2016-04-26 11:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/138cd5bce7abec0f67bbcb449297811a591aac4a [^]
2016-04-26 11:37hgbotCheckin
2016-04-26 11:37hgbotNote Added: 0085977
2016-04-26 11:37hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/138cd5bce7abec0f67bbcb449297811a591aac4a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a003f89753a6bc5f79983b831f837955e6ae50c6 [^]
2016-04-26 12:22marvintmAssigned ToRetail => migueldejuana
2016-05-10 11:50dmitry_mezentsevNote Added: 0086343
2016-05-18 18:34guilleaerReview Assigned To => guilleaer
2016-05-18 18:34guilleaerStatusresolved => closed
2016-05-18 18:34guilleaerFixed in Version => RR16Q3

Notes
(0081313)
migueldejuana   
2015-10-26 14:40   
See https://issues.openbravo.com/view.php?id=30799. [^]

It is fixed with:

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/83c54e62ffbf9717bac3deb178d817003a4f1c44 [^]

But first, we need to fix:

syncModel method in login-model.js. It has to call callback when all models are processed.
(0085000)
migueldejuana   
2016-03-16 08:45   
Solution attached
(0085976)
hgbot   
2016-04-26 11:36   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 138cd5bce7abec0f67bbcb449297811a591aac4a
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Apr 25 18:07:43 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/138cd5bce7abec0f67bbcb449297811a591aac4a [^]

Fixed issue 0031004: A red icon indicating data not synchronised is shown even if nothing needs to be synchronised

- We skip dataSynchModels when loading terminal info from from local database. Terminal saved in the local database has not functions, because we cannot convert functions of objects. We shouldn't have tdataSynchModels inside terminal because it is not terminal info, it is code.

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0085977)
hgbot   
2016-04-26 11:37   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a003f89753a6bc5f79983b831f837955e6ae50c6
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Apr 25 18:08:44 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a003f89753a6bc5f79983b831f837955e6ae50c6 [^]

Fixed issue 0031004: A red icon indicating data not synchronised is shown even if nothing needs to be synchronised

- Define presendmodel for Cashup to do not synch model with no new data to synch.

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0086343)
dmitry_mezentsev   
2016-05-10 11:50   
Not closed for 14 days