Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030979Retail ModulesWeb POSpublic2015-09-29 19:172016-02-05 13:46
ReporterOrekaria 
Assigned Tojorge-garcia 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030979: The document sequence is inconsistent when there is more than 1 empty receipt opened
DescriptionThe document sequence is inconsistent when there is more than 1 empty receipt opened
Steps To ReproduceLog in the webpos

1)
Leave the first receipt empty
Create a new receipt, add a product and finish the sale
Verify that the first receipt has seen its docno updated

2)
Leave the first receipt empty
Create a new receipt, leave it empty
Create a third receipt, add a product and finish the sale
Verify that the receipt shown has not seen its docno updated


Verify that, in the orde.js file, there is a method called 'synchronizeCurrentOrder' in which the receipt is updated if is the only existing
Proposed SolutionSince the terminal loading changes, there is no longer the necessity to update the first receipt. Try to get rid of that code.
See diff attached
Additional Information
TagsNo tags attached.
Relationships
related to defect 0031379 closed ranjith_qualiantech_com Duplicated document number when the user session changes 
Attached Filesdiff issue30979.diff (1,758) 2015-10-08 14:21
https://issues.openbravo.com/file_download.php?file_id=8538&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-09-29 19:17OrekariaNew Issue
2015-09-29 19:17OrekariaAssigned To => Retail
2015-09-29 19:17OrekariaTriggers an Emergency Pack => No
2015-10-07 11:01avicenteIssue Monitored: avicente
2015-10-07 12:07ageteIssue Monitored: agete
2015-10-07 13:37adrianromeroAssigned ToRetail => adrianromero
2015-10-08 14:21adrianromeroFile Added: issue30979.diff
2015-10-08 14:21adrianromeroProposed Solution updated
2015-10-08 14:30adrianromeroStatusnew => scheduled
2015-11-06 00:00OrekariaRelationship addedrelated to 0031379
2015-11-09 12:49eduardo_ArgalAssigned Toadrianromero => Orekaria
2015-11-09 12:49eduardo_ArgalStatusscheduled => feedback
2015-11-09 12:49eduardo_ArgalStatusfeedback => new
2015-11-09 12:57OrekariaStatusnew => scheduled
2015-11-09 12:57OrekariaAssigned ToOrekaria => christiangoni
2016-01-13 11:17jorge-garciaAssigned Tochristiangoni => jorge-garcia
2016-01-13 11:19hgbotCheckin
2016-01-13 11:19hgbotNote Added: 0083227
2016-01-13 11:19hgbotStatusscheduled => resolved
2016-01-13 11:19hgbotResolutionopen => fixed
2016-01-13 11:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c8a1eff6bce6b8de2b12a205ed41c2fc83e32f61 [^]
2016-01-13 11:20hgbotCheckin
2016-01-13 11:20hgbotNote Added: 0083229
2016-01-15 12:00hgbotCheckin
2016-01-15 12:00hgbotNote Added: 0083344
2016-01-15 12:01hgbotCheckin
2016-01-15 12:01hgbotNote Added: 0083345
2016-01-22 11:57hgbotCheckin
2016-01-22 11:57hgbotNote Added: 0083562
2016-01-22 11:57hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c8a1eff6bce6b8de2b12a205ed41c2fc83e32f61 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5ed85f6ae00d0de6a63f52d8f999e81675e45ede [^]
2016-02-05 13:46marvintmReview Assigned To => marvintm
2016-02-05 13:46marvintmStatusresolved => closed
2016-02-05 13:46marvintmFixed in Version => RR16Q2

Notes
(0083227)
hgbot   
2016-01-13 11:19   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c8a1eff6bce6b8de2b12a205ed41c2fc83e32f61
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Jan 12 15:29:39 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c8a1eff6bce6b8de2b12a205ed41c2fc83e32f61 [^]

Fixed issue 30979: The document sequence is inconsistent when there is more
than 1 empty receipt opened

The function synchronizeCurrentOrder is not longer used.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0083229)
hgbot   
2016-01-13 11:20   
Repository: tools/automation/pi-mobile
Changeset: 84a9b8e464136237256367a8ac30e85ba573527b
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Jan 12 15:26:59 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/84a9b8e464136237256367a8ac30e85ba573527b [^]

Verifies issue 30979: The document sequence is inconsistent when there is more
than 1 empty receipt opened

Added test I30979_DocSeqInconsistent.

Some other test had been changed due to the new functionality:
* DocumentnoSynchronizationEmptyReceipt
* I28582_NoNewReceiptWhenQueueExists
* I30983_SalesFromQuotationDuplicateDocNo

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/documentno/DocumentnoSynchronizationEmptyReceipt.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I28582_NoNewReceiptWhenQueueExists.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/I30983_SalesFromQuotationDuplicateDocNo.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I30979_DocSeqInconsistent.java
---
(0083344)
hgbot   
2016-01-15 12:00   
Repository: tools/automation/pi-mobile
Changeset: f1c87d63214a676f83e30f1eda9f7f27aa4d72e9
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Jan 15 11:58:56 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f1c87d63214a676f83e30f1eda9f7f27aa4d72e9 [^]

Related to issue 30979: The document sequence is inconsistent when there is
more than 1 empty receipt opened

Eliminate the warning message in pi-mobile

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/documentno/DocumentnoSynchronizationEmptyReceipt.java
---
(0083345)
hgbot   
2016-01-15 12:01   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e3b7c1539224b15af90d87c182eafd505cad9c76
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Jan 15 11:46:57 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e3b7c1539224b15af90d87c182eafd505cad9c76 [^]

Related to issue 30979: The document sequence is inconsistent when there is
more than 1 empty receipt opened

Eliminate the commented lines.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0083562)
hgbot   
2016-01-22 11:57   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 5ed85f6ae00d0de6a63f52d8f999e81675e45ede
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Oct 08 14:07:04 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5ed85f6ae00d0de6a63f52d8f999e81675e45ede [^]

Fixes issue 0030979: The document sequence is inconsistent when there is more than 1 empty receipt opened
* Removing logic in synchronizeCurrentOrder() because with the new document no management is no longer needed

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---