0030920: can't use DB connection defined as JNDI service

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0030920

Openbravo ERP

A. Platform

public

2015-09-24 12:22

2015-10-02 07:39

Reporter

alostale

Assigned To

platform

Priority

immediate

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

open

Platform

OS Version

Product Version

Target Version

3.0PR15Q3.3

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Production - Confirmed Stable

Regression date

2011-01-19

Regression introduced in release

3.0RC4

Regression introduced by commit

https://code.openbravo.com/erp/devel/pi/rev/7fc34fd92373 [^]

Triggers an Emergency Pack

Summary

0030920: can't use DB connection defined as JNDI service

Description

It is not possible to use DB connection defined as JNDI service because even having it configured, direct connection is tried to be created in some places.

The behavior is different depending on OB version:

* 3.0RC4-current pi (pre PR15Q4), this error is risen:
   [main] ERROR org.openbravo.database.ConnectionProviderImpl - Error getting connection java.sql.SQLException: No suitable driver found for null/null
    at java.sql.DriverManager.getConnection(DriverManager.java:689)
    at java.sql.DriverManager.getConnection(DriverManager.java:270)
    at org.openbravo.database.OpenbravoDriverManagerConnectionFactory.createConnection(OpenbravoDriverManagerConnectionFactory.java:55)
* current pi (pre PR15Q4), in same place a ClassCastException is thrown trying to cast JNDIConnectionProvider to ConnectionProviderImpl

Additionally, when it is combined with JdbcExternalConnectionPool:
* it tries to create two pools: one for DAL and another one for xsql connections
* DAL connections try to use direct DB connection rather than JNDI resulting in NPE if those properties are not set

Steps To Reproduce

* Configure Openbravo to use JNDI (removing the rest of direct DB connection settings) [1] removing from Openbravo.properties settings to use direct DB connection
* Start Tomcat

[1] follow documentation in http://wiki.openbravo.com/wiki/Projects:JNDI_Service/Technical_Documentation [^] until 0030918 is fixed

Proposed Solution

Additional Information