Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030907Retail ModulesWeb POSpublic2015-09-23 18:072015-09-30 17:03
Reporterjorge-garcia 
Assigned Tomario_castello 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q4 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030907: Change messages to ad_messages
DescriptionSome messages are hard-coded in the businesspartner.js and sharedcomponent.js files. It's necessary to change these messages to ad_messages type.
Messages:
* Name is required for BPartner
* Adress is required for BPartner
Steps To Reproduce1) Go to businesspartner.js file
2) Search 'Name is required for BPartner'
3) These message must be ad_messages
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0030829 closed jorge-garcia Address field should be mandatory when creating BPs or BPLocs in Web POS 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-09-23 18:07jorge-garciaNew Issue
2015-09-23 18:07jorge-garciaAssigned To => Retail
2015-09-23 18:07jorge-garciaOBNetwork customer => No
2015-09-23 18:07jorge-garciaTriggers an Emergency Pack => No
2015-09-24 16:50mario_castelloAssigned ToRetail => mario_castello
2015-09-25 03:49hgbotCheckin
2015-09-25 03:49hgbotNote Added: 0080631
2015-09-25 03:49hgbotStatusnew => resolved
2015-09-25 03:49hgbotResolutionopen => fixed
2015-09-25 03:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/115bf2ff4ad4ae5c28af3a0c48bcf45d9acf75e4 [^]
2015-09-25 11:01OrekariaReview Assigned To => guilleaer
2015-09-29 09:01guilleaerNote Added: 0080682
2015-09-29 09:01guilleaerStatusresolved => new
2015-09-29 09:01guilleaerResolutionfixed => open
2015-09-29 18:15hgbotCheckin
2015-09-29 18:15hgbotNote Added: 0080720
2015-09-29 20:13guilleaerStatusnew => scheduled
2015-09-29 20:14guilleaerNote Added: 0080723
2015-09-29 20:14guilleaerStatusscheduled => resolved
2015-09-29 20:14guilleaerFixed in Version => RR15Q4
2015-09-29 20:14guilleaerResolutionopen => fixed
2015-09-29 20:14guilleaerNote Added: 0080724
2015-09-29 20:14guilleaerStatusresolved => closed
2015-09-30 16:21jorge-garciaRelationship addeddepends on 0030829
2015-09-30 17:03hgbotCheckin
2015-09-30 17:03hgbotNote Added: 0080759

Notes
(0080631)
hgbot   
2015-09-25 03:49   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 115bf2ff4ad4ae5c28af3a0c48bcf45d9acf75e4
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Sep 24 19:49:04 2015 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/115bf2ff4ad4ae5c28af3a0c48bcf45d9acf75e4 [^]

Fixed issue 30907: Change messages to ad_messages

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/js/model/businesspartner.js
---
(0080682)
guilleaer   
2015-09-29 09:01   
A message which is not being used is added but it is not needed.

Apart from that this message has typo.

Address --> not ->> Adress
(0080720)
hgbot   
2015-09-29 18:15   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 347d48da101eae6074df4c429924b01b18711394
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue Sep 29 10:14:15 2015 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/347d48da101eae6074df4c429924b01b18711394 [^]

Related to issue 30907: Delete unused message

---
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0080723)
guilleaer   
2015-09-29 20:14   
http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/347d48da101eae6074df4c429924b01b18711394 [^]
(0080724)
guilleaer   
2015-09-29 20:14   
tested and verified
(0080759)
hgbot   
2015-09-30 17:03   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 391f0c29830eab476a5b7883fca2c02bf0b53286
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Sep 30 16:56:57 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/391f0c29830eab476a5b7883fca2c02bf0b53286 [^]

Related to issue 30907: Change messages to ad_messages

Added the message for the warning of Address Field

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/js/model/businesspartner.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/components/sharedcomponents.js
---