Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030892Retail ModulesWeb POSpublic2015-09-22 17:352015-10-19 11:18
Reporterguillermogil 
Assigned Tofmolina 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030892: You can add more quantity to not grouped lines
DescriptionIf "+", "-" or "Quantity" button are clicked while having selected a not grouped line you can add more Quantity.
Steps To Reproduce* Uncheck "Grouped" check of "Avalanche Transceiver" product
* Go to WebPOS
* Add "Avalanche Transceiver" product
* Click "+" button

You have a line with quantity 2 and a not grouped product
Proposed SolutionDeactivate those 3 buttons if it a not grouped line is selected
Additional Information
TagsNo tags attached.
Relationships
related to defect 0032069 closed ranjith_qualiantech_com Button quantity must be disabled if there is a non grouped product in a multiple lines selection 
related to defect 0040821 closed rqueralta Avoid to add lines of non grouped products with + and - keyboard keys 
blocks defect 0031105 scheduled jorge-garcia Adding lines of ungrouped products, can halt the webpos 
causes defect 0032048 closed jorge-garcia Click "-" button on a negative line of a not grouped product generates a positive line 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-09-22 17:35guillermogilNew Issue
2015-09-22 17:35guillermogilAssigned To => Retail
2015-09-22 17:35guillermogilResolution time => 1443391200
2015-09-22 17:35guillermogilTriggers an Emergency Pack => No
2015-09-25 18:41fmolinaStatusnew => scheduled
2015-09-25 18:41fmolinaAssigned ToRetail => fmolina
2015-10-08 16:44OrekariaRelationship addedblocks 0031105
2015-10-15 01:44hgbotCheckin
2015-10-15 01:44hgbotNote Added: 0081028
2015-10-15 01:44hgbotStatusscheduled => resolved
2015-10-15 01:44hgbotResolutionopen => fixed
2015-10-15 01:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a4a8f4d83fa4af52028b0054b53a3beae9e2d286 [^]
2015-10-15 01:50hgbotCheckin
2015-10-15 01:50hgbotNote Added: 0081029
2015-10-15 07:33guillermogilNote Added: 0081030
2015-10-16 11:00OrekariaReview Assigned To => marvintm
2015-10-17 01:44hgbotCheckin
2015-10-17 01:44hgbotNote Added: 0081059
2015-10-17 01:44hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a4a8f4d83fa4af52028b0054b53a3beae9e2d286 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d562c7c609e132cdcbdffa0523002f8959728eb9 [^]
2015-10-17 01:46hgbotCheckin
2015-10-17 01:46hgbotNote Added: 0081060
2015-10-17 01:46hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d562c7c609e132cdcbdffa0523002f8959728eb9 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/025c9b8b7c78e3c14aeacdfe26b97a20b074f685 [^]
2015-10-17 02:14hgbotCheckin
2015-10-17 02:14hgbotNote Added: 0081063
2015-10-19 11:18marvintmStatusresolved => closed
2015-10-19 11:18marvintmFixed in Version => RR16Q1
2016-02-12 10:58dmitry_mezentsevRelationship addedcauses 0032048
2016-03-15 16:48OrekariaRelationship addedrelated to 0032069
2019-05-09 13:07ngarciaRelationship addedrelated to 0040821

Notes
(0081028)
hgbot   
2015-10-15 01:44   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a4a8f4d83fa4af52028b0054b53a3beae9e2d286
Author: Facundo Molina <fmolina <at> koodu.es>
Date: Wed Oct 14 20:44:06 2015 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a4a8f4d83fa4af52028b0054b53a3beae9e2d286 [^]

Fixed issue 30892: create new line when add quantity to not grouped products

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
---
(0081029)
hgbot   
2015-10-15 01:50   
Repository: tools/automation/pi-mobile
Changeset: 60d6384da973d971900d4c370d7b85adcffe27cc
Author: Facundo Molina <fmolina <at> koodu.es>
Date: Wed Oct 14 20:40:22 2015 -0300
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/60d6384da973d971900d4c370d7b85adcffe27cc [^]

Related to issue 30892: test for check the correct behaviour. Update some other tests to adapt it to the new behaviour.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/Communit6780_FixedPercentageDiscount.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I30741_LayawayVerifyShipmentLineQuantity.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I30892_AddMoreQtyNotGroupedProducts.java
---
(0081030)
guillermogil   
2015-10-15 07:33   
This code is removing a line of this commint:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/73db175c828c41a5cfa3ac4f3a3378c058ce90bc [^]

This is the issue:
https://issues.openbravo.com/view.php?id=25655 [^]

Does this code fullfil this issue and the other?

Also, there are double quotes and hardcoded messages.
(0081059)
hgbot   
2015-10-17 01:44   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d562c7c609e132cdcbdffa0523002f8959728eb9
Author: Facundo Molina <fmolina <at> koodu.es>
Date: Fri Oct 16 19:25:02 2015 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d562c7c609e132cdcbdffa0523002f8959728eb9 [^]

Fixes issue 30892: disable quantity button when a not gropued product is added or selected in the receipt

---
M web/org.openbravo.retail.posterminal/js/components/renderorderline.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0081060)
hgbot   
2015-10-17 01:46   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 025c9b8b7c78e3c14aeacdfe26b97a20b074f685
Author: Facundo Molina <fmolina <at> koodu.es>
Date: Fri Oct 16 19:25:55 2015 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/025c9b8b7c78e3c14aeacdfe26b97a20b074f685 [^]

Fixes issue 30892: disable quantity button when a not gropued product is added or selected in the receipt

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---
(0081063)
hgbot   
2015-10-17 02:14   
Repository: tools/automation/pi-mobile
Changeset: 5a4dc2522bcc30ed33399d3221ea2ce7341aee37
Author: Facundo Molina <fmolina <at> koodu.es>
Date: Fri Oct 16 16:05:37 2015 -0300
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/5a4dc2522bcc30ed33399d3221ea2ce7341aee37 [^]

Related to issue 30892: test that the quantity button is disabled when a not gropued product is added or selected in the receipt

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I30892_AddMoreQtyNotGroupedProducts.java
---