Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030885Retail ModulesWeb POSpublic2015-09-22 10:122015-12-24 03:30
Reportergorkaion 
Assigned Tojonibc 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q1Fixed in VersionRR16Q1 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030885: Add Use on Web POS flag in characteristics
DescriptionAdd a new flag on product characteristic to define if they are going to be used in Web POS or not. Currently there are 2 scenarios where the characteristics are useful.

* To search products by characteristics. This can be configured in the Characteristic Window
* By Discounts and Promotions that can be applied to specific characteristic values.

The development should include a callout in the flag to check if the characteristic is currently used in a Promotion and Discount to show a warning.

It should also include an Alert to check for disabled characteristics that are used in a Promotion.
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff issue30885.diff (29,335) 2015-10-14 10:33
https://issues.openbravo.com/file_download.php?file_id=8564&type=bug
diff TestUseOnWebPosFlag.diff (5,543) 2015-10-14 10:38
https://issues.openbravo.com/file_download.php?file_id=8565&type=bug
diff retailSampledataChanges.diff (165,126) 2015-11-13 13:29
https://issues.openbravo.com/file_download.php?file_id=8718&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-09-22 10:12gorkaionNew Issue
2015-09-22 10:12gorkaionAssigned To => jonibc
2015-09-22 10:12gorkaionTriggers an Emergency Pack => No
2015-10-14 10:33jonibcFile Added: issue30885.diff
2015-10-14 10:38jonibcFile Added: TestUseOnWebPosFlag.diff
2015-11-13 13:29jonibcFile Added: retailSampledataChanges.diff
2015-11-27 11:23hgbotCheckin
2015-11-27 11:23hgbotNote Added: 0082416
2015-11-27 11:23hgbotStatusnew => resolved
2015-11-27 11:23hgbotResolutionopen => fixed
2015-11-27 11:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8f7c8634503fcf5f670f54f1d0780ba566fd62a0 [^]
2015-11-27 11:28hgbotCheckin
2015-11-27 11:28hgbotNote Added: 0082419
2015-11-27 11:29hgbotCheckin
2015-11-27 11:29hgbotNote Added: 0082420
2015-11-27 14:31OrekariaNote Added: 0082434
2015-11-27 14:31OrekariaStatusresolved => new
2015-11-27 14:31OrekariaResolutionfixed => open
2015-11-27 14:32OrekariaNote Edited: 0082434bug_revision_view_page.php?bugnote_id=0082434#r10380
2015-12-07 10:59marvintmStatusnew => scheduled
2015-12-07 10:59marvintmStatusscheduled => resolved
2015-12-07 10:59marvintmFixed in Version => RR16Q1
2015-12-07 10:59marvintmResolutionopen => fixed
2015-12-07 10:59marvintmNote Added: 0082585
2015-12-09 10:24OrekariaNote Added: 0082607
2015-12-09 10:24OrekariaStatusresolved => new
2015-12-09 10:24OrekariaResolutionfixed => open
2015-12-09 10:24OrekariaFixed in VersionRR16Q1 =>
2015-12-09 11:08hgbotCheckin
2015-12-09 11:08hgbotNote Added: 0082609
2015-12-18 10:35hgbotCheckin
2015-12-18 10:35hgbotNote Added: 0082867
2015-12-21 15:35hgbotCheckin
2015-12-21 15:35hgbotNote Added: 0082905
2015-12-21 15:42OrekariaStatusnew => scheduled
2015-12-21 15:42OrekariaStatusscheduled => resolved
2015-12-21 15:42OrekariaFixed in Version => RR16Q1
2015-12-21 15:42OrekariaResolutionopen => fixed
2015-12-21 15:43OrekariaReview Assigned To => guilleaer
2015-12-21 16:48hgbotCheckin
2015-12-21 16:48hgbotNote Added: 0082907
2015-12-24 03:30OrekariaReview Assigned Toguilleaer => Orekaria
2015-12-24 03:30OrekariaStatusresolved => closed
2016-04-07 13:10SandrahuguetRelationship addedrelated to 0032533
2016-04-18 16:54SandrahuguetRelationship deletedrelated to 0032533

Notes
(0082416)
hgbot   
2015-11-27 11:23   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8f7c8634503fcf5f670f54f1d0780ba566fd62a0
Author: Jonathan Bueno <jonathan.bueno <at> openbravo.com>
Date: Fri Nov 27 11:23:37 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8f7c8634503fcf5f670f54f1d0780ba566fd62a0 [^]

Fixed issue 30885. Add Use on Web POS flag in characteristics

---
M src-db/database/model/modifiedTables/M_CHARACTERISTIC.xml
M src-db/database/sourcedata/AD_CALLOUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M src/org/openbravo/retail/posterminal/master/CharacteristicValue.java
M src/org/openbravo/retail/posterminal/master/ProductCharacteristicValue.java
A src/org/openbravo/retail/posterminal/UseonWebPOSFICExtension.java
A src/org/openbravo/retail/posterminal/ad_callouts/CharacteristicVerification.java
---
(0082419)
hgbot   
2015-11-27 11:28   
Repository: tools/automation/pi-mobile
Changeset: 4e77913b2de65f5b9a66656452318995e59ce2c0
Author: Jonathan Bueno <jonathan.bueno <at> openbravo.com>
Date: Fri Nov 27 11:28:48 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/4e77913b2de65f5b9a66656452318995e59ce2c0 [^]

Related to issue 30885. Added automated test

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/Communit8624UseOnWebPOSFlag.java
---
(0082420)
hgbot   
2015-11-27 11:29   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: 2b5342b46c202de09885a1e4c8e365d96a282dc7
Author: Jonathan Bueno <jonathan.bueno <at> openbravo.com>
Date: Fri Nov 27 08:48:45 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/2b5342b46c202de09885a1e4c8e365d96a282dc7 [^]

Related to issue 30885. Added sampledata for automated test

---
M referencedata/sampledata/The_White_Valley_Group/AD_IMAGE.xml
M referencedata/sampledata/The_White_Valley_Group/AD_ROLE.xml
M referencedata/sampledata/The_White_Valley_Group/AD_SEQUENCE.xml
M referencedata/sampledata/The_White_Valley_Group/AD_TREENODE.xml
M referencedata/sampledata/The_White_Valley_Group/C_ORDER.xml
M referencedata/sampledata/The_White_Valley_Group/C_ORDERLINE.xml
M referencedata/sampledata/The_White_Valley_Group/C_ORDERLINETAX.xml
M referencedata/sampledata/The_White_Valley_Group/C_ORDERTAX.xml
M referencedata/sampledata/The_White_Valley_Group/FIN_PAYMENT.xml
M referencedata/sampledata/The_White_Valley_Group/FIN_PAYMENT_SCHEDULE.xml
M referencedata/sampledata/The_White_Valley_Group/FIN_PAYMENT_SCHEDULEDETAIL.xml
M referencedata/sampledata/The_White_Valley_Group/M_CHARACTERISTIC.xml
M referencedata/sampledata/The_White_Valley_Group/M_CH_VALUE.xml
M referencedata/sampledata/The_White_Valley_Group/M_COSTING.xml
M referencedata/sampledata/The_White_Valley_Group/M_INOUT.xml
M referencedata/sampledata/The_White_Valley_Group/M_INOUTLINE.xml
M referencedata/sampledata/The_White_Valley_Group/M_MATCHPO.xml
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
M referencedata/sampledata/The_White_Valley_Group/M_OFFER_PRODUCT.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCT.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCTPRICE.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCT_ACCT.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCT_CH.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCT_CH_VALUE.xml
M referencedata/sampledata/The_White_Valley_Group/M_STORAGE_DETAIL.xml
M referencedata/sampledata/The_White_Valley_Group/M_STORAGE_PENDING.xml
M referencedata/sampledata/The_White_Valley_Group/M_TRANSACTION.xml
M referencedata/sampledata/The_White_Valley_Group/M_TRANSACTION_COST.xml
M referencedata/sampledata/The_White_Valley_Group/OBRETCO_PROL_PRODUCT.xml
M referencedata/sampledata/The_White_Valley_Group/OBUIAPP_PROCESS_ACCESS.xml
A referencedata/sampledata/The_White_Valley_Group/C_ORDERLINE_OFFER.xml
A referencedata/sampledata/The_White_Valley_Group/M_OFFER_CHARACTERISTIC.xml
A referencedata/sampledata/The_White_Valley_Group/OBPOS_APP_CASHUP.xml
---
(0082434)
Orekaria   
2015-11-27 14:31   
(edited on: 2015-11-27 14:32)
The 'Communit8624UseOnWebPOSFlag' test:
- is missing the correct license and author
- has java warnings
- does not verify that the sale transactions have been properly created in the server
- the @after should not execute the same database query if the test does not fail

More tests are required to:
- verify that the discounts and promotions are working
- verify that the search products is working
- verify that the alert/warning is working
- if amounts are being modified, a test with a cashup and verifycations that the transactions are correct, must be done
- ...

The tests MUST verify that the functionality is working AND that will not be broken by other developers
I cannot see that the functionality is being verified with that single test
(0082585)
marvintm   
2015-12-07 10:59   
The documentation is missing in the wiki.
(0082607)
Orekaria   
2015-12-09 10:24   
see previous test notes
(0082609)
hgbot   
2015-12-09 11:08   
Repository: tools/automation/pi-mobile
Changeset: 177114a7f0adeb73dcf97fc74b44f34ba5554ae1
Author: Jonathan Bueno <jonathan.bueno <at> openbravo.com>
Date: Wed Dec 09 11:07:48 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/177114a7f0adeb73dcf97fc74b44f34ba5554ae1 [^]

Fixed test for issue 30885, added check for cashup and creation of order

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/Communit8624UseOnWebPOSFlag.java
---
(0082867)
hgbot   
2015-12-18 10:35   
Repository: tools/automation/pi-mobile
Changeset: fc26f197f01cc87d3244893856d92e8dc68206d3
Author: Jonathan Bueno <jonathan.bueno <at> openbravo.com>
Date: Fri Dec 18 09:35:22 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/fc26f197f01cc87d3244893856d92e8dc68206d3 [^]

Related to issue 30885: Fixed automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I30885_Communit8624UseOnWebPOSFlag.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/Communit8624UseOnWebPOSFlag.java
---
(0082905)
hgbot   
2015-12-21 15:35   
Repository: tools/automation/pi-mobile
Changeset: 7ae55a7582124723b494a51e036bab6f9e93b0aa
Author: Jonathan Bueno <jonathan.bueno <at> openbravo.com>
Date: Mon Dec 21 15:35:14 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/7ae55a7582124723b494a51e036bab6f9e93b0aa [^]

Related to issue 30885: Fixed automated test, added check in WebSQL

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I30885_Communit8624UseOnWebPOSFlag.java
---
(0082907)
hgbot   
2015-12-21 16:48   
Repository: tools/automation/pi-mobile
Changeset: 6f74e9ad7e8a17a0d7fbe6e9126ff112114925d6
Author: Jonathan Bueno <jonathan.bueno <at> openbravo.com>
Date: Mon Dec 21 16:48:35 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6f74e9ad7e8a17a0d7fbe6e9126ff112114925d6 [^]

Related to issue 30885, solved minor problem

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I30885_Communit8624UseOnWebPOSFlag.java
---