Openbravo Issue Tracking System - Retail Modules
View Issue Details
0030875Retail ModulesWeb POSpublic2015-09-21 13:192015-10-19 11:02
marvintm 
jorge-garcia 
urgentmajorhave not tried
closedfixed 
5
 
RR16Q1RR16Q1 
marvintm
OBPS
38352
No
0030875: The pay button becomes indefinitely disabled when computing discounts
In very specific circumstances, the pay button may become indefinitely disabled when computing certain discounts.

For this problem to happen, the following items must be true:
- System needs to be not in development
- There needs to be two discounts for the same rule type in the system, which apply to the same products, with different priority
- The ticket must have more than one line, and these lines must all be affected by the same discounts

If these conditions are true, the pay button becomes disabled if the discounts engine at some point finds a better discount than the one it had applied.

- Define one discount, 3x2 in bottles (the one in the standard sampledata is fine), with priority 20
- Define another discount, 9x6 in bottles, with priority 10
- Ensure both discounts work for 1L bottle, and Plastic bottle
- Go to the Web POS (in not in development mode)
- Add one Plastic bottle product
- Add (one by one), 8 units of 1L bottle.
- Verify that after the eight one, the pay button becomes disabled and is never enabled.
The executor engine must be changed to ensure that if an event is replaced, it's correctly terminated.
No tags attached.
Issue History
2015-09-21 13:19marvintmNew Issue
2015-09-21 13:19marvintmAssigned To => Retail
2015-09-21 13:19marvintmOBNetwork customer => No
2015-09-21 13:19marvintmTriggers an Emergency Pack => No
2015-09-22 11:25egoitzOBNetwork customerNo => Yes
2015-09-22 11:25egoitzSupport ticket => 38352
2015-09-22 11:25egoitzResolution time => 1443650400
2015-09-22 11:26egoitzIssue Monitored: egoitz
2015-10-05 12:07OrekariaStatusnew => scheduled
2015-10-05 12:07OrekariaAssigned ToRetail => jorge-garcia
2015-10-15 15:59hgbotCheckin
2015-10-15 15:59hgbotNote Added: 0081044
2015-10-15 15:59hgbotStatusscheduled => resolved
2015-10-15 15:59hgbotResolutionopen => fixed
2015-10-15 15:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eced2bd0d5358958f36cba3829cce156c5774e12 [^]
2015-10-16 10:35hgbotCheckin
2015-10-16 10:35hgbotNote Added: 0081052
2015-10-16 10:35hgbotCheckin
2015-10-16 10:35hgbotNote Added: 0081053
2015-10-19 11:02marvintmReview Assigned To => marvintm
2015-10-19 11:02marvintmStatusresolved => closed
2015-10-19 11:02marvintmFixed in Version => RR16Q1

Notes
(0081044)
hgbot   
2015-10-15 15:59   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: eced2bd0d5358958f36cba3829cce156c5774e12
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Oct 06 17:29:55 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eced2bd0d5358958f36cba3829cce156c5774e12 [^]

Fixed issue 30875: The pay button becomes disabled when computing discounts

The pay button becomes indefinitely disabled when computing discounts.

---
M web/org.openbravo.retail.posterminal/js/model/executor.js
---
(0081052)
hgbot   
2015-10-16 10:35   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: 90e8d6494f758ea476b6e1e90e4e958f266bfad9
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Oct 16 09:02:01 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/90e8d6494f758ea476b6e1e90e4e958f266bfad9 [^]

Related to issue 30875: The pay button is indefinitely disabled with discounts

Changes on the sampledata are necessary for the test.

---
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
M referencedata/sampledata/The_White_Valley_Group/M_OFFER_PRODUCT.xml
---
(0081053)
hgbot   
2015-10-16 10:35   
Repository: tools/automation/pi-mobile
Changeset: 17fb79c82dba2383bbbd55fbdd26e2b5e3f66dfd
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Oct 16 09:03:29 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/17fb79c82dba2383bbbd55fbdd26e2b5e3f66dfd [^]

Verify issue 30875: The pay button becomes indefinitely disabled with discounts

Added test I30875_PayButtonIndefinitelyDisabled

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I30875_PayButtonIndefinitelyDisabled.java
---